address more review comments

This commit is contained in:
Mahmood Ali 2019-11-22 13:07:54 -05:00
parent eda18fff76
commit 12e65c054d
1 changed files with 9 additions and 8 deletions

View File

@ -729,13 +729,15 @@ plugin "docker" {
* `dangling_containers` stanza for controlling dangling container detection * `dangling_containers` stanza for controlling dangling container detection
and cleanup: and cleanup:
* `enabled` - Defaults to `true`. Enables dangling container handling. * `enabled` - Defaults to `true`. Enables dangling container handling.
* `dry_run` - Defaults to `false`. Enables a mode where nomad logs * `dry_run` - Defaults to `false`. Only log dangling containers without
potential dangling containers without killing them. cleaning them up.
* `period` - Defaults to `"5m"`. A time duration that controls interval * `period` - Defaults to `"5m"`. A time duration that controls interval
between Nomad scans for dangling containers. between Nomad scans for dangling containers.
* `creation_grace` - Defaults to `"5m"`. A time duration that controls * `creation_grace` - Defaults to `"5m"`. Grace period after a container is
how long a container can run before it is tracked by Nomad or gets created during which the GC ignores it. Only used to prevent the GC from
marked (and killed) as a dangling container removing newly created containers before they are registered with the
GC. Should not need adjusting higher but may be adjusted lower to GC
more aggressively.
* `volumes` stanza: * `volumes` stanza:
* `enabled` - Defaults to `true`. Allows tasks to bind host paths * `enabled` - Defaults to `true`. Allows tasks to bind host paths
@ -917,8 +919,7 @@ reasons, it is recommended to use full virtualization like
Nomad 0.10.2 introduces a detector and a reaper for dangling Docker containers, Nomad 0.10.2 introduces a detector and a reaper for dangling Docker containers,
containers that Nomad starts yet does not manage or track. Though rare, they containers that Nomad starts yet does not manage or track. Though rare, they
sometimes in very loaded clusters and lead to unexpectedly running services, lead to unexpectedly running services, potentially with stale versions.
potentially with stale versions.
When Docker daemon becomes unavailable as Nomad starts a task, it is possible When Docker daemon becomes unavailable as Nomad starts a task, it is possible
for Docker to successfully start the container and fails the API call with 500 for Docker to successfully start the container and fails the API call with 500