make stop job message clearer (#12252)

This commit is contained in:
Karthick Ramachandran 2022-03-24 13:38:43 -07:00 committed by GitHub
parent e7382a6b45
commit 122115c0ba
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
7 changed files with 19 additions and 16 deletions

3
.changelog/12252.txt Normal file
View File

@ -0,0 +1,3 @@
```release-note:improvement
ui: make buttons with confirmation more descriptive of their actions
```

View File

@ -42,9 +42,9 @@
<TwoStepButton <TwoStepButton
data-test-stop data-test-stop
@alignRight={{true}} @alignRight={{true}}
@idleText="Stop" @idleText="Stop Alloc"
@cancelText="Cancel" @cancelText="Cancel Stop"
@confirmText="Yes, Stop" @confirmText="Yes, Stop Alloc"
@confirmationMessage="Are you sure? This will reschedule the allocation on a different client." @confirmationMessage="Are you sure? This will reschedule the allocation on a different client."
@awaitingConfirmation={{this.stopAllocation.isRunning}} @awaitingConfirmation={{this.stopAllocation.isRunning}}
@disabled={{or @disabled={{or
@ -56,9 +56,9 @@
<TwoStepButton <TwoStepButton
data-test-restart data-test-restart
@alignRight={{true}} @alignRight={{true}}
@idleText="Restart" @idleText="Restart Alloc"
@cancelText="Cancel" @cancelText="Cancel Restart"
@confirmText="Yes, Restart" @confirmText="Yes, Restart Alloc"
@confirmationMessage="Are you sure? This will restart the allocation in-place." @confirmationMessage="Are you sure? This will restart the allocation in-place."
@awaitingConfirmation={{this.restartAllocation.isRunning}} @awaitingConfirmation={{this.restartAllocation.isRunning}}
@disabled={{or @disabled={{or

View File

@ -53,9 +53,9 @@
<TwoStepButton <TwoStepButton
data-test-restart data-test-restart
@alignRight={{true}} @alignRight={{true}}
@idleText="Restart" @idleText="Restart Task"
@cancelText="Cancel" @cancelText="Cancel"
@confirmText="Yes, Restart" @confirmText="Yes, Restart Task"
@confirmationMessage="Are you sure? This will restart the task in-place." @confirmationMessage="Are you sure? This will restart the task in-place."
@awaitingConfirmation={{this.restartTask.isRunning}} @awaitingConfirmation={{this.restartTask.isRunning}}
@disabled={{this.restartTask.isRunning}} @disabled={{this.restartTask.isRunning}}

View File

@ -197,7 +197,7 @@
data-test-drain-stop data-test-drain-stop
@idleText="Stop Drain" @idleText="Stop Drain"
@cancelText="Cancel" @cancelText="Cancel"
@confirmText="Yes, Stop" @confirmText="Yes, Stop Drain"
@confirmationMessage="Are you sure you want to stop this drain?" @confirmationMessage="Are you sure you want to stop this drain?"
@awaitingConfirmation={{this.stopDrain.isRunning}} @awaitingConfirmation={{this.stopDrain.isRunning}}
@onConfirm={{perform this.stopDrain}} @onConfirm={{perform this.stopDrain}}

View File

@ -24,7 +24,7 @@
confirmButton="is-danger"}} confirmButton="is-danger"}}
@idleText="Fail Deployment" @idleText="Fail Deployment"
@cancelText="Cancel" @cancelText="Cancel"
@confirmText="Yes, Fail" @confirmText="Yes, Fail Deployment"
@confirmationMessage="Are you sure?" @confirmationMessage="Are you sure?"
@inlineText={{true}} @inlineText={{true}}
@awaitingConfirmation={{this.fail.isRunning}} @awaitingConfirmation={{this.fail.isRunning}}

View File

@ -18,9 +18,9 @@
<TwoStepButton <TwoStepButton
data-test-stop data-test-stop
@alignRight={{true}} @alignRight={{true}}
@idleText="Stop" @idleText="Stop Job"
@cancelText="Cancel" @cancelText="Cancel"
@confirmText="Yes, Stop" @confirmText="Yes, Stop Job"
@confirmationMessage="Are you sure you want to stop this job?" @confirmationMessage="Are you sure you want to stop this job?"
@awaitingConfirmation={{this.stopJob.isRunning}} @awaitingConfirmation={{this.stopJob.isRunning}}
@onConfirm={{perform this.stopJob}} /> @onConfirm={{perform this.stopJob}} />
@ -28,9 +28,9 @@
<TwoStepButton <TwoStepButton
data-test-start data-test-start
@alignRight={{true}} @alignRight={{true}}
@idleText="Start" @idleText="Start Job"
@cancelText="Cancel" @cancelText="Cancel"
@confirmText="Yes, Start" @confirmText="Yes, Start Job"
@confirmationMessage="Are you sure you want to start this job?" @confirmationMessage="Are you sure you want to start this job?"
@awaitingConfirmation={{this.startJob.isRunning}} @awaitingConfirmation={{this.startJob.isRunning}}
@onConfirm={{perform this.startJob}} /> @onConfirm={{perform this.startJob}} />

View File

@ -17,9 +17,9 @@
idleButton="is-warning is-outlined" idleButton="is-warning is-outlined"
confirmButton="is-warning"}} confirmButton="is-warning"}}
@alignRight={{true}} @alignRight={{true}}
@idleText="Revert" @idleText="Revert Version"
@cancelText="Cancel" @cancelText="Cancel"
@confirmText="Yes, Revert" @confirmText="Yes, Revert Version"
@confirmationMessage="Are you sure you want to revert to this version?" @confirmationMessage="Are you sure you want to revert to this version?"
@inlineText={{true}} @inlineText={{true}}
@fadingBackground={{true}} @fadingBackground={{true}}