luxolus/open-nomad
2
0
Fork 0
Code Issues 1 Pull requests Packages Releases Wiki Activity

Merge pull request #7492 from hashicorp/doc-fielddiff-comparison-reminder

Browse source 
doc: add a reminder about field order for diff comparisons
This commit is contained in:
Seth Hoenig 2020-03-25 09:40:54 -06:00 committed by GitHub
parent 1c1186b344 8209eb4d80
commit 109a2bc307
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
contributing/checklist-jobspec.md
View file

@ -17,6 +17,7 @@
* Implement other methods and tests from `api/` package * Implement other methods and tests from `api/` package
* [ ] Add conversion between `api/` and `nomad/structs` in `command/agent/job_endpoint.go` * [ ] Add conversion between `api/` and `nomad/structs` in `command/agent/job_endpoint.go`
* [ ] Add check for job diff in `nomad/structs/diff.go` * [ ] Add check for job diff in `nomad/structs/diff.go`
* Note that fields must be listed in alphabetical order in `FieldDiff` slices in `nomad/structs/diff_test.go`
* [ ] Test conversion * [ ] Test conversion
## Docs ## Docs