luxolus/open-nomad
2
0
Fork 0
Code Issues 1 Pull requests Packages Releases Wiki Activity

Merge pull request #2339 from hashicorp/b-job-delete

Browse source 
Deregistering non-existant job returns 404
This commit is contained in:
Alex Dadgar 2017-02-20 20:11:24 -08:00 committed by GitHub
parent dd6a4fead8 1e5183fb89
commit 084b63e711
2 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
command/agent/job_endpoint.go
View file

@ -327,7 +327,11 @@ func (s *HTTPServer) jobDelete(resp http.ResponseWriter, req *http.Request,
s.parseRegion(req, &args.Region) s.parseRegion(req, &args.Region)
var out structs.JobDeregisterResponse var out structs.JobDeregisterResponse
if err := s.agent.RPC("Job.Deregister", &args, &out); err != nil { err := s.agent.RPC("Job.Deregister", &args, &out)
if err != nil {
if strings.HasSuffix(err.Error(), "does not exist") {
return nil, CodedError(404, err.Error())
}
return nil, err return nil, err
} }
setIndex(resp, out.Index) setIndex(resp, out.Index)

4
nomad/job_endpoint.go
View file

@ -389,6 +389,10 @@ func (j *Job) Deregister(args *structs.JobDeregisterRequest, reply *structs.JobD
return err return err
} }
if job == nil {
return fmt.Errorf("job %q does not exist", args.JobID)
}
// Commit this update via Raft // Commit this update via Raft
_, index, err := j.srv.raftApply(structs.JobDeregisterRequestType, args) _, index, err := j.srv.raftApply(structs.JobDeregisterRequestType, args)
if err != nil { if err != nil {