luxolus/open-nomad
2
0
Fork 0
Code Issues 1 Pull requests Packages Releases Wiki Activity

Memoize the tracker and the series properties to avoid repeat computation

Browse source 
In addition to this computation being wasteful, it introduces a bug
where the allocation on a stats tracker can update twice in one render,
which isn't allowed in Glimmer (ironically, Glimmmer's lack of
auto-memoization introduced the issue).
This commit is contained in:
Michael Lange 2021-03-19 14:31:27 -07:00
parent 6a8d3340b0
commit 0016290871
1 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
ui/app/components/primary-metric/allocation.js
View file

@ -3,10 +3,9 @@ import Component from '@glimmer/component';
import { task, timeout } from 'ember-concurrency';
import { assert } from '@ember/debug';
import { inject as service } from '@ember/service';
import { action, get } from '@ember/object';
import { action, get, computed } from '@ember/object';
export default class NodePrimaryMetric extends Component {
@service token;
export default class AllocationPrimaryMetric extends Component {
@service('stats-trackers-registry') statsTrackersRegistry;
/** Args
@ -19,8 +18,13 @@ export default class NodePrimaryMetric extends Component {
return this.args.metric;
}
get allocation() {
return this.args.allocation;
}
@computed('allocation')
get tracker() {
return this.statsTrackersRegistry.getTracker(this.args.allocation);
return this.statsTrackersRegistry.getTracker(this.allocation);
}
get data() {
@ -28,6 +32,7 @@ export default class NodePrimaryMetric extends Component {
return get(this, `tracker.${this.metric}`);
}
@computed('tracker.tasks.[]', 'metric')
get series() {
const ret = this.tracker.tasks
.map(task => ({