luxolus
/
open-nomad
2
0
Fork 0
Code Issues 1 Pull Requests Packages Releases Wiki Activity
open-nomad/ui/.eslintrc.js

73 lines
1.6 KiB
JavaScript
Raw Normal View History

Update to Ember 3.16/Data 3.12 (#8319) This updates to Ember 3.16 but leaves Ember Data at 3.12 so we don’t need to use the model fragments beta. It can be reviewed on a commit-by-commit basis: blueprint updates, fixes for test failures, and the removal of now-deprecated partials. It’s not a true update to Octane as that would involve turning on template-only components by default, which breaks various things. We can accomplish that separately and then add the edition setting to package.json.
2020-07-09 16:37:00 +00:00
'use strict';
sync
2017-09-19 14:47:10 +00:00
module.exports = {
UI: Update Ember to 3.12 LTS (#6419) This is mostly deprecation fixes and blueprint changes. There are some dependency updates too; the changes to Ember Basic Dropdown necessitated changing it to angle bracket component invocation. The conversion of the rest of the templates will happen separately.
2019-10-15 18:32:58 +00:00
root: true,
UI: use lazy-loading for Xterm.js (#7964) This updates Xterm.js to 4.6.0, which includes support for reverse-wraparound mode, so we no longer need to use a vendored dependency, which closes #7461. The interface for accessing the buffer that’s used for test assertions changed. With the dependency now accessed conventionally, we can have it load only when it’s needed by an exec popup window, which closes #7516. That saves us ≈60kb compressed in the dependency bundle!
2020-05-26 14:56:25 +00:00
parser: 'babel-eslint',
sync
2017-09-19 14:47:10 +00:00
parserOptions: {
Upgrade eslint to v5
2019-04-02 22:59:16 +00:00
ecmaVersion: 2018,
sync
2017-09-19 14:47:10 +00:00
sourceType: 'module',
Add massaged results of class codemod Manual interventions: • decorators on the same line for service and controller injections and most computed property macros • preserving import order when possible, both per-line and intra-line • moving new imports to the bottom • removal of classic decorator for trivial cases • conversion of init to constructor when appropriate
2020-06-10 13:49:16 +00:00
ecmaFeatures: {
legacyDecorators: true,
},
sync
2017-09-19 14:47:10 +00:00
},
ui: match eslintrc with ember-new-output
2021-12-28 14:33:58 +00:00
globals: {
server: true,
},
env: {
browser: true,
},
plugins: ['ember'],
extends: ['eslint:recommended', 'plugin:ember/recommended', 'plugin:prettier/recommended'],
sync
2017-09-19 14:47:10 +00:00
rules: {
Add linting for classic decorator (#8182) This completes an installation step I missed when making #8144 and marks classes that are using the EmberObject APIs as classic.
2020-06-22 15:48:53 +00:00
'ember/classic-decorator-hooks': 'error',
'ember/classic-decorator-no-classic-methods': 'error',
Update Ember/Ember CLI to 3.20 (#9641) This doesn’t include Ember Data, as we are still back on 3.12. Most changes are deprecation updates, linting fixes, and dependencies. It can be read commit-by-commit, though many of them are mechanical and skimmable. For the new linting exclusions, I’ve added them to the Tech Debt list. The decrease in test count is because linting is no longer included in ember test. There’s a new deprecation warning in the logs that can be fixed by updating Ember Power Select but when I tried that it caused it to render incorrectly, so I decided to ignore it for now and address it separately.
2021-02-17 21:01:44 +00:00
'ember/no-get': 'off',
'ember/no-mixins': 'off',
ui: turn off no-class-classes rule We still use classic classes because this is a mixed codebase between Octane and Classic.
2021-12-28 14:51:29 +00:00
'ember/no-classic-classes': 'off',
ui: turn off no-computed-properties-in-native-classes We have ~60 uses of computed properties across routes (for watcher system), components, and models.
2021-12-28 15:27:37 +00:00
'ember/no-computed-properties-in-native-classes': 'off',
ui: turn off no-classic-components This is a mixed codebase and still uses classic components
2021-12-28 15:46:02 +00:00
'ember/no-classic-components': 'off',
ui: turn off no-component-lifecycle-hooks Classic components use lifecycle hooks.
2021-12-28 15:46:53 +00:00
'ember/no-component-lifecycle-hooks': 'off',
ui: turn off tagless components linting error Classic components still use tagName decorator
2021-12-28 15:47:54 +00:00
'ember/require-tagless-components': 'off',
sync
2017-09-19 14:47:10 +00:00
},
Upgrade to Ember 3.0
2019-03-12 23:42:47 +00:00
overrides: [
// node files
{
files: [
Fix a bunch of snowflake situations the codemod missed
2019-03-13 00:40:39 +00:00
'.eslintrc.js',
ui: match eslintrc with ember-new-output
2021-12-28 14:33:58 +00:00
'.prettierrc.js',
Upgrade to Ember 3.4
2019-03-15 20:26:18 +00:00
'.template-lintrc.js',
Upgrade to Ember 3.0
2019-03-12 23:42:47 +00:00
'ember-cli-build.js',
'testem.js',
Upgrade to Ember 3.4
2019-03-15 20:26:18 +00:00
'blueprints/*/index.js',
Upgrade to Ember 3.0
2019-03-12 23:42:47 +00:00
'config/**/*.js',
Fix a bunch of snowflake situations the codemod missed
2019-03-13 00:40:39 +00:00
'lib/*/index.js',
ui: match eslintrc with ember-new-output
2021-12-28 14:33:58 +00:00
'server/**/*.js',
Upgrade to Ember 3.0
2019-03-12 23:42:47 +00:00
],
parserOptions: {
sourceType: 'script',
},
env: {
browser: false,
Fix a bunch of snowflake situations the codemod missed
2019-03-13 00:40:39 +00:00
node: true,
},
UI: Update Ember to 3.12 LTS (#6419) This is mostly deprecation fixes and blueprint changes. There are some dependency updates too; the changes to Ember Basic Dropdown necessitated changing it to angle bracket component invocation. The conversion of the rest of the templates will happen separately.
2019-10-15 18:32:58 +00:00
plugins: ['node'],
Update Ember/Ember CLI to 3.20 (#9641) This doesn’t include Ember Data, as we are still back on 3.12. Most changes are deprecation updates, linting fixes, and dependencies. It can be read commit-by-commit, though many of them are mechanical and skimmable. For the new linting exclusions, I’ve added them to the Tech Debt list. The decrease in test count is because linting is no longer included in ember test. There’s a new deprecation warning in the logs that can be fixed by updating Ember Power Select but when I tried that it caused it to render incorrectly, so I decided to ignore it for now and address it separately.
2021-02-17 21:01:44 +00:00
rules: {
ui: match eslintrc with ember-new-output
2021-12-28 14:33:58 +00:00
// this can be removed once the following is fixed
// https://github.com/mysticatea/eslint-plugin-node/issues/77
'node/no-unpublished-require': 'off',
Update Ember/Ember CLI to 3.20 (#9641) This doesn’t include Ember Data, as we are still back on 3.12. Most changes are deprecation updates, linting fixes, and dependencies. It can be read commit-by-commit, though many of them are mechanical and skimmable. For the new linting exclusions, I’ve added them to the Tech Debt list. The decrease in test count is because linting is no longer included in ember test. There’s a new deprecation warning in the logs that can be fixed by updating Ember Power Select but when I tried that it caused it to render incorrectly, so I decided to ignore it for now and address it separately.
2021-02-17 21:01:44 +00:00
},
Fix a bunch of snowflake situations the codemod missed
2019-03-13 00:40:39 +00:00
},
UI: Migrate to Storybook (#6507) I originally planned to add component documentation, but as this dragged on and I found that JSDoc-to-Markdown sometimes needed hand-tuning, I decided to skip it and focus on replicating what was already present in Freestyle. Adding documentation is a finite task that can be revisited in the future. My goal was to migrate everything from Freestyle with as few changes as possible. Some adaptations that I found necessary: • the DelayedArray and DelayedTruth utilities that delay component rendering until slightly after initial render because without them: ◦ charts were rendering with zero width ◦ the JSON viewer was rendering with empty content • Storybook in Ember renders components in a routerless/controllerless context by default, so some component stories needed changes: ◦ table pagination/sorting stories access to query params, which necessitates some reaching into Ember internals to start routing and dynamically generate a Storybook route/controller to render components into ◦ some stories have a faux controller as part of their Storybook context that hosts setInterval-linked dynamic computed properties • some jiggery-pokery with anchor tags ◦ inert href='#' had to become href='javascript:; ◦ links that are actually meant to navigate need target='_parent' so they don’t navigate inside the Storybook iframe Maybe some of these could be addressed by fixes in ember-cli-storybook but I’m wary of digging around in there any more than I already have, as I’ve lost a lot of time to Storybook confusion and frustrations already 😞 The STORYBOOK=true environment variable tweaks some environment settings to get things working as expected in the Storybook context. I chose to: • use angle bracket invocation within stories rather than have to migrate them soon after having moved to Storybook • keep Freestyle around for now for its palette and typeface components
2020-01-21 21:46:32 +00:00
{
ui: match eslintrc with ember-new-output
2021-12-28 14:33:58 +00:00
files: ['stories/**/*.js'],
UI: Migrate to Storybook (#6507) I originally planned to add component documentation, but as this dragged on and I found that JSDoc-to-Markdown sometimes needed hand-tuning, I decided to skip it and focus on replicating what was already present in Freestyle. Adding documentation is a finite task that can be revisited in the future. My goal was to migrate everything from Freestyle with as few changes as possible. Some adaptations that I found necessary: • the DelayedArray and DelayedTruth utilities that delay component rendering until slightly after initial render because without them: ◦ charts were rendering with zero width ◦ the JSON viewer was rendering with empty content • Storybook in Ember renders components in a routerless/controllerless context by default, so some component stories needed changes: ◦ table pagination/sorting stories access to query params, which necessitates some reaching into Ember internals to start routing and dynamically generate a Storybook route/controller to render components into ◦ some stories have a faux controller as part of their Storybook context that hosts setInterval-linked dynamic computed properties • some jiggery-pokery with anchor tags ◦ inert href='#' had to become href='javascript:; ◦ links that are actually meant to navigate need target='_parent' so they don’t navigate inside the Storybook iframe Maybe some of these could be addressed by fixes in ember-cli-storybook but I’m wary of digging around in there any more than I already have, as I’ve lost a lot of time to Storybook confusion and frustrations already 😞 The STORYBOOK=true environment variable tweaks some environment settings to get things working as expected in the Storybook context. I chose to: • use angle bracket invocation within stories rather than have to migrate them soon after having moved to Storybook • keep Freestyle around for now for its palette and typeface components
2020-01-21 21:46:32 +00:00
parserOptions: {
sourceType: 'module',
},
env: {
browser: false,
node: true,
},
plugins: ['node'],
},
Fix a bunch of snowflake situations the codemod missed
2019-03-13 00:40:39 +00:00
],
sync
2017-09-19 14:47:10 +00:00
};