luxolus/open-nomad
2
0
Fork 0
Code Issues 1 Pull requests Packages Releases Wiki Activity
open-nomad/ui/app/templates/components/fs/link.hbs

21 lines
732 B
Handlebars
Raw Normal View History

Add explicit this to templates (#8388) This is the result of running the no-implicit-this-codemod, some manual fixes, and the addition of a linting rule to prevent future ambiguity.
2020-07-09 20:19:07 +00:00
{{#if this.taskState}}
{{#if this.path}}
<LinkTo @route="allocations.allocation.task.fs" @models={{array this.allocation this.taskState this.path}} @activeClass="is-active">
UI: add filesystem browsing for allocations (#7951) This partially addresses #7799. Task state filesystems are contained within a subdirectory of their parent allocation, so almost everything that existed for browsing task state filesystems was applicable to browsing allocations, just without the task name prepended to the path. I aimed to push this differential handling into as few contained places as possible. The tests also have significant overlap, so this includes an extracted behavior to run the same tests for allocations and task states.
2020-06-01 13:15:59 +00:00
{{yield}}
Convert to angle bracket invocation (#8075) This is mostly a direct application of the ember-angle-brackets-codemod. I manually restored newlines in multi-line component invocations, usually preserving file line length except for now-non-positional link-to @route. I needed to rename task to taskState in some cases to avoid Ember Concurrency naming conflicts.
2020-06-01 19:03:56 +00:00
</LinkTo>
UI: add filesystem browsing for allocations (#7951) This partially addresses #7799. Task state filesystems are contained within a subdirectory of their parent allocation, so almost everything that existed for browsing task state filesystems was applicable to browsing allocations, just without the task name prepended to the path. I aimed to push this differential handling into as few contained places as possible. The tests also have significant overlap, so this includes an extracted behavior to run the same tests for allocations and task states.
2020-06-01 13:15:59 +00:00
{{else}}
Add explicit this to templates (#8388) This is the result of running the no-implicit-this-codemod, some manual fixes, and the addition of a linting rule to prevent future ambiguity.
2020-07-09 20:19:07 +00:00
<LinkTo @route="allocations.allocation.task.fs-root" @models={{array this.allocation this.taskState}} @activeClass="is-active">
UI: add filesystem browsing for allocations (#7951) This partially addresses #7799. Task state filesystems are contained within a subdirectory of their parent allocation, so almost everything that existed for browsing task state filesystems was applicable to browsing allocations, just without the task name prepended to the path. I aimed to push this differential handling into as few contained places as possible. The tests also have significant overlap, so this includes an extracted behavior to run the same tests for allocations and task states.
2020-06-01 13:15:59 +00:00
{{yield}}
Convert to angle bracket invocation (#8075) This is mostly a direct application of the ember-angle-brackets-codemod. I manually restored newlines in multi-line component invocations, usually preserving file line length except for now-non-positional link-to @route. I needed to rename task to taskState in some cases to avoid Ember Concurrency naming conflicts.
2020-06-01 19:03:56 +00:00
</LinkTo>
UI: add filesystem browsing for allocations (#7951) This partially addresses #7799. Task state filesystems are contained within a subdirectory of their parent allocation, so almost everything that existed for browsing task state filesystems was applicable to browsing allocations, just without the task name prepended to the path. I aimed to push this differential handling into as few contained places as possible. The tests also have significant overlap, so this includes an extracted behavior to run the same tests for allocations and task states.
2020-06-01 13:15:59 +00:00
{{/if}}
{{else}}
Add explicit this to templates (#8388) This is the result of running the no-implicit-this-codemod, some manual fixes, and the addition of a linting rule to prevent future ambiguity.
2020-07-09 20:19:07 +00:00
{{#if this.path}}
<LinkTo @route="allocations.allocation.fs" @models={{array this.allocation this.path}} @activeClass="is-active">
UI: add filesystem browsing for allocations (#7951) This partially addresses #7799. Task state filesystems are contained within a subdirectory of their parent allocation, so almost everything that existed for browsing task state filesystems was applicable to browsing allocations, just without the task name prepended to the path. I aimed to push this differential handling into as few contained places as possible. The tests also have significant overlap, so this includes an extracted behavior to run the same tests for allocations and task states.
2020-06-01 13:15:59 +00:00
{{yield}}
Convert to angle bracket invocation (#8075) This is mostly a direct application of the ember-angle-brackets-codemod. I manually restored newlines in multi-line component invocations, usually preserving file line length except for now-non-positional link-to @route. I needed to rename task to taskState in some cases to avoid Ember Concurrency naming conflicts.
2020-06-01 19:03:56 +00:00
</LinkTo>
UI: add filesystem browsing for allocations (#7951) This partially addresses #7799. Task state filesystems are contained within a subdirectory of their parent allocation, so almost everything that existed for browsing task state filesystems was applicable to browsing allocations, just without the task name prepended to the path. I aimed to push this differential handling into as few contained places as possible. The tests also have significant overlap, so this includes an extracted behavior to run the same tests for allocations and task states.
2020-06-01 13:15:59 +00:00
{{else}}
Add explicit this to templates (#8388) This is the result of running the no-implicit-this-codemod, some manual fixes, and the addition of a linting rule to prevent future ambiguity.
2020-07-09 20:19:07 +00:00
<LinkTo @route="allocations.allocation.fs-root" @model={{this.allocation}} @activeClass="is-active">
UI: add filesystem browsing for allocations (#7951) This partially addresses #7799. Task state filesystems are contained within a subdirectory of their parent allocation, so almost everything that existed for browsing task state filesystems was applicable to browsing allocations, just without the task name prepended to the path. I aimed to push this differential handling into as few contained places as possible. The tests also have significant overlap, so this includes an extracted behavior to run the same tests for allocations and task states.
2020-06-01 13:15:59 +00:00
{{yield}}
Convert to angle bracket invocation (#8075) This is mostly a direct application of the ember-angle-brackets-codemod. I manually restored newlines in multi-line component invocations, usually preserving file line length except for now-non-positional link-to @route. I needed to rename task to taskState in some cases to avoid Ember Concurrency naming conflicts.
2020-06-01 19:03:56 +00:00
</LinkTo>
UI: add filesystem browsing for allocations (#7951) This partially addresses #7799. Task state filesystems are contained within a subdirectory of their parent allocation, so almost everything that existed for browsing task state filesystems was applicable to browsing allocations, just without the task name prepended to the path. I aimed to push this differential handling into as few contained places as possible. The tests also have significant overlap, so this includes an extracted behavior to run the same tests for allocations and task states.
2020-06-01 13:15:59 +00:00
{{/if}}
{{/if}}
Reference in a new issue Copy permalink