luxolus
/
open-nomad
2
0
Fork 0
Code Issues 1 Pull Requests Packages Releases Wiki Activity
open-nomad/jobspec/test-fixtures/tg-service-connect-sidecar_...

18 lines
231 B
HCL
Raw Normal View History

connect: enable configuring sidecar_task.name Before, the submitted jobspec for sidecar_task would pass through 2 key validation steps - once for the subset specific to connect sidecar task definitions, and once again for the set of normal task definition where the task would actually get unmarshalled. The valid keys for the normal task definition did not include "name", which is supposed to be configurable for the sidecar task. To fix this, just eliminate the double validation step, and instead pass-in the correct set of keys to validate against to the one generic task parser. Fixes #7680
2020-04-10 03:01:16 +00:00
job "sidecar_task_name" {
type = "service"
group "group" {
service {
name = "example"
ci: add a linting check for HCL files (#7791) Running `make dev` runs `hclfmt`, but this isn't checked as part of CI. That makes it possible to merge un-formatted HCL and Nomad jobspecs that later will make for dirty git staging areas when developers pull master. This changeset adds HCL linting to the `make check` target.
2020-04-23 18:32:44 +00:00
connect: enable configuring sidecar_task.name Before, the submitted jobspec for sidecar_task would pass through 2 key validation steps - once for the subset specific to connect sidecar task definitions, and once again for the set of normal task definition where the task would actually get unmarshalled. The valid keys for the normal task definition did not include "name", which is supposed to be configurable for the sidecar task. To fix this, just eliminate the double validation step, and instead pass-in the correct set of keys to validate against to the one generic task parser. Fixes #7680
2020-04-10 03:01:16 +00:00
connect {
ci: add a linting check for HCL files (#7791) Running `make dev` runs `hclfmt`, but this isn't checked as part of CI. That makes it possible to merge un-formatted HCL and Nomad jobspecs that later will make for dirty git staging areas when developers pull master. This changeset adds HCL linting to the `make check` target.
2020-04-23 18:32:44 +00:00
sidecar_service = {}
connect: enable configuring sidecar_task.name Before, the submitted jobspec for sidecar_task would pass through 2 key validation steps - once for the subset specific to connect sidecar task definitions, and once again for the set of normal task definition where the task would actually get unmarshalled. The valid keys for the normal task definition did not include "name", which is supposed to be configurable for the sidecar task. To fix this, just eliminate the double validation step, and instead pass-in the correct set of keys to validate against to the one generic task parser. Fixes #7680
2020-04-10 03:01:16 +00:00
sidecar_task {
name = "my-sidecar"
}
}
}
}
ci: add a linting check for HCL files (#7791) Running `make dev` runs `hclfmt`, but this isn't checked as part of CI. That makes it possible to merge un-formatted HCL and Nomad jobspecs that later will make for dirty git staging areas when developers pull master. This changeset adds HCL linting to the `make check` target.
2020-04-23 18:32:44 +00:00
}