ab9dd18bec
See https://github.com/hashicorp/consul/issues/3977 While trying to improve furthermore #3948 (This pull request is still valid since we are not using Compression to compute the result anyway). I saw a strange behaviour of dns library. Basically, msg.Len() and len(msg.Pack()) disagree on Message len. Thus, calculation of DNS response is false consul relies on msg.Len() instead of the result of Pack() This is linked to miekg/dns#453 and a fix has been provided with miekg/dns#454 Would it be possible to upgrade miekg/dns to a more recent function ? Consul might for instance upgrade to a post 1.0 release such as https://github.com/miekg/dns/releases/tag/v1.0.4
53 lines
992 B
Makefile
53 lines
992 B
Makefile
# Makefile for releasing.
|
|
#
|
|
# The release is controlled from version.go. The version found there is
|
|
# used to tag the git repo, we're not building any artifects so there is nothing
|
|
# to upload to github.
|
|
#
|
|
# * Up the version in version.go
|
|
# * Run: make -f Makefile.release release
|
|
# * will *commit* your change with 'Release $VERSION'
|
|
# * push to github
|
|
#
|
|
|
|
define GO
|
|
//+build ignore
|
|
|
|
package main
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"github.com/miekg/dns"
|
|
)
|
|
|
|
func main() {
|
|
fmt.Println(dns.Version.String())
|
|
}
|
|
endef
|
|
|
|
$(file > version_release.go,$(GO))
|
|
VERSION:=$(shell go run version_release.go)
|
|
TAG="v$(VERSION)"
|
|
|
|
all:
|
|
@echo Use the \'release\' target to start a release $(VERSION)
|
|
rm -f version_release.go
|
|
|
|
.PHONY: release
|
|
release: commit push
|
|
@echo Released $(VERSION)
|
|
rm -f version_release.go
|
|
|
|
.PHONY: commit
|
|
commit:
|
|
@echo Committing release $(VERSION)
|
|
git commit -am"Release $(VERSION)"
|
|
git tag $(TAG)
|
|
|
|
.PHONY: push
|
|
push:
|
|
@echo Pushing release $(VERSION) to master
|
|
git push --tags
|
|
git push
|