d140612350
- Dev mode assumed no persistence of services although proxy state is persisted which caused proxies to be killed on startup as their services were no longer registered. Fixed. - Didn't snapshot the ProxyID which meant that proxies were adopted OK from snapshot but failed to restart if they died since there was no proxyID in the ENV on restart - Dev mode with no persistence just kills all proxies on shutdown since it can't recover them later - Naming things |
||
---|---|---|
.github/ISSUE_TEMPLATE | ||
acl | ||
agent | ||
api | ||
bench | ||
command | ||
connect | ||
demo | ||
ipaddr | ||
lib | ||
logger | ||
scripts | ||
sentinel | ||
snapshot | ||
terraform | ||
test | ||
testrpc | ||
testutil | ||
tlsutil | ||
types | ||
ui | ||
ui-v2 | ||
vendor | ||
version | ||
watch | ||
website | ||
.gitattributes | ||
.gitignore | ||
.travis.yml | ||
CHANGELOG.md | ||
GNUmakefile | ||
INTERNALS.md | ||
LICENSE | ||
README.md | ||
Vagrantfile | ||
key.pem | ||
main.go | ||
main_test.go |
README.md
This is a temporary README. We'll restore the old README prior to PR upstream.
Consul Connect
This repository is the forked repository for Consul Connect work to happen in private prior to public release. This README will explain how to safely use this fork, how to bring in upstream changes, etc.
Cloning
To use this repository, clone it into your GOPATH as usual but you must
rename consul-connect
to consul
so that Go imports continue working
as usual.
Important: Never Modify Master
NEVER MODIFY MASTER! NEVER MODIFY MASTER!
We want to keep the "master" branch equivalent to OSS master. This will make
rebasing easy for master. Instead, we'll use the branch f-connect
. All
feature branches should branch from f-connect
and make PRs against
f-connect
.
When we're ready to merge back to upstream, we can make a single mega PR
merging f-connect
into OSS master. This way we don't have a sudden mega
push to master on OSS.
Creating a Feature Branch
To create a feature branch, branch from f-connect
:
git checkout f-connect
git checkout -b my-new-branch
All merged Connect features will be in f-connect
, so you want to work
from that branch. When making a PR for your feature branch, target the
f-connect
branch as the merge target. You can do this by using the dropdowns
in the GitHub UI when creating a PR.
Syncing Upstream
First update our local master:
# This has to happen on forked master
git checkout master
# Add upstream to OSS Consul
git remote add upstream https://github.com/hashicorp/consul.git
# Fetch it
git fetch upstream
# Rebase forked master onto upstream. This should have no changes since
# we're never modifying master.
git rebase upstream master
Next, update the f-connect
branch:
git checkout f-connect
git rebase origin master