d1fea9ec0a
* Move notification texts to a slightly different layer (#4572) * Further Simplify/refactor the actions/notification layer (#4573) 1. Move the 'with-feedback' actions to a 'with-blocking-action' mixin which better describes what it does 2. Additional set of unit tests almost over the entire layer to prove things work/add confidence for further changes The multiple 'with-action' mixins used for every 'index/edit' combo are now reduced down to only contain the functionality related to their specific routes, i.e. where to redirect. The actual functionality to block and carry out the action and then notify are 'almost' split out so that their respective classes/objects do one thing and one thing 'well'. Mixins are chosen for the moment as the decoration approach used by mixins feels better than multiple levels of inheritence, but I would like to take this fuether in the future to a 'compositional' based approach. There is still possible further work to be done here, but I'm a lot happier now this is reduced down into separate parts.
53 lines
1.9 KiB
JavaScript
53 lines
1.9 KiB
JavaScript
import { moduleFor, skip } from 'ember-qunit';
|
|
import test from 'ember-sinon-qunit/test-support/test';
|
|
import { getOwner } from '@ember/application';
|
|
import Route from '@ember/routing/route';
|
|
import Mixin from 'consul-ui/mixins/kv/with-actions';
|
|
|
|
moduleFor('mixin:kv/with-actions', 'Unit | Mixin | kv/with actions', {
|
|
// Specify the other units that are required for this test.
|
|
needs: [
|
|
'mixin:with-blocking-actions',
|
|
'service:feedback',
|
|
'service:flashMessages',
|
|
'service:logger',
|
|
],
|
|
subject: function() {
|
|
const MixedIn = Route.extend(Mixin);
|
|
this.register('test-container:kv/with-actions-object', MixedIn);
|
|
return getOwner(this).lookup('test-container:kv/with-actions-object');
|
|
},
|
|
});
|
|
|
|
// Replace this with your real tests.
|
|
test('it works', function(assert) {
|
|
const subject = this.subject();
|
|
assert.ok(subject);
|
|
});
|
|
test('afterUpdate calls transitionTo index when the key is a single slash', function(assert) {
|
|
const subject = this.subject();
|
|
const expected = 'dc.kv.index';
|
|
const transitionTo = this.stub(subject, 'transitionTo').returnsArg(0);
|
|
const actual = subject.afterUpdate({}, { Key: '/' });
|
|
assert.equal(actual, expected);
|
|
assert.ok(transitionTo.calledOnce);
|
|
});
|
|
test('afterUpdate calls transitionTo folder when the key is not a single slash', function(assert) {
|
|
const subject = this.subject();
|
|
const expected = 'dc.kv.folder';
|
|
const transitionTo = this.stub(subject, 'transitionTo').returnsArg(0);
|
|
['', '/key', 'key/name'].forEach(item => {
|
|
const actual = subject.afterUpdate({}, { Key: item });
|
|
assert.equal(actual, expected);
|
|
});
|
|
assert.ok(transitionTo.calledThrice);
|
|
});
|
|
test('afterDelete calls refresh folder when the routeName is `folder`', function(assert) {
|
|
const subject = this.subject();
|
|
subject.routeName = 'dc.kv.folder';
|
|
const refresh = this.stub(subject, 'refresh');
|
|
subject.afterDelete({}, {});
|
|
assert.ok(refresh.calledOnce);
|
|
});
|
|
skip('action invalidateSession test');
|