6d94900cd7
The rationale behind removing them is that all of our own code (xDS, builtin connect proxy) use the cache notification mechanism. This ensures that the blocking fetch behind the scenes is always executing. Therefore the only way you might go to get a certificate and have to wait is when 1) the request has never been made for that cert before or 2) you are using the v1/agent/connect/ca/leaf API for retrieving the cert yourself. In the first case, the refresh change doesn’t alter the behavior. In the second case, it can be mitigated by using blocking queries with that API which just like normal cache notification mechanism will cause the blocking fetch to be initiated and to get leaf certs as soon as needed. If you are not using blocking queries, or Envoy/xDS, or the builtin connect proxy but are retrieving the certs yourself then the HTTP endpoint might take a little longer to respond. This also renames the RefreshTimeout field on the register options to QueryTimeout to more accurately reflect that it is used for any type that supports blocking queries.
47 lines
1.4 KiB
Go
47 lines
1.4 KiB
Go
package cachetype
|
|
|
|
import (
|
|
"time"
|
|
|
|
"github.com/hashicorp/consul/agent/cache"
|
|
)
|
|
|
|
// RegisterOptionsBlockingRefresh can be embedded into a struct to implement
|
|
// part of the agent/cache.Type interface.
|
|
// When embedded into a struct it identifies the cache type as one which
|
|
// supports blocking, and uses refresh to keep the cache fresh.
|
|
type RegisterOptionsBlockingRefresh struct{}
|
|
|
|
func (r RegisterOptionsBlockingRefresh) RegisterOptions() cache.RegisterOptions {
|
|
return cache.RegisterOptions{
|
|
// Maintain a blocking query, retry dropped connections quickly
|
|
Refresh: true,
|
|
SupportsBlocking: true,
|
|
RefreshTimer: 0 * time.Second,
|
|
QueryTimeout: 10 * time.Minute,
|
|
}
|
|
}
|
|
|
|
type RegisterOptionsBlockingNoRefresh struct{}
|
|
|
|
func (r RegisterOptionsBlockingNoRefresh) RegisterOptions() cache.RegisterOptions {
|
|
return cache.RegisterOptions{
|
|
Refresh: false,
|
|
SupportsBlocking: true,
|
|
QueryTimeout: 10 * time.Minute,
|
|
}
|
|
}
|
|
|
|
// RegisterOptionsNoRefresh can be embedded into a struct to implement
|
|
// part of the agent/cache.Type interface.
|
|
// When embedded into a struct it identifies the cache type as one which
|
|
// does not support blocking, and should not be refreshed.
|
|
type RegisterOptionsNoRefresh struct{}
|
|
|
|
func (r RegisterOptionsNoRefresh) RegisterOptions() cache.RegisterOptions {
|
|
return cache.RegisterOptions{
|
|
Refresh: false,
|
|
SupportsBlocking: false,
|
|
}
|
|
}
|