30d3a087dc
The old setting of 24 hours was not enough time to deal with an expiring certificates. This change ups it to 28 days OR 40% of the full cert duration, whichever is shorter. It also adds details to the log message to indicate which certificate it is logging about and a suggested action.
38 lines
1.3 KiB
Go
38 lines
1.3 KiB
Go
package consul
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
const (
|
|
day = time.Hour * 24
|
|
year = day * 365
|
|
)
|
|
|
|
func TestExpiresSoon(t *testing.T) {
|
|
// ExpiresSoon() should return true if 'untilAfter' is <= 28 days
|
|
// OR if 40% of lifetime if it is less than 28 days
|
|
testCases := []struct {
|
|
name string
|
|
lifetime, untilAfter time.Duration
|
|
expiresSoon bool
|
|
}{
|
|
{name: "base-pass", lifetime: year, untilAfter: year, expiresSoon: false},
|
|
{name: "base-expire", lifetime: year, untilAfter: (day * 27), expiresSoon: true},
|
|
{name: "expires", lifetime: (day * 70), untilAfter: (day * 20), expiresSoon: true},
|
|
{name: "passes", lifetime: (day * 70), untilAfter: (day * 50), expiresSoon: false},
|
|
{name: "just-expires", lifetime: (day * 70), untilAfter: (day * 27), expiresSoon: true},
|
|
{name: "just-passes", lifetime: (day * 70), untilAfter: (day * 43), expiresSoon: false},
|
|
{name: "40%-expire", lifetime: (day * 30), untilAfter: (day * 10), expiresSoon: true},
|
|
{name: "40%-pass", lifetime: (day * 30), untilAfter: (day * 12), expiresSoon: false},
|
|
}
|
|
for _, tc := range testCases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
if expiresSoon(tc.lifetime, tc.untilAfter) != tc.expiresSoon {
|
|
t.Errorf("test case failed, should return `%t`", tc.expiresSoon)
|
|
}
|
|
})
|
|
}
|
|
}
|