048572946c
* v3.20.2...v3.24.0 * Fix handle undefined outlet in route component * Don't use template helper for optional modal.open Using the optional-helper here will trigger a computation in the same runloop error. This is because we are setting the `modal`-property when the `<Ref>` component gets rendered which will update the `this.modal`-property which will then recompute the `optional`-helper leading to this error. Instead we will create an action that will call the `open`-method on the modal when it is defined. This gets rid of the double computation error as we will not access the modal property twice in the same runloop when `modal` is getting set. * Fix - fn needs to be passed function tab-nav We create functions in the component file instead so that fn-helper stops complaining about the need to pass a function. * Update ember-exam to 6.1 version "Makes it compatible" with ember-qunit v5 * scheduleOnce setMaxHeight paged-collection We need to schedule to get around double-computation error. * Fix - model.data is removed from ember-data This has been private API all along - we need to work around the removal. Reference: https://github.com/emberjs/data/pull/7338/files#diff-9a8746fc5c86fd57e6122f00fef3155f76f0f3003a24b53fb7c4621d95dcd9bfL1310 * Fix `propContains` instead of `deepEqual` policy Recent model.data works differently than iterating attributes. We use `propContains` instead of `deepEqual`. We are only interested in the properties we assert against and match the previous behavior with this change. * Fix `propContains` instead of `deepEqual` token * Better handling single-records repo test-helper `model.data` has been removed we need to handle proxies and model instances differently. * Fix remaining repository tests with propContains We don't want to match entire objects - we don't care about properties we haven't defined in the assertion. * Don't use template helper for optional modal.open Using a template helper will give us a recomputation error - we work around it by creating an explicit action on the component instead. * Await `I $verb the $pageObject object` step * Fix no more customization ember-can No need to customize, the helper handles destruction fine on its own. * Fix - don't pass `optional` functions to fn We will declare the functions on the component instead. This gives us the same behavior but no error from `fn`, which expects a function to be passed. * Fix - handle `undefined` state on validate modifier StateChart can yield out an undefined `state` we need to handle that in the validate modifier * Fix linting errors tests directory * Warn / turn off new ember linting issues We will tackle them one by one and don't want to autofix issues that could be dangerous to auto-fix. * Auto-fix linting issues * More linting configuration * Fix remaining linting issues * Fix linting issues new files after rebase * ui: Remove ember-cli-uglify config now we are using terser (#14574) Co-authored-by: John Cowen <johncowen@users.noreply.github.com>
141 lines
5.1 KiB
JavaScript
141 lines
5.1 KiB
JavaScript
import { get as httpGet } from 'consul-ui/tests/helpers/api';
|
|
import { getProperties, set } from '@ember/object';
|
|
import measure from 'consul-ui/tests/helpers/measure';
|
|
|
|
/**
|
|
* A method that returns all attribute names for a given instance of an ember-data
|
|
* model. This is useful for when we want to get all properties of an ember-data
|
|
* model instance via `getProperties` without passing them explicitly.
|
|
*
|
|
* Example:
|
|
*
|
|
* ```js
|
|
* // get all properties of a service instance
|
|
* return getProperties(service, recordAttributes(service))
|
|
* ```
|
|
*
|
|
* @param {*} record - an ember-data model instance
|
|
* @returns {string[]} An array of attribute names for the model instance
|
|
*/
|
|
function recordAttributes(record) {
|
|
const attributes = record.constructor.attributes;
|
|
|
|
return Array.from(attributes.keys());
|
|
}
|
|
|
|
/** Stub an ember-data adapter response using the private method
|
|
*
|
|
* Allows you to easily specify a HTTP response for the Adapter. The stub only works
|
|
* during the 'lifetime' of `cb` and is reset to normal unstubbed functionality afterwards.
|
|
*
|
|
* Please Note: This overwrites a private ember-data Adapter method, please understand
|
|
* the consequences of doing this if you are using it
|
|
*
|
|
* @param {function} cb - The callback, or test case, to run using the stubbed response
|
|
* @param {object} payload - The payload to use as the response
|
|
* @param {DS.Adapter} adapter - An instance of an ember-data Adapter
|
|
*/
|
|
const stubAdapterResponse = function (cb, payload, adapter) {
|
|
const payloadClone = JSON.parse(JSON.stringify(payload));
|
|
const client = adapter.client;
|
|
set(adapter, 'client', {
|
|
request: function (cb) {
|
|
return cb(function () {
|
|
const params = client.requestParams(...arguments);
|
|
payload.headers['X-Consul-Namespace'] = params.data.ns || 'default';
|
|
payload.headers['X-Consul-Partition'] = params.data.partition || 'default';
|
|
return Promise.resolve(function (cb) {
|
|
return cb(payload.headers, payloadClone.payload);
|
|
});
|
|
});
|
|
},
|
|
});
|
|
return cb(payload.payload).then(function (result) {
|
|
set(adapter, 'client', client);
|
|
return result;
|
|
});
|
|
};
|
|
/** `repo` a helper function to faciliate easy integration testing of ember-data Service 'repo' layers
|
|
*
|
|
* Test performance is also measured using `consul-ui/tests/helpers/measure` and therefore results
|
|
* can optionally be sent to a centralized metrics collection stack
|
|
*
|
|
* @param {string} name - The name of your repo Service (only used for meta purposes)
|
|
* @param {string} payload - The method you are testing (only used for meta purposes)
|
|
* @param {Service} service - An instance of an ember-data based repo Service
|
|
* @param {function} stub - A function that receives a `stub` function allowing you to stub
|
|
* an API endpoint with a set of cookies/env vars used by the double
|
|
* @param {function} test - Your test case. This function receives an instance of the Service provided
|
|
* above as a first and only argument, it should return the result of your test
|
|
* @param {function} assert - Your assertion. This receives the result of the previous function as the first
|
|
* argument and a function to that receives the stubbed payload giving you an
|
|
* opportunity to mutate it before returning for use in your assertion
|
|
*/
|
|
export default function (name, method, service, stub, test, assert) {
|
|
const adapter = service.store.adapterFor(name.toLowerCase());
|
|
let tags = {};
|
|
const requestHeaders = function (url, cookies = {}) {
|
|
const key = Object.keys(cookies).find(function (item) {
|
|
return item.indexOf('COUNT') !== -1;
|
|
});
|
|
tags = {
|
|
count: typeof key !== 'undefined' ? parseInt(cookies[key]) : 1,
|
|
};
|
|
return httpGet(url, {
|
|
headers: {
|
|
cookie: cookies,
|
|
},
|
|
}).then(function (payload) {
|
|
return {
|
|
headers: {},
|
|
payload: payload,
|
|
};
|
|
});
|
|
};
|
|
|
|
const parseResponse = function (response) {
|
|
let actual;
|
|
// we are dealing with a record-array
|
|
if (typeof response.toArray === 'function') {
|
|
actual = response.toArray().map(function (item) {
|
|
return getProperties(item, recordAttributes(item));
|
|
});
|
|
} else {
|
|
// we are dealing with a single record
|
|
if (typeof response.get === 'function') {
|
|
const data = response.data;
|
|
|
|
if (data) {
|
|
// we were dealing with a proxy
|
|
actual = data;
|
|
} else {
|
|
// we are dealing with a model instance we need to iterate attributes
|
|
actual = getProperties(response, recordAttributes(response));
|
|
}
|
|
} else {
|
|
actual = response;
|
|
}
|
|
}
|
|
return actual;
|
|
};
|
|
return stub(requestHeaders).then(function (payload) {
|
|
return stubAdapterResponse(
|
|
function (payload) {
|
|
return measure(
|
|
function () {
|
|
return test(service);
|
|
},
|
|
`${name}Service.${method}`,
|
|
tags
|
|
).then(function (response) {
|
|
assert(parseResponse(response), function (cb) {
|
|
return cb(payload);
|
|
});
|
|
});
|
|
},
|
|
payload,
|
|
adapter
|
|
);
|
|
});
|
|
}
|