Go to file
R.B. Boyer 9f41cc4a25
cache: prevent goroutine leak in agent cache (#14908)
There is a bug in the error handling code for the Agent cache subsystem discovered:

1. NotifyCallback calls notifyBlockingQuery which calls getWithIndex in
   a loop (which backs off on-error up to 1 minute)

2. getWithIndex calls fetch if there’s no valid entry in the cache

3. fetch starts a goroutine which calls Fetch on the cache-type, waits
   for a while (again with backoff up to 1 minute for errors) and then
   calls fetch to trigger a refresh

The end result being that every 1 minute notifyBlockingQuery spawns an
ancestry of goroutines that essentially lives forever.

This PR ensures that the goroutine started by `fetch` cancels any prior
goroutine spawned by the same line for the same key.

In isolated testing where a cache type was tweaked to indefinitely
error, this patch prevented goroutine counts from skyrocketing.
2022-10-17 14:38:10 -05:00
.changelog cache: prevent goroutine leak in agent cache (#14908) 2022-10-17 14:38:10 -05:00
.circleci perf: remove expensive reflection from xDS hot path (#14934) 2022-10-14 10:26:42 +01:00
.github Ensure lines were modified 2022-10-07 09:24:37 -06:00
.release Enable ironbank integration (#14931) 2022-10-11 10:27:06 -04:00
acl Use split wildcard partition name 2022-10-13 16:55:28 -06:00
agent cache: prevent goroutine leak in agent cache (#14908) 2022-10-17 14:38:10 -05:00
api Merge pull request #13388 from deblasis/feature/health-checks_windows_service 2022-10-17 09:26:19 -04:00
bench Gets benchmarks running again and does a rough pass for 0.7.1. 2016-11-29 13:02:26 -08:00
build-support perf: remove expensive reflection from xDS hot path (#14934) 2022-10-14 10:26:42 +01:00
command cli: Add -node-name flag to redirect-traffic command (#14933) 2022-10-12 11:53:41 -06:00
connect Add retries and debugging to flaky test 2022-08-08 15:26:44 -04:00
contributing Move contributing to docs 2021-08-30 16:17:09 -04:00
docs fix: missing UDP field in checkType (#14885) 2022-10-05 15:57:21 -04:00
grafana add readme outlining how to edit and publish 2021-01-12 14:47:11 -08:00
internal Extract AWS auth implementation out of Consul (#13760) 2022-07-19 16:26:44 -05:00
ipaddr Ensure Consul is IPv6 compliant (#5468) 2019-06-04 10:02:38 -04:00
lib Share mgw addrs in peering stream if needed 2022-10-03 11:42:20 -06:00
logging xDS Load Balancing (#14397) 2022-09-09 15:02:01 +01:00
proto proto: deep-copy PeeringTrustBundle using proto.Clone (#15004) 2022-10-17 16:30:35 +01:00
proto-public Regenerate protos with mocks 2022-09-29 21:18:40 -07:00
sdk Use internal server certificate for peering TLS 2022-10-07 09:05:32 -06:00
sentinel re-run gofmt on 1.17 (#11579) 2021-11-16 12:04:01 -06:00
service_os re-run gofmt on 1.17 (#11579) 2021-11-16 12:04:01 -06:00
snapshot Vendor in rpc mono repo for net/rpc fork, go-msgpack, msgpackrpc. (#12311) 2022-02-14 09:45:45 -08:00
test Add integ test for peering through gateways 2022-10-13 14:58:05 -06:00
testrpc feat(cli): add initial peering cli commands 2022-09-01 17:20:13 -04:00
tlsutil Add awareness of server mode to TLS configurator 2022-09-16 17:57:10 -06:00
tools/internal-grpc-proxy grpc: rename public/private directories to external/internal (#13721) 2022-07-13 16:33:48 +01:00
types agent: convert listener config to TLS types (#12522) 2022-03-24 15:32:25 -04:00
ui Merge pull request #14986 from hashicorp/ui/feature/filter-node-healthchecks-agentless 2022-10-14 09:33:45 -06:00
version Sync changes from 1.13.0 release (#14104) 2022-08-10 12:21:21 -07:00
website docs: formatting on backend application and delete peering CRDs (#15007) 2022-10-17 10:34:05 -07:00
.dockerignore Update the scripting 2018-06-14 21:42:47 -04:00
.gitattributes Initial commit 2013-11-04 14:15:27 -08:00
.gitignore chore: ignore vscode files 2022-07-25 12:31:58 -04:00
.golangci.yml lint net/rpc usage (#12816) 2022-09-02 09:56:40 -07:00
CHANGELOG.md docs: vault ca provider patch upgrade guidance 2022-10-06 16:04:43 -07:00
Dockerfile Add version label to Docker image (#14204) 2022-08-18 14:41:34 -04:00
GNUmakefile proto: deep-copy PeeringTrustBundle using proto.Clone (#15004) 2022-10-17 16:30:35 +01:00
LICENSE Initial commit 2013-11-04 14:15:27 -08:00
NOTICE.md add copyright notice file 2018-07-09 10:58:26 -07:00
README.md Fixed broken links referring to tutorials running as local agent (#14954) 2022-10-11 13:01:29 -07:00
Vagrantfile Adds a basic Linux Vagrant setup, stolen from Nomad. 2017-10-06 08:10:12 -07:00
fixup_acl_move.sh Fixup script 2 2022-04-05 14:52:43 -07:00
go.mod bump raft version to v1.3.11 (#14897) 2022-10-12 08:51:52 -04:00
go.sum bump raft version to v1.3.11 (#14897) 2022-10-12 08:51:52 -04:00
main.go Refactor some functions for better enterprise use (#13280) 2022-05-30 09:46:55 -04:00

README.md

Consul logo Consul

Docker Pulls Go Report Card

Consul is a distributed, highly available, and data center aware solution to connect and configure applications across dynamic, distributed infrastructure.

Consul provides several key features:

  • Multi-Datacenter - Consul is built to be datacenter aware, and can support any number of regions without complex configuration.

  • Service Mesh - Consul Service Mesh enables secure service-to-service communication with automatic TLS encryption and identity-based authorization. Applications can use sidecar proxies in a service mesh configuration to establish TLS connections for inbound and outbound connections with Transparent Proxy.

  • Service Discovery - Consul makes it simple for services to register themselves and to discover other services via a DNS or HTTP interface. External services such as SaaS providers can be registered as well.

  • Health Checking - Health Checking enables Consul to quickly alert operators about any issues in a cluster. The integration with service discovery prevents routing traffic to unhealthy hosts and enables service level circuit breakers.

  • Key/Value Storage - A flexible key/value store enables storing dynamic configuration, feature flagging, coordination, leader election and more. The simple HTTP API makes it easy to use anywhere.

Consul runs on Linux, macOS, FreeBSD, Solaris, and Windows and includes an optional browser based UI. A commercial version called Consul Enterprise is also available.

Please note: We take Consul's security and our users' trust very seriously. If you believe you have found a security issue in Consul, please responsibly disclose by contacting us at security@hashicorp.com.

Quick Start

A few quick start guides are available on the Consul website:

Documentation

Full, comprehensive documentation is available on the Consul website: https://consul.io/docs

Contributing

Thank you for your interest in contributing! Please refer to CONTRIBUTING.md for guidance. For contributions specifically to the browser based UI, please refer to the UI's README.md for guidance.