048572946c
* v3.20.2...v3.24.0 * Fix handle undefined outlet in route component * Don't use template helper for optional modal.open Using the optional-helper here will trigger a computation in the same runloop error. This is because we are setting the `modal`-property when the `<Ref>` component gets rendered which will update the `this.modal`-property which will then recompute the `optional`-helper leading to this error. Instead we will create an action that will call the `open`-method on the modal when it is defined. This gets rid of the double computation error as we will not access the modal property twice in the same runloop when `modal` is getting set. * Fix - fn needs to be passed function tab-nav We create functions in the component file instead so that fn-helper stops complaining about the need to pass a function. * Update ember-exam to 6.1 version "Makes it compatible" with ember-qunit v5 * scheduleOnce setMaxHeight paged-collection We need to schedule to get around double-computation error. * Fix - model.data is removed from ember-data This has been private API all along - we need to work around the removal. Reference: https://github.com/emberjs/data/pull/7338/files#diff-9a8746fc5c86fd57e6122f00fef3155f76f0f3003a24b53fb7c4621d95dcd9bfL1310 * Fix `propContains` instead of `deepEqual` policy Recent model.data works differently than iterating attributes. We use `propContains` instead of `deepEqual`. We are only interested in the properties we assert against and match the previous behavior with this change. * Fix `propContains` instead of `deepEqual` token * Better handling single-records repo test-helper `model.data` has been removed we need to handle proxies and model instances differently. * Fix remaining repository tests with propContains We don't want to match entire objects - we don't care about properties we haven't defined in the assertion. * Don't use template helper for optional modal.open Using a template helper will give us a recomputation error - we work around it by creating an explicit action on the component instead. * Await `I $verb the $pageObject object` step * Fix no more customization ember-can No need to customize, the helper handles destruction fine on its own. * Fix - don't pass `optional` functions to fn We will declare the functions on the component instead. This gives us the same behavior but no error from `fn`, which expects a function to be passed. * Fix - handle `undefined` state on validate modifier StateChart can yield out an undefined `state` we need to handle that in the validate modifier * Fix linting errors tests directory * Warn / turn off new ember linting issues We will tackle them one by one and don't want to autofix issues that could be dangerous to auto-fix. * Auto-fix linting issues * More linting configuration * Fix remaining linting issues * Fix linting issues new files after rebase * ui: Remove ember-cli-uglify config now we are using terser (#14574) Co-authored-by: John Cowen <johncowen@users.noreply.github.com>
54 lines
1.7 KiB
JavaScript
54 lines
1.7 KiB
JavaScript
/**
|
|
* super stubber
|
|
* Ember's `_super` functionality is a little challenging to stub.
|
|
* The following will essentially let you stub `_super`, letting
|
|
* you test single units of code that use `_super`
|
|
* The return value is a function with the same signature as
|
|
* traditional `test` or `it` test functions. Any test code
|
|
* used within the cb 'sandbox' will use the stubbed `_super`.
|
|
* It's done this way to attempt to make it easy to reuse for various tests
|
|
* using the same stub in a recognisable way.
|
|
*
|
|
* @param {object} obj - The instance with the that `_super` belongs to
|
|
* @param {object} [stub=function(){return arguments}] -
|
|
* The stub to use in place of `_super`, if not specified `_super` will
|
|
* simply return the `arguments` passed to it
|
|
*
|
|
* @returns {function}
|
|
*/
|
|
export default function (obj, stub) {
|
|
const _super =
|
|
typeof stub === 'undefined'
|
|
? function () {
|
|
return arguments;
|
|
}
|
|
: stub;
|
|
/**
|
|
* @param {string} message - Message to accompany the test concept (currently unused)
|
|
* @param {function} cb - Callback that performs the test, will use the stubbed `_super`
|
|
* @returns The result of `cb`, and therefore maintain the same API
|
|
*/
|
|
return function (message, _cb) {
|
|
const cb = typeof message === 'function' ? message : _cb;
|
|
|
|
let orig = obj._super;
|
|
Object.defineProperty(Object.getPrototypeOf(obj), '_super', {
|
|
set: function () {},
|
|
get: function () {
|
|
return _super;
|
|
},
|
|
});
|
|
// TODO: try/catch this?
|
|
const actual = cb();
|
|
Object.defineProperty(Object.getPrototypeOf(obj), '_super', {
|
|
set: function (val) {
|
|
orig = val;
|
|
},
|
|
get: function () {
|
|
return orig;
|
|
},
|
|
});
|
|
return actual;
|
|
};
|
|
}
|