cd837b0b18
command/agent/* -> agent/*
command/consul/* -> agent/consul/*
command/agent/command{,_test}.go -> command/agent{,_test}.go
command/base/command.go -> command/base.go
command/base/* -> command/*
commands.go -> command/commands.go
The script which did the refactor is:
(
cd $GOPATH/src/github.com/hashicorp/consul
git mv command/agent/command.go command/agent.go
git mv command/agent/command_test.go command/agent_test.go
git mv command/agent/flag_slice_value{,_test}.go command/
git mv command/agent .
git mv command/base/command.go command/base.go
git mv command/base/config_util{,_test}.go command/
git mv commands.go command/
git mv consul agent
rmdir command/base/
gsed -i -e 's|package agent|package command|' command/agent{,_test}.go
gsed -i -e 's|package agent|package command|' command/flag_slice_value{,_test}.go
gsed -i -e 's|package base|package command|' command/base.go command/config_util{,_test}.go
gsed -i -e 's|package main|package command|' command/commands.go
gsed -i -e 's|base.Command|BaseCommand|' command/commands.go
gsed -i -e 's|agent.Command|AgentCommand|' command/commands.go
gsed -i -e 's|\tCommand:|\tBaseCommand:|' command/commands.go
gsed -i -e 's|base\.||' command/commands.go
gsed -i -e 's|command\.||' command/commands.go
gsed -i -e 's|command|c|' main.go
gsed -i -e 's|range Commands|range command.Commands|' main.go
gsed -i -e 's|Commands: Commands|Commands: command.Commands|' main.go
gsed -i -e 's|base\.BoolValue|BoolValue|' command/operator_autopilot_set.go
gsed -i -e 's|base\.DurationValue|DurationValue|' command/operator_autopilot_set.go
gsed -i -e 's|base\.StringValue|StringValue|' command/operator_autopilot_set.go
gsed -i -e 's|base\.UintValue|UintValue|' command/operator_autopilot_set.go
gsed -i -e 's|\bCommand\b|BaseCommand|' command/base.go
gsed -i -e 's|BaseCommand Options|Command Options|' command/base.go
gsed -i -e 's|base.Command|BaseCommand|' command/*.go
gsed -i -e 's|c\.Command|c.BaseCommand|g' command/*.go
gsed -i -e 's|\tCommand:|\tBaseCommand:|' command/*_test.go
gsed -i -e 's|base\.||' command/*_test.go
gsed -i -e 's|\bCommand\b|AgentCommand|' command/agent{,_test}.go
gsed -i -e 's|cmd.AgentCommand|cmd.BaseCommand|' command/agent.go
gsed -i -e 's|cli.AgentCommand = new(Command)|cli.Command = new(AgentCommand)|' command/agent_test.go
gsed -i -e 's|exec.AgentCommand|exec.Command|' command/agent_test.go
gsed -i -e 's|exec.BaseCommand|exec.Command|' command/agent_test.go
gsed -i -e 's|NewTestAgent|agent.NewTestAgent|' command/agent_test.go
gsed -i -e 's|= TestConfig|= agent.TestConfig|' command/agent_test.go
gsed -i -e 's|: RetryJoin|: agent.RetryJoin|' command/agent_test.go
gsed -i -e 's|\.\./\.\./|../|' command/config_util_test.go
gsed -i -e 's|\bverifyUniqueListeners|VerifyUniqueListeners|' agent/config{,_test}.go command/agent.go
gsed -i -e 's|\bserfLANKeyring\b|SerfLANKeyring|g' agent/{agent,keyring,testagent}.go command/agent.go
gsed -i -e 's|\bserfWANKeyring\b|SerfWANKeyring|g' agent/{agent,keyring,testagent}.go command/agent.go
gsed -i -e 's|\bNewAgent\b|agent.New|g' command/agent{,_test}.go
gsed -i -e 's|\bNewAgent|New|' agent/{acl_test,agent,testagent}.go
gsed -i -e 's|\bAgent\b|agent.&|g' command/agent{,_test}.go
gsed -i -e 's|\bBool\b|agent.&|g' command/agent{,_test}.go
gsed -i -e 's|\bConfig\b|agent.&|g' command/agent{,_test}.go
gsed -i -e 's|\bDefaultConfig\b|agent.&|g' command/agent{,_test}.go
gsed -i -e 's|\bDevConfig\b|agent.&|g' command/agent{,_test}.go
gsed -i -e 's|\bMergeConfig\b|agent.&|g' command/agent{,_test}.go
gsed -i -e 's|\bReadConfigPaths\b|agent.&|g' command/agent{,_test}.go
gsed -i -e 's|\bParseMetaPair\b|agent.&|g' command/agent{,_test}.go
gsed -i -e 's|\bSerfLANKeyring\b|agent.&|g' command/agent{,_test}.go
gsed -i -e 's|\bSerfWANKeyring\b|agent.&|g' command/agent{,_test}.go
gsed -i -e 's|circonus\.agent|circonus|g' command/agent{,_test}.go
gsed -i -e 's|logger\.agent|logger|g' command/agent{,_test}.go
gsed -i -e 's|metrics\.agent|metrics|g' command/agent{,_test}.go
gsed -i -e 's|// agent.Agent|// agent|' command/agent{,_test}.go
gsed -i -e 's|a\.agent\.Config|a.Config|' command/agent{,_test}.go
gsed -i -e 's|agent\.AppendSliceValue|AppendSliceValue|' command/{configtest,validate}.go
gsed -i -e 's|consul/consul|agent/consul|' GNUmakefile
gsed -i -e 's|\.\./test|../../test|' agent/consul/server_test.go
# fix imports
f=$(grep -rl 'github.com/hashicorp/consul/command/agent' * | grep '\.go')
gsed -i -e 's|github.com/hashicorp/consul/command/agent|github.com/hashicorp/consul/agent|' $f
goimports -w $f
f=$(grep -rl 'github.com/hashicorp/consul/consul' * | grep '\.go')
gsed -i -e 's|github.com/hashicorp/consul/consul|github.com/hashicorp/consul/agent/consul|' $f
goimports -w $f
goimports -w command/*.go main.go
)
95 lines
2.2 KiB
Go
95 lines
2.2 KiB
Go
package structs
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/hashicorp/serf/serf"
|
|
)
|
|
|
|
func TestServerHealth_IsHealthy(t *testing.T) {
|
|
cases := []struct {
|
|
health ServerHealth
|
|
lastTerm uint64
|
|
lastIndex uint64
|
|
conf AutopilotConfig
|
|
expected bool
|
|
}{
|
|
// Healthy server, all values within allowed limits
|
|
{
|
|
health: ServerHealth{SerfStatus: serf.StatusAlive, LastTerm: 1, LastIndex: 0},
|
|
lastTerm: 1,
|
|
lastIndex: 10,
|
|
conf: AutopilotConfig{MaxTrailingLogs: 20},
|
|
expected: true,
|
|
},
|
|
// Serf status failed
|
|
{
|
|
health: ServerHealth{SerfStatus: serf.StatusFailed},
|
|
expected: false,
|
|
},
|
|
// Old value for lastTerm
|
|
{
|
|
health: ServerHealth{SerfStatus: serf.StatusAlive, LastTerm: 0},
|
|
lastTerm: 1,
|
|
expected: false,
|
|
},
|
|
// Too far behind on logs
|
|
{
|
|
health: ServerHealth{SerfStatus: serf.StatusAlive, LastIndex: 0},
|
|
lastIndex: 10,
|
|
conf: AutopilotConfig{MaxTrailingLogs: 5},
|
|
expected: false,
|
|
},
|
|
}
|
|
|
|
for index, tc := range cases {
|
|
actual := tc.health.IsHealthy(tc.lastTerm, tc.lastIndex, &tc.conf)
|
|
if actual != tc.expected {
|
|
t.Fatalf("bad value for case %d: %v", index, actual)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestServerHealth_IsStable(t *testing.T) {
|
|
start := time.Now()
|
|
cases := []struct {
|
|
health *ServerHealth
|
|
now time.Time
|
|
conf AutopilotConfig
|
|
expected bool
|
|
}{
|
|
// Healthy server, all values within allowed limits
|
|
{
|
|
health: &ServerHealth{Healthy: true, StableSince: start},
|
|
now: start.Add(15 * time.Second),
|
|
conf: AutopilotConfig{ServerStabilizationTime: 10 * time.Second},
|
|
expected: true,
|
|
},
|
|
// Unhealthy server
|
|
{
|
|
health: &ServerHealth{Healthy: false},
|
|
expected: false,
|
|
},
|
|
// Healthy server, hasn't reached stabilization time
|
|
{
|
|
health: &ServerHealth{Healthy: true, StableSince: start},
|
|
now: start.Add(5 * time.Second),
|
|
conf: AutopilotConfig{ServerStabilizationTime: 10 * time.Second},
|
|
expected: false,
|
|
},
|
|
// Nil struct
|
|
{
|
|
health: nil,
|
|
expected: false,
|
|
},
|
|
}
|
|
|
|
for index, tc := range cases {
|
|
actual := tc.health.IsStable(tc.now, &tc.conf)
|
|
if actual != tc.expected {
|
|
t.Fatalf("bad value for case %d: %v", index, actual)
|
|
}
|
|
}
|
|
}
|