open-consul/ui-v2/app
John Cowen 751f8552b2
UI: Removes success notification on faking a success response for self (#4906)
In order to continue supporting the legacy ACL system, we replace
the 500 error from a non-existent `self` endpoint with a response of a
`null` `AccessorID` - which makes sense (a null AccessorID means old
API)

We then redirect the user to the old ACL pages which then gives a 403
if their token was wrong which then redirects them back to the login page.

Due to the multiple redirects and not wanting to test the validity of the token
before redirecting (thus calling the same API endpoint twice), it is not
straightforwards to turn the 'faked' response from the `self` endpoint
into an error (flash messages are 'lost' through multiple redirects).

In order to make this a slightly better experience, you can now return a
`false` during execution of an action requiring success/failure
feedback, this essentially skips the notification, so if the action is
'successful' but you don't want to show the notification, you can. This
resolves showing a successful notification when the `self` endpoint
response is faked. The last part of the puzzle is to make sure that the
global 403 catching error in the application Route also produces an
erroneous notification.

Please note this can only happen with a ui client using the new ACL
system when communicating with a cluster using the old ACL system, and
only when you enter the wrong token.

Lastly, further acceptance tests have been added around this

This commit also adds functionality to avoid any possible double 
notification messages, to avoid UI overlapping
2018-11-07 15:57:41 +00:00
..
adapters UI: New ACLs (#4789) 2018-10-19 08:45:05 -07:00
components UI: Catch 500 error on token endpoint and revert to legacy tokens (#4874) 2018-11-02 14:44:36 +00:00
controllers UI: New ACLs (#4789) 2018-10-19 08:45:05 -07:00
forms UI: New ACLs (#4789) 2018-10-19 08:45:05 -07:00
helpers ui: Make empty Rules ('') take priority over a Legacy: true (#4899) 2018-11-06 18:08:10 +00:00
initializers ui: Adds multi syntax linting to the code editor (#4814) 2018-10-19 17:36:38 +01:00
mixins UI: Catch 500 error on token endpoint and revert to legacy tokens (#4874) 2018-11-02 14:44:36 +00:00
models UI: New ACLs (#4789) 2018-10-19 08:45:05 -07:00
routes UI: Removes success notification on faking a success response for self (#4906) 2018-11-07 15:57:41 +00:00
routing UI: New ACLs (#4789) 2018-10-19 08:45:05 -07:00
serializers UI: New ACLs (#4789) 2018-10-19 08:45:05 -07:00
services UI: Removes success notification on faking a success response for self (#4906) 2018-11-07 15:57:41 +00:00
styles ui: Adds multi syntax linting to the code editor (#4814) 2018-10-19 17:36:38 +01:00
templates UI: Catch 500 error on token endpoint and revert to legacy tokens (#4874) 2018-11-02 14:44:36 +00:00
utils UI: Removes success notification on faking a success response for self (#4906) 2018-11-07 15:57:41 +00:00
validations UI: New ACLs (#4789) 2018-10-19 08:45:05 -07:00
app.js UI V2 (#4086) 2018-05-10 19:52:53 +01:00
index.html ui: Adds multi syntax linting to the code editor (#4814) 2018-10-19 17:36:38 +01:00
resolver.js UI V2 (#4086) 2018-05-10 19:52:53 +01:00
router.js UI: New ACLs (#4789) 2018-10-19 08:45:05 -07:00