8b6877febd
Using:
git grep -l 'NewTestAgent(t, t.Name(),' | \
xargs sed -i -e 's/NewTestAgent(t, t.Name(),/NewTestAgent(t,/g'
272 lines
7 KiB
Go
272 lines
7 KiB
Go
package agent
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"os/exec"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/hashicorp/consul/testrpc"
|
|
|
|
"github.com/hashicorp/consul/agent"
|
|
"github.com/hashicorp/consul/agent/config"
|
|
"github.com/hashicorp/consul/sdk/testutil"
|
|
"github.com/hashicorp/consul/sdk/testutil/retry"
|
|
"github.com/mitchellh/cli"
|
|
)
|
|
|
|
// TestConfigFail should test command line flags that lead to an immediate error.
|
|
func TestConfigFail(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
dataDir := testutil.TempDir(t, "consul")
|
|
defer os.RemoveAll(dataDir)
|
|
|
|
tests := []struct {
|
|
args []string
|
|
out string
|
|
}{
|
|
{
|
|
args: []string{"agent", "-server", "-bind=10.0.0.1", "-datacenter="},
|
|
out: "==> datacenter cannot be empty\n",
|
|
},
|
|
{
|
|
args: []string{"agent", "-server", "-bind=10.0.0.1", "-datacenter=foo", "some-other-arg"},
|
|
out: "==> config: Unknown extra arguments: [some-other-arg]\n",
|
|
},
|
|
{
|
|
args: []string{"agent", "-server", "-bind=10.0.0.1"},
|
|
out: "==> data_dir cannot be empty\n",
|
|
},
|
|
{
|
|
args: []string{"agent", "-server", "-data-dir", dataDir, "-advertise", "0.0.0.0", "-bind", "10.0.0.1"},
|
|
out: "==> Advertise address cannot be 0.0.0.0, :: or [::]\n",
|
|
},
|
|
{
|
|
args: []string{"agent", "-server", "-data-dir", dataDir, "-advertise", "::", "-bind", "10.0.0.1"},
|
|
out: "==> Advertise address cannot be 0.0.0.0, :: or [::]\n",
|
|
},
|
|
{
|
|
args: []string{"agent", "-server", "-data-dir", dataDir, "-advertise", "[::]", "-bind", "10.0.0.1"},
|
|
out: "==> Advertise address cannot be 0.0.0.0, :: or [::]\n",
|
|
},
|
|
{
|
|
args: []string{"agent", "-server", "-data-dir", dataDir, "-advertise-wan", "0.0.0.0", "-bind", "10.0.0.1"},
|
|
out: "==> Advertise WAN address cannot be 0.0.0.0, :: or [::]\n",
|
|
},
|
|
{
|
|
args: []string{"agent", "-server", "-data-dir", dataDir, "-advertise-wan", "::", "-bind", "10.0.0.1"},
|
|
out: "==> Advertise WAN address cannot be 0.0.0.0, :: or [::]\n",
|
|
},
|
|
{
|
|
args: []string{"agent", "-server", "-data-dir", dataDir, "-advertise-wan", "[::]", "-bind", "10.0.0.1"},
|
|
out: "==> Advertise WAN address cannot be 0.0.0.0, :: or [::]\n",
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(strings.Join(tt.args, " "), func(t *testing.T) {
|
|
cmd := exec.Command("consul", tt.args...)
|
|
b, err := cmd.CombinedOutput()
|
|
if got, want := err, "exit status 1"; got == nil || got.Error() != want {
|
|
t.Fatalf("got err %q want %q", got, want)
|
|
}
|
|
if got, want := string(b), tt.out; got != want {
|
|
t.Fatalf("got %q want %q", got, want)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestRetryJoin(t *testing.T) {
|
|
a := agent.NewTestAgent(t, "")
|
|
defer a.Shutdown()
|
|
|
|
b := agent.NewTestAgent(t, `
|
|
retry_join = ["`+a.Config.SerfBindAddrLAN.String()+`"]
|
|
retry_join_wan = ["`+a.Config.SerfBindAddrWAN.String()+`"]
|
|
retry_interval = "100ms"
|
|
`)
|
|
defer b.Shutdown()
|
|
|
|
testrpc.WaitForLeader(t, a.RPC, "dc1")
|
|
|
|
retry.Run(t, func(r *retry.R) {
|
|
if got, want := len(a.LANMembers()), 2; got != want {
|
|
r.Fatalf("got %d LAN members want %d", got, want)
|
|
}
|
|
})
|
|
|
|
retry.Run(t, func(r *retry.R) {
|
|
if got, want := len(a.WANMembers()), 2; got != want {
|
|
r.Fatalf("got %d WAN members want %d", got, want)
|
|
}
|
|
})
|
|
}
|
|
|
|
func TestRetryJoinFail(t *testing.T) {
|
|
t.Parallel()
|
|
tmpDir := testutil.TempDir(t, "consul")
|
|
defer os.RemoveAll(tmpDir)
|
|
|
|
ui := cli.NewMockUi()
|
|
cmd := New(ui, "", "", "", "", nil)
|
|
|
|
args := []string{
|
|
"-bind", "127.0.0.1",
|
|
"-data-dir", tmpDir,
|
|
"-retry-join", "127.0.0.1:99",
|
|
"-retry-max", "1",
|
|
"-retry-interval", "10ms",
|
|
}
|
|
|
|
if code := cmd.Run(args); code == 0 {
|
|
t.Fatalf("bad: %d", code)
|
|
}
|
|
}
|
|
|
|
func TestRetryJoinWanFail(t *testing.T) {
|
|
t.Parallel()
|
|
tmpDir := testutil.TempDir(t, "consul")
|
|
defer os.RemoveAll(tmpDir)
|
|
|
|
ui := cli.NewMockUi()
|
|
cmd := New(ui, "", "", "", "", nil)
|
|
|
|
args := []string{
|
|
"-server",
|
|
"-bind", "127.0.0.1",
|
|
"-data-dir", tmpDir,
|
|
"-retry-join-wan", "127.0.0.1:99",
|
|
"-retry-max-wan", "1",
|
|
"-retry-interval-wan", "10ms",
|
|
}
|
|
|
|
if code := cmd.Run(args); code == 0 {
|
|
t.Fatalf("bad: %d", code)
|
|
}
|
|
}
|
|
|
|
func TestProtectDataDir(t *testing.T) {
|
|
t.Parallel()
|
|
dir := testutil.TempDir(t, "consul")
|
|
defer os.RemoveAll(dir)
|
|
|
|
if err := os.MkdirAll(filepath.Join(dir, "mdb"), 0700); err != nil {
|
|
t.Fatalf("err: %v", err)
|
|
}
|
|
|
|
cfgDir := testutil.TempDir(t, "consul-config")
|
|
defer os.RemoveAll(cfgDir)
|
|
|
|
cfgFilePath := filepath.Join(cfgDir, "consul.json")
|
|
cfgFile, err := os.Create(cfgFilePath)
|
|
if err != nil {
|
|
t.Fatalf("Unable to create file %v, got error:%v", cfgFilePath, err)
|
|
}
|
|
|
|
content := fmt.Sprintf(`{"server": true, "bind_addr" : "10.0.0.1", "data_dir": "%s"}`, dir)
|
|
_, err = cfgFile.Write([]byte(content))
|
|
if err != nil {
|
|
t.Fatalf("err: %v", err)
|
|
}
|
|
|
|
ui := cli.NewMockUi()
|
|
cmd := New(ui, "", "", "", "", nil)
|
|
args := []string{"-config-file=" + cfgFile.Name()}
|
|
if code := cmd.Run(args); code == 0 {
|
|
t.Fatalf("should fail")
|
|
}
|
|
if out := ui.ErrorWriter.String(); !strings.Contains(out, dir) {
|
|
t.Fatalf("expected mdb dir error, got: %s", out)
|
|
}
|
|
}
|
|
|
|
func TestBadDataDirPermissions(t *testing.T) {
|
|
t.Parallel()
|
|
dir := testutil.TempDir(t, "consul")
|
|
defer os.RemoveAll(dir)
|
|
|
|
dataDir := filepath.Join(dir, "mdb")
|
|
if err := os.MkdirAll(dataDir, 0400); err != nil {
|
|
t.Fatalf("err: %v", err)
|
|
}
|
|
defer os.RemoveAll(dataDir)
|
|
|
|
ui := cli.NewMockUi()
|
|
cmd := New(ui, "", "", "", "", nil)
|
|
args := []string{"-data-dir=" + dataDir, "-server=true", "-bind=10.0.0.1"}
|
|
if code := cmd.Run(args); code == 0 {
|
|
t.Fatalf("Should fail with bad data directory permissions")
|
|
}
|
|
if out := ui.ErrorWriter.String(); !strings.Contains(out, "Permission denied") {
|
|
t.Fatalf("expected permission denied error, got: %s", out)
|
|
}
|
|
}
|
|
|
|
func TestReloadLoggerFail(t *testing.T) {
|
|
a := agent.NewTestAgent(t, "")
|
|
defer a.Shutdown()
|
|
|
|
ui := cli.NewMockUi()
|
|
cmd := New(ui, "", "", "", "", nil)
|
|
|
|
bindAddr := a.Config.BindAddr.String()
|
|
cmd.flagArgs.Config.BindAddr = &bindAddr
|
|
cmd.flagArgs.Config.DataDir = &a.Config.DataDir
|
|
|
|
cmd.logger = testutil.Logger(t)
|
|
|
|
newLogLevel := "BLAH"
|
|
cmd.flagArgs.Config.LogLevel = &newLogLevel
|
|
|
|
oldCfg := config.RuntimeConfig{
|
|
LogLevel: "INFO",
|
|
}
|
|
cfg, err := cmd.handleReload(a.Agent, &oldCfg)
|
|
if err == nil {
|
|
t.Fatal("Should fail with bad log level")
|
|
}
|
|
|
|
if !strings.Contains(err.Error(), "Invalid log level") {
|
|
t.Fatalf("expected invalid log level error, got: %s", err)
|
|
}
|
|
if cfg.LogLevel != "INFO" {
|
|
t.Fatalf("expected log level to stay the same, got: %s", cfg.LogLevel)
|
|
}
|
|
}
|
|
|
|
func TestReloadLoggerSuccess(t *testing.T) {
|
|
a := agent.NewTestAgent(t, "")
|
|
defer a.Shutdown()
|
|
|
|
ui := cli.NewMockUi()
|
|
cmd := New(ui, "", "", "", "", nil)
|
|
|
|
bindAddr := a.Config.BindAddr.String()
|
|
cmd.flagArgs.Config.BindAddr = &bindAddr
|
|
cmd.flagArgs.Config.DataDir = &a.Config.DataDir
|
|
|
|
cmd.logger = testutil.Logger(t)
|
|
|
|
newLogLevel := "ERROR"
|
|
cmd.flagArgs.Config.LogLevel = &newLogLevel
|
|
|
|
oldCfg := config.RuntimeConfig{
|
|
LogLevel: "INFO",
|
|
}
|
|
cfg, err := cmd.handleReload(a.Agent, &oldCfg)
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %s", err)
|
|
}
|
|
|
|
if cfg.LogLevel != "ERROR" {
|
|
t.Fatalf("expected log level to change to 'ERROR', got: %s", cfg.LogLevel)
|
|
}
|
|
if cmd.logger.IsWarn() || !cmd.logger.IsError() {
|
|
t.Fatal("expected logger level to change to 'ERROR'")
|
|
}
|
|
}
|