open-consul/command/snapshot
Daniel Nephin 4f0d092c95 testing: remove unnecessary calls to freeport
Previously we believe it was necessary for all code that required ports
to use freeport to prevent conflicts.

https://github.com/dnephin/freeport-test shows that it is actually save
to use port 0 (`127.0.0.1:0`) as long as it is passed directly to
`net.Listen`, and the listener holds the port for as long as it is
needed.

This works because freeport explicitly avoids the ephemeral port range,
and port 0 always uses that range. As you can see from the test output
of https://github.com/dnephin/freeport-test, the two systems never use
overlapping ports.

This commit converts all uses of freeport that were being passed
directly to a net.Listen to use port 0 instead. This allows us to remove
a bit of wrapping we had around httptest, in a couple places.
2021-11-29 12:19:43 -05:00
..
inspect Fix panic bug in snapshot inspect (#10091) 2021-04-23 20:48:10 +01:00
restore testing: skip slow tests with -short 2020-12-07 13:42:55 -05:00
save testing: remove unnecessary calls to freeport 2021-11-29 12:19:43 -05:00
snapshot_command.go commands: get HTTP API flags for usage automatically 2017-10-18 00:08:45 +02:00
snapshot_command_test.go