luxolus/open-consul
2
0
Fork 0
Code Issues 1 Pull requests Packages Releases Wiki Activity
open-consul/acl/policy_test.go
Matt Keeler 99e0a124cb
New ACLs (#4791) 
This PR is almost a complete rewrite of the ACL system within Consul. It brings the features more in line with other HashiCorp products. Obviously there is quite a bit left to do here but most of it is related docs, testing and finishing the last few commands in the CLI. I will update the PR description and check off the todos as I finish them over the next few days/week.
Description

At a high level this PR is mainly to split ACL tokens from Policies and to split the concepts of Authorization from Identities. A lot of this PR is mostly just to support CRUD operations on ACLTokens and ACLPolicies. These in and of themselves are not particularly interesting. The bigger conceptual changes are in how tokens get resolved, how backwards compatibility is handled and the separation of policy from identity which could lead the way to allowing for alternative identity providers.

On the surface and with a new cluster the ACL system will look very similar to that of Nomads. Both have tokens and policies. Both have local tokens. The ACL management APIs for both are very similar. I even ripped off Nomad's ACL bootstrap resetting procedure. There are a few key differences though.

    Nomad requires token and policy replication where Consul only requires policy replication with token replication being opt-in. In Consul local tokens only work with token replication being enabled though.
    All policies in Nomad are globally applicable. In Consul all policies are stored and replicated globally but can be scoped to a subset of the datacenters. This allows for more granular access management.
    Unlike Nomad, Consul has legacy baggage in the form of the original ACL system. The ramifications of this are:
        A server running the new system must still support other clients using the legacy system.
        A client running the new system must be able to use the legacy RPCs when the servers in its datacenter are running the legacy system.
        The primary ACL DC's servers running in legacy mode needs to be a gate that keeps everything else in the entire multi-DC cluster running in legacy mode.

So not only does this PR implement the new ACL system but has a legacy mode built in for when the cluster isn't ready for new ACLs. Also detecting that new ACLs can be used is automatic and requires no configuration on the part of administrators. This process is detailed more in the "Transitioning from Legacy to New ACL Mode" section below.
2018-10-19 12:04:07 -04:00

1547 lines
30 KiB
Go
Raw Blame History

package acl
import (
"strings"
"testing"
"github.com/stretchr/testify/require"
)
func errStartsWith(t *testing.T, actual error, expected string) {
t.Helper()
require.Error(t, actual)
require.Truef(t, strings.HasPrefix(actual.Error(), expected), "Received unexpected error: %#v\nExpecting an error with the prefix: %q", actual, expected)
}
func TestPolicySourceParse(t *testing.T) {
ljoin := func(lines ...string) string {
return strings.Join(lines, "\n")
}
cases := []struct {
Name string
Syntax SyntaxVersion
Rules string
Expected *Policy
Err string
}{
{
"Legacy Basic",
SyntaxLegacy,
ljoin(
`agent "foo" { `,
` policy = "read" `,
`} `,
`agent "bar" { `,
` policy = "write" `,
`} `,
`event "" { `,
` policy = "read" `,
`} `,
`event "foo" { `,
` policy = "write" `,
`} `,
`event "bar" { `,
` policy = "deny" `,
`} `,
`key "" { `,
` policy = "read" `,
`} `,
`key "foo/" { `,
` policy = "write" `,
`} `,
`key "foo/bar/" { `,
` policy = "read" `,
`} `,
`key "foo/bar/baz" {`,
` policy = "deny" `,
`} `,
`keyring = "deny" `,
`node "" { `,
` policy = "read" `,
`} `,
`node "foo" { `,
` policy = "write" `,
`} `,
`node "bar" { `,
` policy = "deny" `,
`} `,
`operator = "deny" `,
`service "" { `,
` policy = "write" `,
`} `,
`service "foo" { `,
` policy = "read" `,
`} `,
`session "foo" { `,
` policy = "write" `,
`} `,
`session "bar" { `,
` policy = "deny" `,
`} `,
`query "" { `,
` policy = "read" `,
`} `,
`query "foo" { `,
` policy = "write" `,
`} `,
`query "bar" { `,
` policy = "deny" `,
`} `),
&Policy{
AgentPrefixes: []*AgentPolicy{
&AgentPolicy{
Node: "foo",
Policy: PolicyRead,
},
&AgentPolicy{
Node: "bar",
Policy: PolicyWrite,
},
},
EventPrefixes: []*EventPolicy{
&EventPolicy{
Event: "",
Policy: PolicyRead,
},
&EventPolicy{
Event: "foo",
Policy: PolicyWrite,
},
&EventPolicy{
Event: "bar",
Policy: PolicyDeny,
},
},
Keyring: PolicyDeny,
KeyPrefixes: []*KeyPolicy{
&KeyPolicy{
Prefix: "",
Policy: PolicyRead,
},
&KeyPolicy{
Prefix: "foo/",
Policy: PolicyWrite,
},
&KeyPolicy{
Prefix: "foo/bar/",
Policy: PolicyRead,
},
&KeyPolicy{
Prefix: "foo/bar/baz",
Policy: PolicyDeny,
},
},
NodePrefixes: []*NodePolicy{
&NodePolicy{
Name: "",
Policy: PolicyRead,
},
&NodePolicy{
Name: "foo",
Policy: PolicyWrite,
},
&NodePolicy{
Name: "bar",
Policy: PolicyDeny,
},
},
Operator: PolicyDeny,
PreparedQueryPrefixes: []*PreparedQueryPolicy{
&PreparedQueryPolicy{
Prefix: "",
Policy: PolicyRead,
},
&PreparedQueryPolicy{
Prefix: "foo",
Policy: PolicyWrite,
},
&PreparedQueryPolicy{
Prefix: "bar",
Policy: PolicyDeny,
},
},
ServicePrefixes: []*ServicePolicy{
&ServicePolicy{
Name: "",
Policy: PolicyWrite,
},
&ServicePolicy{
Name: "foo",
Policy: PolicyRead,
},
},
SessionPrefixes: []*SessionPolicy{
&SessionPolicy{
Node: "foo",
Policy: PolicyWrite,
},
&SessionPolicy{
Node: "bar",
Policy: PolicyDeny,
},
},
},
"",
},
{
"Legacy (JSON)",
SyntaxLegacy,
ljoin(
`{ `,
` "agent": { `,
` "foo": { `,
` "policy": "write" `,
` }, `,
` "bar": { `,
` "policy": "deny" `,
` } `,
` }, `,
` "event": { `,
` "": { `,
` "policy": "read" `,
` }, `,
` "foo": { `,
` "policy": "write" `,
` }, `,
` "bar": { `,
` "policy": "deny" `,
` } `,
` }, `,
` "key": { `,
` "": { `,
` "policy": "read" `,
` }, `,
` "foo/": { `,
` "policy": "write" `,
` }, `,
` "foo/bar/": { `,
` "policy": "read" `,
` }, `,
` "foo/bar/baz": { `,
` "policy": "deny" `,
` } `,
` }, `,
` "keyring": "deny", `,
` "node": { `,
` "": { `,
` "policy": "read" `,
` }, `,
` "foo": { `,
` "policy": "write" `,
` }, `,
` "bar": { `,
` "policy": "deny" `,
` } `,
` }, `,
` "operator": "deny", `,
` "query": { `,
` "": { `,
` "policy": "read" `,
` }, `,
` "foo": { `,
` "policy": "write" `,
` }, `,
` "bar": { `,
` "policy": "deny" `,
` } `,
` }, `,
` "service": { `,
` "": { `,
` "policy": "write" `,
` }, `,
` "foo": { `,
` "policy": "read" `,
` } `,
` }, `,
` "session": { `,
` "foo": { `,
` "policy": "write" `,
` }, `,
` "bar": { `,
` "policy": "deny" `,
` } `,
` } `,
`} `),
&Policy{
AgentPrefixes: []*AgentPolicy{
&AgentPolicy{
Node: "foo",
Policy: PolicyWrite,
},
&AgentPolicy{
Node: "bar",
Policy: PolicyDeny,
},
},
EventPrefixes: []*EventPolicy{
&EventPolicy{
Event: "",
Policy: PolicyRead,
},
&EventPolicy{
Event: "foo",
Policy: PolicyWrite,
},
&EventPolicy{
Event: "bar",
Policy: PolicyDeny,
},
},
Keyring: PolicyDeny,
KeyPrefixes: []*KeyPolicy{
&KeyPolicy{
Prefix: "",
Policy: PolicyRead,
},
&KeyPolicy{
Prefix: "foo/",
Policy: PolicyWrite,
},
&KeyPolicy{
Prefix: "foo/bar/",
Policy: PolicyRead,
},
&KeyPolicy{
Prefix: "foo/bar/baz",
Policy: PolicyDeny,
},
},
NodePrefixes: []*NodePolicy{
&NodePolicy{
Name: "",
Policy: PolicyRead,
},
&NodePolicy{
Name: "foo",
Policy: PolicyWrite,
},
&NodePolicy{
Name: "bar",
Policy: PolicyDeny,
},
},
Operator: PolicyDeny,
PreparedQueryPrefixes: []*PreparedQueryPolicy{
&PreparedQueryPolicy{
Prefix: "",
Policy: PolicyRead,
},
&PreparedQueryPolicy{
Prefix: "foo",
Policy: PolicyWrite,
},
&PreparedQueryPolicy{
Prefix: "bar",
Policy: PolicyDeny,
},
},
ServicePrefixes: []*ServicePolicy{
&ServicePolicy{
Name: "",
Policy: PolicyWrite,
},
&ServicePolicy{
Name: "foo",
Policy: PolicyRead,
},
},
SessionPrefixes: []*SessionPolicy{
&SessionPolicy{
Node: "foo",
Policy: PolicyWrite,
},
&SessionPolicy{
Node: "bar",
Policy: PolicyDeny,
},
},
},
"",
},
{
"Service No Intentions (Legacy)",
SyntaxLegacy,
ljoin(
`service "foo" { `,
` policy = "write"`,
`} `),
&Policy{
ServicePrefixes: []*ServicePolicy{
{
Name: "foo",
Policy: "write",
},
},
},
"",
},
{
"Service Intentions (Legacy)",
SyntaxLegacy,
ljoin(
`service "foo" { `,
` policy = "write" `,
` intentions = "read"`,
`} `),
&Policy{
ServicePrefixes: []*ServicePolicy{
{
Name: "foo",
Policy: "write",
Intentions: "read",
},
},
},
"",
},
{
"Service Intention: invalid value (Legacy)",
SyntaxLegacy,
ljoin(
`service "foo" { `,
` policy = "write" `,
` intentions = "foo"`,
`} `),
nil,
"Invalid service intentions policy",
},
{
"Bad Policy - ACL",
SyntaxCurrent,
`acl = "nope"`,
nil,
"Invalid acl policy",
},
{
"Bad Policy - Agent",
SyntaxCurrent,
`agent "foo" { policy = "nope" }`,
nil,
"Invalid agent policy",
},
{
"Bad Policy - Agent Prefix",
SyntaxCurrent,
`agent_prefix "foo" { policy = "nope" }`,
nil,
"Invalid agent_prefix policy",
},
{
"Bad Policy - Key",
SyntaxCurrent,
`key "foo" { policy = "nope" }`,
nil,
"Invalid key policy",
},
{
"Bad Policy - Key Prefix",
SyntaxCurrent,
`key_prefix "foo" { policy = "nope" }`,
nil,
"Invalid key_prefix policy",
},
{
"Bad Policy - Node",
SyntaxCurrent,
`node "foo" { policy = "nope" }`,
nil,
"Invalid node policy",
},
{
"Bad Policy - Node Prefix",
SyntaxCurrent,
`node_prefix "foo" { policy = "nope" }`,
nil,
"Invalid node_prefix policy",
},
{
"Bad Policy - Service",
SyntaxCurrent,
`service "foo" { policy = "nope" }`,
nil,
"Invalid service policy",
},
{
"Bad Policy - Service Prefix",
SyntaxCurrent,
`service_prefix "foo" { policy = "nope" }`,
nil,
"Invalid service_prefix policy",
},
{
"Bad Policy - Session",
SyntaxCurrent,
`session "foo" { policy = "nope" }`,
nil,
"Invalid session policy",
},
{
"Bad Policy - Session Prefix",
SyntaxCurrent,
`session_prefix "foo" { policy = "nope" }`,
nil,
"Invalid session_prefix policy",
},
{
"Bad Policy - Event",
SyntaxCurrent,
`event "foo" { policy = "nope" }`,
nil,
"Invalid event policy",
},
{
"Bad Policy - Event Prefix",
SyntaxCurrent,
`event_prefix "foo" { policy = "nope" }`,
nil,
"Invalid event_prefix policy",
},
{
"Bad Policy - Prepared Query",
SyntaxCurrent,
`query "foo" { policy = "nope" }`,
nil,
"Invalid query policy",
},
{
"Bad Policy - Prepared Query Prefix",
SyntaxCurrent,
`query_prefix "foo" { policy = "nope" }`,
nil,
"Invalid query_prefix policy",
},
{
"Bad Policy - Keyring",
SyntaxCurrent,
`keyring = "nope"`,
nil,
"Invalid keyring policy",
},
{
"Bad Policy - Operator",
SyntaxCurrent,
`operator = "nope"`,
nil,
"Invalid operator policy",
},
{
"Keyring Empty",
SyntaxCurrent,
`keyring = ""`,
&Policy{Keyring: ""},
"",
},
{
"Operator Empty",
SyntaxCurrent,
`operator = ""`,
&Policy{Operator: ""},
"",
},
}
for _, tc := range cases {
t.Run(tc.Name, func(t *testing.T) {
req := require.New(t)
actual, err := NewPolicyFromSource("", 0, tc.Rules, tc.Syntax, nil)
if tc.Err != "" {
errStartsWith(t, err, tc.Err)
} else {
req.Equal(tc.Expected, actual)
}
})
}
}
func TestMergePolicies(t *testing.T) {
type mergeTest struct {
name string
input []*Policy
expected *Policy
}
tests := []mergeTest{
{
name: "Agents",
input: []*Policy{
&Policy{
Agents: []*AgentPolicy{
&AgentPolicy{
Node: "foo",
Policy: PolicyWrite,
},
&AgentPolicy{
Node: "bar",
Policy: PolicyRead,
},
&AgentPolicy{
Node: "baz",
Policy: PolicyWrite,
},
},
AgentPrefixes: []*AgentPolicy{
&AgentPolicy{
Node: "000",
Policy: PolicyWrite,
},
&AgentPolicy{
Node: "111",
Policy: PolicyRead,
},
&AgentPolicy{
Node: "222",
Policy: PolicyWrite,
},
},
},
&Policy{
Agents: []*AgentPolicy{
&AgentPolicy{
Node: "foo",
Policy: PolicyRead,
},
&AgentPolicy{
Node: "baz",
Policy: PolicyDeny,
},
},
AgentPrefixes: []*AgentPolicy{
&AgentPolicy{
Node: "000",
Policy: PolicyRead,
},
&AgentPolicy{
Node: "222",
Policy: PolicyDeny,
},
},
},
},
expected: &Policy{
Agents: []*AgentPolicy{
&AgentPolicy{
Node: "foo",
Policy: PolicyWrite,
},
&AgentPolicy{
Node: "bar",
Policy: PolicyRead,
},
&AgentPolicy{
Node: "baz",
Policy: PolicyDeny,
},
},
AgentPrefixes: []*AgentPolicy{
&AgentPolicy{
Node: "000",
Policy: PolicyWrite,
},
&AgentPolicy{
Node: "111",
Policy: PolicyRead,
},
&AgentPolicy{
Node: "222",
Policy: PolicyDeny,
},
},
},
},
{
name: "Events",
input: []*Policy{
&Policy{
Events: []*EventPolicy{
&EventPolicy{
Event: "foo",
Policy: PolicyWrite,
},
&EventPolicy{
Event: "bar",
Policy: PolicyRead,
},
&EventPolicy{
Event: "baz",
Policy: PolicyWrite,
},
},
EventPrefixes: []*EventPolicy{
&EventPolicy{
Event: "000",
Policy: PolicyWrite,
},
&EventPolicy{
Event: "111",
Policy: PolicyRead,
},
&EventPolicy{
Event: "222",
Policy: PolicyWrite,
},
},
},
&Policy{
Events: []*EventPolicy{
&EventPolicy{
Event: "foo",
Policy: PolicyRead,
},
&EventPolicy{
Event: "baz",
Policy: PolicyDeny,
},
},
EventPrefixes: []*EventPolicy{
&EventPolicy{
Event: "000",
Policy: PolicyRead,
},
&EventPolicy{
Event: "222",
Policy: PolicyDeny,
},
},
},
},
expected: &Policy{
Events: []*EventPolicy{
&EventPolicy{
Event: "foo",
Policy: PolicyWrite,
},
&EventPolicy{
Event: "bar",
Policy: PolicyRead,
},
&EventPolicy{
Event: "baz",
Policy: PolicyDeny,
},
},
EventPrefixes: []*EventPolicy{
&EventPolicy{
Event: "000",
Policy: PolicyWrite,
},
&EventPolicy{
Event: "111",
Policy: PolicyRead,
},
&EventPolicy{
Event: "222",
Policy: PolicyDeny,
},
},
},
},
{
name: "Node",
input: []*Policy{
&Policy{
Nodes: []*NodePolicy{
&NodePolicy{
Name: "foo",
Policy: PolicyWrite,
},
&NodePolicy{
Name: "bar",
Policy: PolicyRead,
},
&NodePolicy{
Name: "baz",
Policy: PolicyWrite,
},
},
NodePrefixes: []*NodePolicy{
&NodePolicy{
Name: "000",
Policy: PolicyWrite,
},
&NodePolicy{
Name: "111",
Policy: PolicyRead,
},
&NodePolicy{
Name: "222",
Policy: PolicyWrite,
},
},
},
&Policy{
Nodes: []*NodePolicy{
&NodePolicy{
Name: "foo",
Policy: PolicyRead,
},
&NodePolicy{
Name: "baz",
Policy: PolicyDeny,
},
},
NodePrefixes: []*NodePolicy{
&NodePolicy{
Name: "000",
Policy: PolicyRead,
},
&NodePolicy{
Name: "222",
Policy: PolicyDeny,
},
},
},
},
expected: &Policy{
Nodes: []*NodePolicy{
&NodePolicy{
Name: "foo",
Policy: PolicyWrite,
},
&NodePolicy{
Name: "bar",
Policy: PolicyRead,
},
&NodePolicy{
Name: "baz",
Policy: PolicyDeny,
},
},
NodePrefixes: []*NodePolicy{
&NodePolicy{
Name: "000",
Policy: PolicyWrite,
},
&NodePolicy{
Name: "111",
Policy: PolicyRead,
},
&NodePolicy{
Name: "222",
Policy: PolicyDeny,
},
},
},
},
{
name: "Keys",
input: []*Policy{
&Policy{
Keys: []*KeyPolicy{
&KeyPolicy{
Prefix: "foo",
Policy: PolicyWrite,
},
&KeyPolicy{
Prefix: "bar",
Policy: PolicyRead,
},
&KeyPolicy{
Prefix: "baz",
Policy: PolicyWrite,
},
&KeyPolicy{
Prefix: "zoo",
Policy: PolicyList,
},
},
KeyPrefixes: []*KeyPolicy{
&KeyPolicy{
Prefix: "000",
Policy: PolicyWrite,
},
&KeyPolicy{
Prefix: "111",
Policy: PolicyRead,
},
&KeyPolicy{
Prefix: "222",
Policy: PolicyWrite,
},
&KeyPolicy{
Prefix: "333",
Policy: PolicyList,
},
},
},
&Policy{
Keys: []*KeyPolicy{
&KeyPolicy{
Prefix: "foo",
Policy: PolicyRead,
},
&KeyPolicy{
Prefix: "baz",
Policy: PolicyDeny,
},
&KeyPolicy{
Prefix: "zoo",
Policy: PolicyRead,
},
},
KeyPrefixes: []*KeyPolicy{
&KeyPolicy{
Prefix: "000",
Policy: PolicyRead,
},
&KeyPolicy{
Prefix: "222",
Policy: PolicyDeny,
},
&KeyPolicy{
Prefix: "333",
Policy: PolicyRead,
},
},
},
},
expected: &Policy{
Keys: []*KeyPolicy{
&KeyPolicy{
Prefix: "foo",
Policy: PolicyWrite,
},
&KeyPolicy{
Prefix: "bar",
Policy: PolicyRead,
},
&KeyPolicy{
Prefix: "baz",
Policy: PolicyDeny,
},
&KeyPolicy{
Prefix: "zoo",
Policy: PolicyList,
},
},
KeyPrefixes: []*KeyPolicy{
&KeyPolicy{
Prefix: "000",
Policy: PolicyWrite,
},
&KeyPolicy{
Prefix: "111",
Policy: PolicyRead,
},
&KeyPolicy{
Prefix: "222",
Policy: PolicyDeny,
},
&KeyPolicy{
Prefix: "333",
Policy: PolicyList,
},
},
},
},
{
name: "Services",
input: []*Policy{
&Policy{
Services: []*ServicePolicy{
&ServicePolicy{
Name: "foo",
Policy: PolicyWrite,
Intentions: PolicyWrite,
},
&ServicePolicy{
Name: "bar",
Policy: PolicyRead,
Intentions: PolicyRead,
},
&ServicePolicy{
Name: "baz",
Policy: PolicyWrite,
Intentions: PolicyWrite,
},
},
ServicePrefixes: []*ServicePolicy{
&ServicePolicy{
Name: "000",
Policy: PolicyWrite,
Intentions: PolicyWrite,
},
&ServicePolicy{
Name: "111",
Policy: PolicyRead,
Intentions: PolicyRead,
},
&ServicePolicy{
Name: "222",
Policy: PolicyWrite,
Intentions: PolicyWrite,
},
},
},
&Policy{
Services: []*ServicePolicy{
&ServicePolicy{
Name: "foo",
Policy: PolicyRead,
Intentions: PolicyRead,
},
&ServicePolicy{
Name: "baz",
Policy: PolicyDeny,
Intentions: PolicyDeny,
},
},
ServicePrefixes: []*ServicePolicy{
&ServicePolicy{
Name: "000",
Policy: PolicyRead,
Intentions: PolicyRead,
},
&ServicePolicy{
Name: "222",
Policy: PolicyDeny,
Intentions: PolicyDeny,
},
},
},
},
expected: &Policy{
Services: []*ServicePolicy{
&ServicePolicy{
Name: "foo",
Policy: PolicyWrite,
Intentions: PolicyWrite,
},
&ServicePolicy{
Name: "bar",
Policy: PolicyRead,
Intentions: PolicyRead,
},
&ServicePolicy{
Name: "baz",
Policy: PolicyDeny,
Intentions: PolicyDeny,
},
},
ServicePrefixes: []*ServicePolicy{
&ServicePolicy{
Name: "000",
Policy: PolicyWrite,
Intentions: PolicyWrite,
},
&ServicePolicy{
Name: "111",
Policy: PolicyRead,
Intentions: PolicyRead,
},
&ServicePolicy{
Name: "222",
Policy: PolicyDeny,
Intentions: PolicyDeny,
},
},
},
},
{
name: "Sessions",
input: []*Policy{
&Policy{
Sessions: []*SessionPolicy{
&SessionPolicy{
Node: "foo",
Policy: PolicyWrite,
},
&SessionPolicy{
Node: "bar",
Policy: PolicyRead,
},
&SessionPolicy{
Node: "baz",
Policy: PolicyWrite,
},
},
SessionPrefixes: []*SessionPolicy{
&SessionPolicy{
Node: "000",
Policy: PolicyWrite,
},
&SessionPolicy{
Node: "111",
Policy: PolicyRead,
},
&SessionPolicy{
Node: "222",
Policy: PolicyWrite,
},
},
},
&Policy{
Sessions: []*SessionPolicy{
&SessionPolicy{
Node: "foo",
Policy: PolicyRead,
},
&SessionPolicy{
Node: "baz",
Policy: PolicyDeny,
},
},
SessionPrefixes: []*SessionPolicy{
&SessionPolicy{
Node: "000",
Policy: PolicyRead,
},
&SessionPolicy{
Node: "222",
Policy: PolicyDeny,
},
},
},
},
expected: &Policy{
Sessions: []*SessionPolicy{
&SessionPolicy{
Node: "foo",
Policy: PolicyWrite,
},
&SessionPolicy{
Node: "bar",
Policy: PolicyRead,
},
&SessionPolicy{
Node: "baz",
Policy: PolicyDeny,
},
},
SessionPrefixes: []*SessionPolicy{
&SessionPolicy{
Node: "000",
Policy: PolicyWrite,
},
&SessionPolicy{
Node: "111",
Policy: PolicyRead,
},
&SessionPolicy{
Node: "222",
Policy: PolicyDeny,
},
},
},
},
{
name: "Prepared Queries",
input: []*Policy{
&Policy{
PreparedQueries: []*PreparedQueryPolicy{
&PreparedQueryPolicy{
Prefix: "foo",
Policy: PolicyWrite,
},
&PreparedQueryPolicy{
Prefix: "bar",
Policy: PolicyRead,
},
&PreparedQueryPolicy{
Prefix: "baz",
Policy: PolicyWrite,
},
},
PreparedQueryPrefixes: []*PreparedQueryPolicy{
&PreparedQueryPolicy{
Prefix: "000",
Policy: PolicyWrite,
},
&PreparedQueryPolicy{
Prefix: "111",
Policy: PolicyRead,
},
&PreparedQueryPolicy{
Prefix: "222",
Policy: PolicyWrite,
},
},
},
&Policy{
PreparedQueries: []*PreparedQueryPolicy{
&PreparedQueryPolicy{
Prefix: "foo",
Policy: PolicyRead,
},
&PreparedQueryPolicy{
Prefix: "baz",
Policy: PolicyDeny,
},
},
PreparedQueryPrefixes: []*PreparedQueryPolicy{
&PreparedQueryPolicy{
Prefix: "000",
Policy: PolicyRead,
},
&PreparedQueryPolicy{
Prefix: "222",
Policy: PolicyDeny,
},
},
},
},
expected: &Policy{
PreparedQueries: []*PreparedQueryPolicy{
&PreparedQueryPolicy{
Prefix: "foo",
Policy: PolicyWrite,
},
&PreparedQueryPolicy{
Prefix: "bar",
Policy: PolicyRead,
},
&PreparedQueryPolicy{
Prefix: "baz",
Policy: PolicyDeny,
},
},
PreparedQueryPrefixes: []*PreparedQueryPolicy{
&PreparedQueryPolicy{
Prefix: "000",
Policy: PolicyWrite,
},
&PreparedQueryPolicy{
Prefix: "111",
Policy: PolicyRead,
},
&PreparedQueryPolicy{
Prefix: "222",
Policy: PolicyDeny,
},
},
},
},
{
name: "Write Precedence",
input: []*Policy{
&Policy{
ACL: PolicyRead,
Keyring: PolicyRead,
Operator: PolicyRead,
},
&Policy{
ACL: PolicyWrite,
Keyring: PolicyWrite,
Operator: PolicyWrite,
},
},
expected: &Policy{
ACL: PolicyWrite,
Keyring: PolicyWrite,
Operator: PolicyWrite,
},
},
{
name: "Deny Precedence",
input: []*Policy{
&Policy{
ACL: PolicyWrite,
Keyring: PolicyWrite,
Operator: PolicyWrite,
},
&Policy{
ACL: PolicyDeny,
Keyring: PolicyDeny,
Operator: PolicyDeny,
},
},
expected: &Policy{
ACL: PolicyDeny,
Keyring: PolicyDeny,
Operator: PolicyDeny,
},
},
{
name: "Read Precedence",
input: []*Policy{
&Policy{
ACL: PolicyRead,
Keyring: PolicyRead,
Operator: PolicyRead,
},
&Policy{},
},
expected: &Policy{
ACL: PolicyRead,
Keyring: PolicyRead,
Operator: PolicyRead,
},
},
}
req := require.New(t)
for _, tcase := range tests {
t.Run(tcase.name, func(t *testing.T) {
act := MergePolicies(tcase.input)
exp := tcase.expected
req.Equal(exp.ACL, act.ACL)
req.Equal(exp.Keyring, act.Keyring)
req.Equal(exp.Operator, act.Operator)
req.ElementsMatch(exp.Agents, act.Agents)
req.ElementsMatch(exp.AgentPrefixes, act.AgentPrefixes)
req.ElementsMatch(exp.Events, act.Events)
req.ElementsMatch(exp.EventPrefixes, act.EventPrefixes)
req.ElementsMatch(exp.Keys, act.Keys)
req.ElementsMatch(exp.KeyPrefixes, act.KeyPrefixes)
req.ElementsMatch(exp.Nodes, act.Nodes)
req.ElementsMatch(exp.NodePrefixes, act.NodePrefixes)
req.ElementsMatch(exp.PreparedQueries, act.PreparedQueries)
req.ElementsMatch(exp.PreparedQueryPrefixes, act.PreparedQueryPrefixes)
req.ElementsMatch(exp.Services, act.Services)
req.ElementsMatch(exp.ServicePrefixes, act.ServicePrefixes)
req.ElementsMatch(exp.Sessions, act.Sessions)
req.ElementsMatch(exp.SessionPrefixes, act.SessionPrefixes)
})
}
}
func TestRulesTranslate(t *testing.T) {
input := `
# top level comment
# block comment
agent "" {
# policy comment
policy = "write"
}
# block comment
key "" {
# policy comment
policy = "write"
}
# block comment
node "" {
# policy comment
policy = "write"
}
# block comment
event "" {
# policy comment
policy = "write"
}
# block comment
service "" {
# policy comment
policy = "write"
}
# block comment
session "" {
# policy comment
policy = "write"
}
# block comment
query "" {
# policy comment
policy = "write"
}
# comment
keyring = "write"
# comment
operator = "write"
`
expected := `
# top level comment
# block comment
agent_prefix "" {
# policy comment
policy = "write"
}
# block comment
key_prefix "" {
# policy comment
policy = "write"
}
# block comment
node_prefix "" {
# policy comment
policy = "write"
}
# block comment
event_prefix "" {
# policy comment
policy = "write"
}
# block comment
service_prefix "" {
# policy comment
policy = "write"
}
# block comment
session_prefix "" {
# policy comment
policy = "write"
}
# block comment
query_prefix "" {
# policy comment
policy = "write"
}
# comment
keyring = "write"
# comment
operator = "write"
`
output, err := TranslateLegacyRules([]byte(input))
require.NoError(t, err)
require.Equal(t, strings.Trim(expected, "\n"), string(output))
}
func TestPrecedence(t *testing.T) {
type testCase struct {
name string
a string
b string
expected bool
}
cases := []testCase{
{
name: "Deny Over Write",
a: PolicyDeny,
b: PolicyWrite,
expected: true,
},
{
name: "Deny Over List",
a: PolicyDeny,
b: PolicyList,
expected: true,
},
{
name: "Deny Over Read",
a: PolicyDeny,
b: PolicyRead,
expected: true,
},
{
name: "Deny Over Unknown",
a: PolicyDeny,
b: "not a policy",
expected: true,
},
{
name: "Write Over List",
a: PolicyWrite,
b: PolicyList,
expected: true,
},
{
name: "Write Over Read",
a: PolicyWrite,
b: PolicyRead,
expected: true,
},
{
name: "Write Over Unknown",
a: PolicyWrite,
b: "not a policy",
expected: true,
},
{
name: "List Over Read",
a: PolicyList,
b: PolicyRead,
expected: true,
},
{
name: "List Over Unknown",
a: PolicyList,
b: "not a policy",
expected: true,
},
{
name: "Read Over Unknown",
a: PolicyRead,
b: "not a policy",
expected: true,
},
{
name: "Write Over Deny",
a: PolicyWrite,
b: PolicyDeny,
expected: false,
},
{
name: "List Over Deny",
a: PolicyList,
b: PolicyDeny,
expected: false,
},
{
name: "Read Over Deny",
a: PolicyRead,
b: PolicyDeny,
expected: false,
},
{
name: "Deny Over Unknown",
a: PolicyDeny,
b: "not a policy",
expected: true,
},
{
name: "List Over Write",
a: PolicyList,
b: PolicyWrite,
expected: false,
},
{
name: "Read Over Write",
a: PolicyRead,
b: PolicyWrite,
expected: false,
},
{
name: "Unknown Over Write",
a: "not a policy",
b: PolicyWrite,
expected: false,
},
{
name: "Read Over List",
a: PolicyRead,
b: PolicyList,
expected: false,
},
{
name: "Unknown Over List",
a: "not a policy",
b: PolicyList,
expected: false,
},
{
name: "Unknown Over Read",
a: "not a policy",
b: PolicyRead,
expected: false,
},
}
for _, tcase := range cases {
t.Run(tcase.name, func(t *testing.T) {
require.Equal(t, tcase.expected, takesPrecedenceOver(tcase.a, tcase.b))
})
}
}
Reference in a new issue View git blame Copy permalink