048572946c
* v3.20.2...v3.24.0 * Fix handle undefined outlet in route component * Don't use template helper for optional modal.open Using the optional-helper here will trigger a computation in the same runloop error. This is because we are setting the `modal`-property when the `<Ref>` component gets rendered which will update the `this.modal`-property which will then recompute the `optional`-helper leading to this error. Instead we will create an action that will call the `open`-method on the modal when it is defined. This gets rid of the double computation error as we will not access the modal property twice in the same runloop when `modal` is getting set. * Fix - fn needs to be passed function tab-nav We create functions in the component file instead so that fn-helper stops complaining about the need to pass a function. * Update ember-exam to 6.1 version "Makes it compatible" with ember-qunit v5 * scheduleOnce setMaxHeight paged-collection We need to schedule to get around double-computation error. * Fix - model.data is removed from ember-data This has been private API all along - we need to work around the removal. Reference: https://github.com/emberjs/data/pull/7338/files#diff-9a8746fc5c86fd57e6122f00fef3155f76f0f3003a24b53fb7c4621d95dcd9bfL1310 * Fix `propContains` instead of `deepEqual` policy Recent model.data works differently than iterating attributes. We use `propContains` instead of `deepEqual`. We are only interested in the properties we assert against and match the previous behavior with this change. * Fix `propContains` instead of `deepEqual` token * Better handling single-records repo test-helper `model.data` has been removed we need to handle proxies and model instances differently. * Fix remaining repository tests with propContains We don't want to match entire objects - we don't care about properties we haven't defined in the assertion. * Don't use template helper for optional modal.open Using a template helper will give us a recomputation error - we work around it by creating an explicit action on the component instead. * Await `I $verb the $pageObject object` step * Fix no more customization ember-can No need to customize, the helper handles destruction fine on its own. * Fix - don't pass `optional` functions to fn We will declare the functions on the component instead. This gives us the same behavior but no error from `fn`, which expects a function to be passed. * Fix - handle `undefined` state on validate modifier StateChart can yield out an undefined `state` we need to handle that in the validate modifier * Fix linting errors tests directory * Warn / turn off new ember linting issues We will tackle them one by one and don't want to autofix issues that could be dangerous to auto-fix. * Auto-fix linting issues * More linting configuration * Fix remaining linting issues * Fix linting issues new files after rebase * ui: Remove ember-cli-uglify config now we are using terser (#14574) Co-authored-by: John Cowen <johncowen@users.noreply.github.com>
64 lines
1.9 KiB
JavaScript
64 lines
1.9 KiB
JavaScript
// Simple RSVP.EventTarget wrapper to make it more like a standard EventTarget
|
|
import RSVP from 'rsvp';
|
|
// See https://github.com/mysticatea/event-target-shim/blob/v4.0.2/src/event.mjs
|
|
// The MIT License (MIT) - Copyright (c) 2015 Toru Nagashima
|
|
import { setCurrentTarget, wrapEvent } from './event-target-shim/event';
|
|
|
|
const EventTarget = function () {};
|
|
function callbacksFor(object) {
|
|
let callbacks = object._promiseCallbacks;
|
|
|
|
if (!callbacks) {
|
|
callbacks = object._promiseCallbacks = {};
|
|
}
|
|
|
|
return callbacks;
|
|
}
|
|
EventTarget.prototype = Object.assign(
|
|
Object.create(Object.prototype, {
|
|
constructor: {
|
|
value: EventTarget,
|
|
configurable: true,
|
|
writable: true,
|
|
},
|
|
}),
|
|
{
|
|
dispatchEvent: function (obj) {
|
|
// borrow just what I need from event-target-shim
|
|
// to make true events even ErrorEvents with targets
|
|
const wrappedEvent = wrapEvent(this, obj);
|
|
setCurrentTarget(wrappedEvent, null);
|
|
// RSVP trigger doesn't bind to `this`
|
|
// the rest is pretty much the contents of `trigger`
|
|
// but with a `.bind(this)` to make it compatible
|
|
// with standard EventTarget
|
|
// we use `let` and `callbacksFor` above, just to keep things the same as rsvp.js
|
|
const eventName = obj.type;
|
|
const options = wrappedEvent;
|
|
let allCallbacks = callbacksFor(this);
|
|
|
|
let callbacks = allCallbacks[eventName];
|
|
if (callbacks) {
|
|
// Don't cache the callbacks.length since it may grow
|
|
let callback;
|
|
for (let i = 0; i < callbacks.length; i++) {
|
|
callback = callbacks[i];
|
|
callback.bind(this)(options);
|
|
}
|
|
}
|
|
},
|
|
addEventListener: function (event, cb) {
|
|
this.on(event, cb);
|
|
},
|
|
removeEventListener: function (event, cb) {
|
|
try {
|
|
this.off(event, cb);
|
|
} catch (e) {
|
|
// passthrough
|
|
}
|
|
},
|
|
}
|
|
);
|
|
RSVP.EventTarget.mixin(EventTarget.prototype);
|
|
export default EventTarget;
|