bed72f6078
* Rename agent/proxy package to reflect that it is limited to managed proxy processes Rationale: we have several other components of the agent that relate to Connect proxies for example the ProxyConfigManager component needed for Envoy work. Those things are pretty separate from the focus of this package so far which is only concerned with managing external proxy processes so it's nota good fit to put code for that in here, yet there is a naming clash if we have other packages related to proxy functionality that are not in the `agent/proxy` package. Happy to bikeshed the name. I started by calling it `managedproxy` but `managedproxy.Manager` is especially unpleasant. `proxyprocess` seems good in that it's more specific about purpose but less clearly connected with the concept of "managed proxies". The names in use are cleaner though e.g. `proxyprocess.Manager`. This rename was completed automatically using golang.org/x/tools/cmd/gomvpkg. Depends on #4541 * Fix missed windows tagged files
15 lines
520 B
Go
15 lines
520 B
Go
package proxyprocess
|
|
|
|
import (
|
|
"strings"
|
|
)
|
|
|
|
// isProcessAlreadyFinishedErr does a janky comparison with an error string
|
|
// defined in os/exec_unix.go and os/exec_windows.go which we encounter due to
|
|
// races with polling the external process. These case tests to fail since Stop
|
|
// returns an error sometimes so we should notice if this string stops matching
|
|
// the error in a future go version.
|
|
func isProcessAlreadyFinishedErr(err error) bool {
|
|
return strings.Contains(err.Error(), "os: process already finished")
|
|
}
|