Go to file
John Cowen 599e8a05d3
ui: Ensure we check intention service prefix permissions for per service (#11409)
Port of: Ensure we check intention service prefix permissions for per service (#11270)

Previously, when showing some action buttons for 'per service intentions' we used a global 'can I do something with any intention' permission to decide whether to show a certain button or not. If a user has a token that does not have 'global' intention permissions, but does have intention permissions on one or more specific services (for example via service / service_prefix), this meant that we did not show them certain buttons required to create/edit the intentions for this specific service.

This PR adds that extra permissions check so we now check the intentions permissions per service instead of using the 'global' "can I edit intentions" question/request.

**Notes:**

- If a HTML button is `disabled` this means tippy.js doesn't adopt the
popover properly and subsequently hide it from the user, so aswell as
just disabling the button so you can't active the popover, we also don't
even put the popover on the page
- If `ability.item` or `ability.item.Resources` are empty then assume no access

**We don't try to disable service > right hand side intention actions here**

Whether you can create intentions for a service depends on the
_destination_ of the intention you would like to create. For the
topology view going from the LHS to the center, this is straightforwards
as we only need to know the permissions for the central service, as when
you are going from the LHS to the center, the center is the
_destination_.

When going from the center to the RHS the _destination[s]_ are on the
RHS. This means we need to know the permissions for potentially 1000s of
services all in one go in order to know when to show a button or not.

We can't realistically discover the permissions for service > RHS
services as we'd have either make a HTTP request per right hand service,
or potentially make an incredibly large POST request for all the
potentially 1000s of services on the right hand side (more preferable to
1000s of HTTP requests).

Therefore for the moment at least we keep the old functionality (thin client)
for the middle to RHS here. If you do go to click on the button and you
don't have permissions to update the intention you will still not be
able to update it, only you won't know this until you click the button
(at which point you'll get a UI visible 403 error)

Note: We reversed the conditional here between 1.10 and 1.11

So this make 100% sense that the port is different here to 1.11
2021-11-04 12:10:28 +00:00
.changelog ui: Ensure we check intention service prefix permissions for per service (#11409) 2021-11-04 12:10:28 +00:00
.circleci connect: Remove support for Envoy 1.16 (#11354) 2021-10-27 18:51:35 -07:00
.github Prevent running build workflows on all PRs (#11469) 2021-11-01 17:29:45 -06:00
.release Update release branch to 1.11.x 2021-10-27 14:14:02 -07:00
acl Rework acl exports interface 2021-10-27 12:50:39 -06:00
agent fix aws pca certs (#11470) 2021-11-03 12:21:24 -07:00
api add root_cert_ttl option for consul connect, vault ca providers (#11428) 2021-11-02 11:02:10 -07:00
bench
build-support
command Support Check-And-Set deletion of config entries (#11419) 2021-11-01 16:42:01 +00:00
connect
contributing
demo
docs
grafana
internal
ipaddr
lib
logging
proto
sdk add root_cert_ttl option for consul connect, vault ca providers (#11428) 2021-11-02 11:02:10 -07:00
sentinel
service_os
snapshot
terraform
test regenerate expired certs (#11462) 2021-11-01 11:40:16 -04:00
testrpc Support Check-And-Set deletion of config entries (#11419) 2021-11-01 16:42:01 +00:00
tlsutil regenerate expired certs (#11462) 2021-11-01 11:40:16 -04:00
types
ui ui: Ensure we check intention service prefix permissions for per service (#11409) 2021-11-04 12:10:28 +00:00
version
website docs: consul-k8s uninstall with namespace (#11478) 2021-11-03 16:48:48 -07:00
.dockerignore
.gitattributes
.gitignore
.golangci.yml
CHANGELOG.md
Dockerfile PR fixes 2021-10-28 22:22:38 -07:00
GNUmakefile
INTERNALS.md
LICENSE
NOTICE.md
README.md
Vagrantfile
codecov.yml
go.mod
go.sum
main.go
main_test.go
package-lock.json

README.md

Consul CircleCI Discuss

Consul is a distributed, highly available, and data center aware solution to connect and configure applications across dynamic, distributed infrastructure.

Consul provides several key features:

  • Multi-Datacenter - Consul is built to be datacenter aware, and can support any number of regions without complex configuration.

  • Service Mesh/Service Segmentation - Consul Connect enables secure service-to-service communication with automatic TLS encryption and identity-based authorization. Applications can use sidecar proxies in a service mesh configuration to establish TLS connections for inbound and outbound connections without being aware of Connect at all.

  • Service Discovery - Consul makes it simple for services to register themselves and to discover other services via a DNS or HTTP interface. External services such as SaaS providers can be registered as well.

  • Health Checking - Health Checking enables Consul to quickly alert operators about any issues in a cluster. The integration with service discovery prevents routing traffic to unhealthy hosts and enables service level circuit breakers.

  • Key/Value Storage - A flexible key/value store enables storing dynamic configuration, feature flagging, coordination, leader election and more. The simple HTTP API makes it easy to use anywhere.

Consul runs on Linux, macOS, FreeBSD, Solaris, and Windows and includes an optional browser based UI. A commercial version called Consul Enterprise is also available.

Please note: We take Consul's security and our users' trust very seriously. If you believe you have found a security issue in Consul, please responsibly disclose by contacting us at security@hashicorp.com.

Quick Start

A few quick start guides are available on the Consul website:

Documentation

Full, comprehensive documentation is available on the Consul website:

https://www.consul.io/docs

Contributing

Thank you for your interest in contributing! Please refer to CONTRIBUTING.md for guidance. For contributions specifically to the browser based UI, please refer to the UI's README.md for guidance.