R.B. Boyer 3804677570 server: suppress spurious blocking query returns where multiple config entries are involved (#12362) ... Starting from and extending the mechanism introduced in #12110 we can specially handle the 3 main special Consul RPC endpoints that react to many config entries in a single blocking query in Connect: - `DiscoveryChain.Get` - `ConfigEntry.ResolveServiceConfig` - `Intentions.Match` All of these will internally watch for many config entries, and at least one of those will likely be not found in any given query. Because these are blends of multiple reads the exact solution from #12110 isn't perfectly aligned, but we can tweak the approach slightly and regain the utility of that mechanism. ### No Config Entries Found In this case, despite looking for many config entries none may be found at all. Unlike #12110 in this scenario we do not return an empty reply to the caller, but instead synthesize a struct from default values to return. This can be handled nearly identically to #12110 with the first 1-2 replies being non-empty payloads followed by the standard spurious wakeup suppression mechanism from #12110. ### No Change Since Last Wakeup Once a blocking query loop on the server has completed and slept at least once, there is a further optimization we can make here to detect if any of the config entries that were present at specific versions for the prior execution of the loop are identical for the loop we just woke up for. In that scenario we can return a slightly different internal sentinel error and basically externally handle it similar to #12110. This would mean that even if 20 discovery chain read RPC handling goroutines wakeup due to the creation of an unrelated config entry, the only ones that will terminate and reply with a blob of data are those that genuinely have new data to report. ### Extra Endpoints Since this pattern is pretty reusable, other key config-entry-adjacent endpoints used by `agent/proxycfg` also were updated: - `ConfigEntry.List` - `Internal.IntentionUpstreams` (tproxy)		2022-02-25 15:46:34 -06:00
..
authmethod	Vendor in rpc mono repo for net/rpc fork, go-msgpack, msgpackrpc. (#12311)	2022-02-14 09:45:45 -08:00
discoverychain	configentry: make a new package to hold shared config entry structs that aren't used for RPC or the FSM (#12384)	2022-02-22 10:36:36 -06:00
fsm	Vendor in rpc mono repo for net/rpc fork, go-msgpack, msgpackrpc. (#12311)	2022-02-14 09:45:45 -08:00
prepared_query	various partition related todos (#11822)	2021-12-13 11:43:33 -06:00
state	server: suppress spurious blocking query returns where multiple config entries are involved (#12362)	2022-02-25 15:46:34 -06:00
stream	streaming: split event buffer by key (#12080)	2022-01-28 12:27:00 +00:00
testdata	ca: examine the full chain in newCARoot	2022-02-17 18:21:30 -05:00
usagemetrics	Rename partition-exports to exported-services	2021-12-03 17:47:31 -07:00
wanfed	…
acl.go	acl: un-embed ACLIdentity	2022-02-02 12:07:31 -05:00
acl_authmethod.go	…
acl_authmethod_oss.go	re-run gofmt on 1.17 (#11579)	2021-11-16 12:04:01 -06:00
acl_authmethod_test.go	…
acl_client.go	Merge pull request #12165 from hashicorp/dnephin/acl-resolve-token	2022-01-31 13:27:49 -05:00
acl_endpoint.go	rpc: add errNotFound to all Get queries	2022-02-15 18:24:34 -05:00
acl_endpoint_legacy.go	…
acl_endpoint_oss.go	Cross port of ent #1383 (#11726)	2021-12-03 10:20:25 -08:00
acl_endpoint_test.go	Vendor in rpc mono repo for net/rpc fork, go-msgpack, msgpackrpc. (#12311)	2022-02-14 09:45:45 -08:00
acl_oss.go	various partition related todos (#11822)	2021-12-13 11:43:33 -06:00
acl_oss_test.go	re-run gofmt on 1.17 (#11579)	2021-11-16 12:04:01 -06:00
acl_replication.go	…
acl_replication_test.go	Rename `ACLMasterToken` => `ACLInitialManagementToken` (#11746)	2021-12-07 12:39:28 +00:00
acl_replication_types.go	…
acl_server.go	Merge pull request #12167 from hashicorp/dnephin/acl-resolve-token-3	2022-01-31 19:21:06 -05:00
acl_server_oss.go	re-run gofmt on 1.17 (#11579)	2021-11-16 12:04:01 -06:00
acl_test.go	Vendor in rpc mono repo for net/rpc fork, go-msgpack, msgpackrpc. (#12311)	2022-02-14 09:45:45 -08:00
acl_token_exp.go	acl: embed ACLResolver in Client and Server	2022-01-22 14:07:26 -05:00
acl_token_exp_test.go	[OSS] Remove remaining references to master (#11827)	2022-01-20 12:47:50 +00:00
auto_config_backend.go	auto-config: ensure the feature works properly with partitions (#11699)	2021-12-01 13:32:34 -06:00
auto_config_backend_test.go	[OSS] Remove remaining references to master (#11827)	2022-01-20 12:47:50 +00:00
auto_config_endpoint.go	auto-config: ensure the feature works properly with partitions (#11699)	2021-12-01 13:32:34 -06:00
auto_config_endpoint_test.go	Vendor in rpc mono repo for net/rpc fork, go-msgpack, msgpackrpc. (#12311)	2022-02-14 09:45:45 -08:00
auto_encrypt_endpoint.go	…
auto_encrypt_endpoint_test.go	Vendor in rpc mono repo for net/rpc fork, go-msgpack, msgpackrpc. (#12311)	2022-02-14 09:45:45 -08:00
autopilot.go	…
autopilot_oss.go	re-run gofmt on 1.17 (#11579)	2021-11-16 12:04:01 -06:00
autopilot_test.go	bulk rewrite using this script	2022-01-20 10:46:23 -06:00
catalog_endpoint.go	catalog: compare node names case insensitively in more places (#12444)	2022-02-24 16:54:47 -06:00
catalog_endpoint_test.go	catalog: compare node names case insensitively in more places (#12444)	2022-02-24 16:54:47 -06:00
client.go	Merge pull request #12165 from hashicorp/dnephin/acl-resolve-token	2022-01-31 13:27:49 -05:00
client_serf.go	partitions: various refactors to support partitioning the serf LAN pool (#11568)	2021-11-15 09:51:14 -06:00
client_test.go	Vendor in rpc mono repo for net/rpc fork, go-msgpack, msgpackrpc. (#12311)	2022-02-14 09:45:45 -08:00
cluster_test.go	Vendor in rpc mono repo for net/rpc fork, go-msgpack, msgpackrpc. (#12311)	2022-02-14 09:45:45 -08:00
config.go	Rename `ACLMasterToken` => `ACLInitialManagementToken` (#11746)	2021-12-07 12:39:28 +00:00
config_endpoint.go	server: suppress spurious blocking query returns where multiple config entries are involved (#12362)	2022-02-25 15:46:34 -06:00
config_endpoint_test.go	server: suppress spurious blocking query returns where multiple config entries are involved (#12362)	2022-02-25 15:46:34 -06:00
config_oss.go	re-run gofmt on 1.17 (#11579)	2021-11-16 12:04:01 -06:00
config_replication.go	server: partly fix config entry replication issue that prevents replication in some circumstances (#12307)	2022-02-23 17:27:48 -06:00
config_replication_test.go	server: partly fix config entry replication issue that prevents replication in some circumstances (#12307)	2022-02-23 17:27:48 -06:00
config_test.go	partitions: various refactors to support partitioning the serf LAN pool (#11568)	2021-11-15 09:51:14 -06:00
connect_ca_endpoint.go	…
connect_ca_endpoint_test.go	Vendor in rpc mono repo for net/rpc fork, go-msgpack, msgpackrpc. (#12311)	2022-02-14 09:45:45 -08:00
coordinate_endpoint.go	rpc: add errNotFound to all Get queries	2022-02-15 18:24:34 -05:00
coordinate_endpoint_test.go	Vendor in rpc mono repo for net/rpc fork, go-msgpack, msgpackrpc. (#12311)	2022-02-14 09:45:45 -08:00
discovery_chain_endpoint.go	server: suppress spurious blocking query returns where multiple config entries are involved (#12362)	2022-02-25 15:46:34 -06:00
discovery_chain_endpoint_test.go	server: suppress spurious blocking query returns where multiple config entries are involved (#12362)	2022-02-25 15:46:34 -06:00
enterprise_client_oss.go	partitions: various refactors to support partitioning the serf LAN pool (#11568)	2021-11-15 09:51:14 -06:00
enterprise_config_oss.go	re-run gofmt on 1.17 (#11579)	2021-11-16 12:04:01 -06:00
enterprise_server_oss.go	light refactors to support making partitions and serf-based wan federation are mutually exclusive (#11755)	2021-12-06 13:18:02 -06:00
enterprise_server_oss_test.go	re-run gofmt on 1.17 (#11579)	2021-11-16 12:04:01 -06:00
federation_state_endpoint.go	rpc: set response to nil when not found	2022-02-18 12:26:06 -05:00
federation_state_endpoint_test.go	Vendor in rpc mono repo for net/rpc fork, go-msgpack, msgpackrpc. (#12311)	2022-02-14 09:45:45 -08:00
federation_state_replication.go	…
federation_state_replication_test.go	…
filter.go	…
filter_test.go	acl: remove id and revision from Policy constructors	2021-11-05 15:45:08 -04:00
flood.go	…
gateway_locator.go	rpc: improve docs for blockingQuery	2022-02-15 14:20:14 -05:00
gateway_locator_test.go	rpc: improve docs for blockingQuery	2022-02-15 14:20:14 -05:00
health_endpoint.go	health: support `ResultsFilteredByACLs` flag/header (#11602)	2021-12-03 17:31:32 +00:00
health_endpoint_test.go	Vendor in rpc mono repo for net/rpc fork, go-msgpack, msgpackrpc. (#12311)	2022-02-14 09:45:45 -08:00
helper_test.go	Vendor in rpc mono repo for net/rpc fork, go-msgpack, msgpackrpc. (#12311)	2022-02-14 09:45:45 -08:00
intention_endpoint.go	server: suppress spurious blocking query returns where multiple config entries are involved (#12362)	2022-02-25 15:46:34 -06:00
intention_endpoint_test.go	server: suppress spurious blocking query returns where multiple config entries are involved (#12362)	2022-02-25 15:46:34 -06:00
internal_endpoint.go	server: suppress spurious blocking query returns where multiple config entries are involved (#12362)	2022-02-25 15:46:34 -06:00
internal_endpoint_test.go	server: suppress spurious blocking query returns where multiple config entries are involved (#12362)	2022-02-25 15:46:34 -06:00
issue_test.go	…
kvs_endpoint.go	rpc: add errNotFound to all Get queries	2022-02-15 18:24:34 -05:00
kvs_endpoint_test.go	Vendor in rpc mono repo for net/rpc fork, go-msgpack, msgpackrpc. (#12311)	2022-02-14 09:45:45 -08:00
leader.go	catalog: compare node names case insensitively in more places (#12444)	2022-02-24 16:54:47 -06:00
leader_connect.go	Add virtual IP generation for term gateway backed services	2022-01-12 12:08:49 -08:00
leader_connect_ca.go	Update TODOs to reference an issue with more details	2022-02-17 18:21:30 -05:00
leader_connect_ca_test.go	ca: test that original certs from secondary still verify	2022-02-17 18:45:16 -05:00
leader_connect_test.go	ca: examine the full chain in newCARoot	2022-02-17 18:21:30 -05:00
leader_federation_state_ae.go	…
leader_federation_state_ae_test.go	Rename `ACLMasterToken` => `ACLInitialManagementToken` (#11746)	2021-12-07 12:39:28 +00:00
leader_intentions.go	…
leader_intentions_oss.go	re-run gofmt on 1.17 (#11579)	2021-11-16 12:04:01 -06:00
leader_intentions_oss_test.go	re-run gofmt on 1.17 (#11579)	2021-11-16 12:04:01 -06:00
leader_intentions_test.go	configentry: make a new package to hold shared config entry structs that aren't used for RPC or the FSM (#12384)	2022-02-22 10:36:36 -06:00
leader_metrics.go	ca: use the new leaf signing lookup func in leader metrics	2022-01-06 16:55:49 -05:00
leader_oss_test.go	partitions: various refactors to support partitioning the serf LAN pool (#11568)	2021-11-15 09:51:14 -06:00
leader_test.go	fix flaky test panic (#12446)	2022-02-24 17:35:46 -06:00
logging.go	…
logging_test.go	bulk rewrite using this script	2022-01-20 10:46:23 -06:00
merge.go	catalog: compare node names case insensitively in more places (#12444)	2022-02-24 16:54:47 -06:00
merge_oss.go	partitions: various refactors to support partitioning the serf LAN pool (#11568)	2021-11-15 09:51:14 -06:00
merge_oss_test.go	partitions: various refactors to support partitioning the serf LAN pool (#11568)	2021-11-15 09:51:14 -06:00
merge_test.go	catalog: compare node names case insensitively in more places (#12444)	2022-02-24 16:54:47 -06:00
operator_autopilot_endpoint.go	Refactor to make ACL errors more structured. (#12308)	2022-02-11 12:53:23 -08:00
operator_autopilot_endpoint_test.go	Vendor in rpc mono repo for net/rpc fork, go-msgpack, msgpackrpc. (#12311)	2022-02-14 09:45:45 -08:00
operator_endpoint.go	…
operator_raft_endpoint.go	acl: un-embed ACLIdentity	2022-02-02 12:07:31 -05:00
operator_raft_endpoint_test.go	Vendor in rpc mono repo for net/rpc fork, go-msgpack, msgpackrpc. (#12311)	2022-02-14 09:45:45 -08:00
options.go	…
options_oss.go	re-run gofmt on 1.17 (#11579)	2021-11-16 12:04:01 -06:00
prepared_query_endpoint.go	catalog: compare node names case insensitively in more places (#12444)	2022-02-24 16:54:47 -06:00
prepared_query_endpoint_test.go	Vendor in rpc mono repo for net/rpc fork, go-msgpack, msgpackrpc. (#12311)	2022-02-14 09:45:45 -08:00
raft_rpc.go	…
replication.go	Apply suggestions from code review	2022-01-26 12:24:13 -05:00
replication_test.go	…
rpc.go	server: suppress spurious blocking query returns where multiple config entries are involved (#12362)	2022-02-25 15:46:34 -06:00
rpc_test.go	server: suppress spurious blocking query returns where multiple config entries are involved (#12362)	2022-02-25 15:46:34 -06:00
rtt.go	…
rtt_test.go	Vendor in rpc mono repo for net/rpc fork, go-msgpack, msgpackrpc. (#12311)	2022-02-14 09:45:45 -08:00
segment_oss.go	partitions: various refactors to support partitioning the serf LAN pool (#11568)	2021-11-15 09:51:14 -06:00
serf_filter.go	…
serf_test.go	…
server.go	Vendor in rpc mono repo for net/rpc fork, go-msgpack, msgpackrpc. (#12311)	2022-02-14 09:45:45 -08:00
server_connect.go	ca: accept only the cluster ID to SpiffeIDSigningForCluster	2021-11-16 16:57:21 -05:00
server_lookup.go	…
server_lookup_test.go	…
server_oss.go	catalog: compare node names case insensitively in more places (#12444)	2022-02-24 16:54:47 -06:00
server_register.go	…
server_serf.go	acl: embed ACLResolver in Client and Server	2022-01-22 14:07:26 -05:00
server_test.go	Vendor in rpc mono repo for net/rpc fork, go-msgpack, msgpackrpc. (#12311)	2022-02-14 09:45:45 -08:00
session_endpoint.go	rpc: add errNotFound to all Get queries	2022-02-15 18:24:34 -05:00
session_endpoint_test.go	Vendor in rpc mono repo for net/rpc fork, go-msgpack, msgpackrpc. (#12311)	2022-02-14 09:45:45 -08:00
session_timers.go	…
session_timers_test.go	…
session_ttl.go	port oss changes (#11736)	2021-12-03 17:23:55 -05:00
session_ttl_test.go	Vendor in rpc mono repo for net/rpc fork, go-msgpack, msgpackrpc. (#12311)	2022-02-14 09:45:45 -08:00
snapshot_endpoint.go	Vendor in rpc mono repo for net/rpc fork, go-msgpack, msgpackrpc. (#12311)	2022-02-14 09:45:45 -08:00
snapshot_endpoint_test.go	Vendor in rpc mono repo for net/rpc fork, go-msgpack, msgpackrpc. (#12311)	2022-02-14 09:45:45 -08:00
stats_fetcher.go	…
stats_fetcher_test.go	…
status_endpoint.go	…
status_endpoint_test.go	Vendor in rpc mono repo for net/rpc fork, go-msgpack, msgpackrpc. (#12311)	2022-02-14 09:45:45 -08:00
subscribe_backend.go	…
subscribe_backend_test.go	…
system_metadata.go	…
system_metadata_test.go	testing: Revert assertion for virtual IP flag (#11932)	2022-01-04 11:24:56 -05:00
txn_endpoint.go	txn: support `ResultsFilteredByACLs` flag in `Read` endpoint (#11632)	2021-12-03 20:41:03 +00:00
txn_endpoint_test.go	Vendor in rpc mono repo for net/rpc fork, go-msgpack, msgpackrpc. (#12311)	2022-02-14 09:45:45 -08:00
util.go	catalog: compare node names case insensitively in more places (#12444)	2022-02-24 16:54:47 -06:00
util_test.go	…