d6dce2332a
- Upgrade the ConfigEntry.ListAll RPC to be kind-aware so that older copies of consul will not see new config entries it doesn't understand replicate down. - Add shim conversion code so that the old API/CLI method of interacting with intentions will continue to work so long as none of these are edited via config entry endpoints. Almost all of the read-only APIs will continue to function indefinitely. - Add new APIs that operate on individual intentions without IDs so that the UI doesn't need to implement CAS operations. - Add a new serf feature flag indicating support for intentions-as-config-entries. - The old line-item intentions way of interacting with the state store will transparently flip between the legacy memdb table and the config entry representations so that readers will never see a hiccup during migration where the results are incomplete. It uses a piece of system metadata to control the flip. - The primary datacenter will begin migrating intentions into config entries on startup once all servers in the datacenter are on a version of Consul with the intentions-as-config-entries feature flag. When it is complete the old state store representations will be cleared. We also record a piece of system metadata indicating this has occurred. We use this metadata to skip ALL of this code the next time the leader starts up. - The secondary datacenters continue to run the old intentions replicator until all servers in the secondary DC and primary DC support intentions-as-config-entries (via serf flag). Once this condition it met the old intentions replicator ceases. - The secondary datacenters replicate the new config entries as they are migrated in the primary. When they detect that the primary has zeroed it's old state store table it waits until all config entries up to that point are replicated and then zeroes its own copy of the old state store table. We also record a piece of system metadata indicating this has occurred. We use this metadata to skip ALL of this code the next time the leader starts up.
162 lines
4.5 KiB
Go
162 lines
4.5 KiB
Go
package agent
|
|
|
|
import (
|
|
"fmt"
|
|
"net/http"
|
|
"strconv"
|
|
"strings"
|
|
|
|
"github.com/hashicorp/consul/agent/structs"
|
|
)
|
|
|
|
const ConfigEntryNotFoundErr string = "Config entry not found"
|
|
|
|
// Config switches on the different CRUD operations for config entries.
|
|
func (s *HTTPHandlers) Config(resp http.ResponseWriter, req *http.Request) (interface{}, error) {
|
|
switch req.Method {
|
|
case "GET":
|
|
return s.configGet(resp, req)
|
|
|
|
case "DELETE":
|
|
return s.configDelete(resp, req)
|
|
|
|
default:
|
|
return nil, MethodNotAllowedError{req.Method, []string{"GET", "DELETE"}}
|
|
}
|
|
}
|
|
|
|
// configGet gets either a specific config entry, or lists all config entries
|
|
// of a kind if no name is provided.
|
|
func (s *HTTPHandlers) configGet(resp http.ResponseWriter, req *http.Request) (interface{}, error) {
|
|
var args structs.ConfigEntryQuery
|
|
if done := s.parse(resp, req, &args.Datacenter, &args.QueryOptions); done {
|
|
return nil, nil
|
|
}
|
|
pathArgs := strings.SplitN(strings.TrimPrefix(req.URL.Path, "/v1/config/"), "/", 2)
|
|
|
|
switch len(pathArgs) {
|
|
case 2:
|
|
// Both kind/name provided.
|
|
args.Kind = pathArgs[0]
|
|
args.Name = pathArgs[1]
|
|
|
|
if err := s.parseEntMetaForConfigEntryKind(args.Kind, req, &args.EnterpriseMeta); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
var reply structs.ConfigEntryResponse
|
|
if err := s.agent.RPC("ConfigEntry.Get", &args, &reply); err != nil {
|
|
return nil, err
|
|
}
|
|
setMeta(resp, &reply.QueryMeta)
|
|
|
|
if reply.Entry == nil {
|
|
return nil, NotFoundError{Reason: fmt.Sprintf("%s for %q / %q", ConfigEntryNotFoundErr, pathArgs[0], pathArgs[1])}
|
|
}
|
|
|
|
return reply.Entry, nil
|
|
case 1:
|
|
if err := s.parseEntMeta(req, &args.EnterpriseMeta); err != nil {
|
|
return nil, err
|
|
}
|
|
// Only kind provided, list entries.
|
|
args.Kind = pathArgs[0]
|
|
|
|
var reply structs.IndexedConfigEntries
|
|
if err := s.agent.RPC("ConfigEntry.List", &args, &reply); err != nil {
|
|
return nil, err
|
|
}
|
|
setMeta(resp, &reply.QueryMeta)
|
|
|
|
return reply.Entries, nil
|
|
default:
|
|
return nil, NotFoundError{Reason: "Must provide either a kind or both kind and name"}
|
|
}
|
|
}
|
|
|
|
// configDelete deletes the given config entry.
|
|
func (s *HTTPHandlers) configDelete(resp http.ResponseWriter, req *http.Request) (interface{}, error) {
|
|
var args structs.ConfigEntryRequest
|
|
s.parseDC(req, &args.Datacenter)
|
|
s.parseToken(req, &args.Token)
|
|
pathArgs := strings.SplitN(strings.TrimPrefix(req.URL.Path, "/v1/config/"), "/", 2)
|
|
|
|
if len(pathArgs) != 2 {
|
|
resp.WriteHeader(http.StatusNotFound)
|
|
fmt.Fprintf(resp, "Must provide both a kind and name to delete")
|
|
return nil, nil
|
|
}
|
|
|
|
entry, err := structs.MakeConfigEntry(pathArgs[0], pathArgs[1])
|
|
if err != nil {
|
|
resp.WriteHeader(http.StatusBadRequest)
|
|
fmt.Fprintf(resp, "%v", err)
|
|
return nil, nil
|
|
}
|
|
args.Entry = entry
|
|
// Parse enterprise meta.
|
|
meta := args.Entry.GetEnterpriseMeta()
|
|
|
|
if err := s.parseEntMetaForConfigEntryKind(entry.GetKind(), req, meta); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
var reply struct{}
|
|
if err := s.agent.RPC("ConfigEntry.Delete", &args, &reply); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return reply, nil
|
|
}
|
|
|
|
// ConfigCreate applies the given config entry update.
|
|
func (s *HTTPHandlers) ConfigApply(resp http.ResponseWriter, req *http.Request) (interface{}, error) {
|
|
args := structs.ConfigEntryRequest{
|
|
Op: structs.ConfigEntryUpsert,
|
|
}
|
|
s.parseDC(req, &args.Datacenter)
|
|
s.parseToken(req, &args.Token)
|
|
|
|
var raw map[string]interface{}
|
|
if err := decodeBodyDeprecated(req, &raw, nil); err != nil {
|
|
return nil, BadRequestError{Reason: fmt.Sprintf("Request decoding failed: %v", err)}
|
|
}
|
|
|
|
if entry, err := structs.DecodeConfigEntry(raw); err == nil {
|
|
args.Entry = entry
|
|
} else {
|
|
return nil, BadRequestError{Reason: fmt.Sprintf("Request decoding failed: %v", err)}
|
|
}
|
|
|
|
// Parse enterprise meta.
|
|
var meta structs.EnterpriseMeta
|
|
if err := s.parseEntMetaForConfigEntryKind(args.Entry.GetKind(), req, &meta); err != nil {
|
|
return nil, err
|
|
}
|
|
args.Entry.GetEnterpriseMeta().Merge(&meta)
|
|
|
|
// Check for cas value
|
|
if casStr := req.URL.Query().Get("cas"); casStr != "" {
|
|
casVal, err := strconv.ParseUint(casStr, 10, 64)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
args.Op = structs.ConfigEntryUpsertCAS
|
|
args.Entry.GetRaftIndex().ModifyIndex = casVal
|
|
}
|
|
|
|
var reply bool
|
|
if err := s.agent.RPC("ConfigEntry.Apply", &args, &reply); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return reply, nil
|
|
}
|
|
|
|
func (s *HTTPHandlers) parseEntMetaForConfigEntryKind(kind string, req *http.Request, entMeta *structs.EnterpriseMeta) error {
|
|
if kind == structs.ServiceIntentions {
|
|
return s.parseEntMeta(req, entMeta)
|
|
}
|
|
return s.parseEntMetaNoWildcard(req, entMeta)
|
|
}
|