17f10ffd0d
* ui: Add tab navigation to the browser history/URLs
This commit changes all our tabbed UI interfaces in the catalog to use
actual URL changes rather than only updating the content in the page
using CSS.
Originally we had decided not to add tab clicks into the browser
history for a variety of reasons. As the UI has progressed these tabs
are a fairly common pattern we are using and as the UI grows and
stabilizes around certain UX patterns we've decided to make these tabs
'URL changing'.
Pros:
- Deeplinking
- Potentially smaller Route files with a more concentrated scope of the
contents of a tab rather than the entire page.
- Tab clicks now go into your history meaning backwards and forwards
buttons take you through the tabs not just the pages.
- The majority of our partials are now fully fledged templates (Octane
🎉)
Cons:
- Tab clicks now go into your history meaning backwards and forwards
buttons take you through the tabs not just the pages. (Could be good and
bad from a UX perspective)
- Many more Route and Controller files (yet as mentioned above each of these
have a more reduced scope)
- Moving around the contents of these tabs, or changing the visual names
of them means updates to the URL structure, which then should
potentially entail redirects, therefore what things that seem like
straightforwards design reorganizations are now a little more impactful.
It was getting to the point that the Pros outweight the Cons
Apart from moving some files around we made a few more tiny tweaks to
get this all working:
- Our freetext-filter component now performs the initial search rather
than this happening in the Controller (remove of the search method in
the Controllers and the new didInsertElement hook in the component)
- All of the <TabNav>'s were changed to use its alternative href
approach.
- <TabPanel>s usage was mostly removed. This is th thing I dislike the
most. I think this needs removing, but I'd also like to remove the HTML
it creates. You'll see that every new page is wrappe din the HTML for
the old <TabPanel>, this is to continue to use the same HTML structure
and id's as before to avoid making further changes to any CSS that might
use this and being able to target things during testing. We could have
also removed these here, but it would have meant a much larger changeset
and can just as easily be done at a later date.
- We made a new `tabgroup` page-object component, which is almost
identical to the previous `radiogroup` one and injected that instead
where needed during testing.
* Make sure we pick up indexed routes when nspaces are enabled
* Move session invalidation to the child (session) route
* Revert back to not using didInsertElement for updating the searching
This adds a way for the searchable to remember the last search result
instead, which changes less and stick to the previous method of
searching.
25 lines
801 B
JavaScript
25 lines
801 B
JavaScript
import { is, clickable } from 'ember-cli-page-object';
|
|
import ucfirst from 'consul-ui/utils/ucfirst';
|
|
export default function(name, items, blankKey = 'all') {
|
|
return items.reduce(function(prev, item, i, arr) {
|
|
// if item is empty then it means 'all'
|
|
// otherwise camelCase based on something-here = somethingHere for the key
|
|
const key =
|
|
item === ''
|
|
? blankKey
|
|
: item.split('-').reduce(function(prev, item, i, arr) {
|
|
if (i === 0) {
|
|
return item;
|
|
}
|
|
return prev + ucfirst(item);
|
|
});
|
|
return {
|
|
...prev,
|
|
...{
|
|
[`${key}IsSelected`]: is('.selected', `[data-test-tab="${name}_${item}"]`),
|
|
[key]: clickable(`[data-test-tab="${name}_${item}"] > label > a`),
|
|
},
|
|
};
|
|
}, {});
|
|
}
|