3b5e72913e
I spent some time today on my local Mac to figure out why Consul 1.6.3+ was not accepting limits.http_max_conns_per_client. This adds an explicit check on number of file descriptors to be sure it might work (this is no guarantee as if many clients are reaching the agent, it might consume even more file descriptors) Anyway, many users are fighting with RLIMIT_NOFILE, having a clear message would allow them to figure out what to fix. Example of message (reload or start): ``` 2020-03-11T16:38:37.062+0100 [ERROR] agent: Error starting agent: error="system allows a max of 512 file descriptors, but limits.http_max_conns_per_client: 8192 needs at least 8212" ```
21 lines
675 B
Go
21 lines
675 B
Go
package config
|
|
|
|
import (
|
|
"fmt"
|
|
)
|
|
|
|
// checkLimitsFromMaxConnsPerClient check that value provided might be OK
|
|
// return an error if values are not compatible
|
|
func checkLimitsFromMaxConnsPerClient(maxConnsPerClient int) error {
|
|
maxFds, err := getrlimit()
|
|
if err == nil && maxConnsPerClient > 0 {
|
|
// We need the list port + a few at the minimum
|
|
// On Mac OS, 20 FDs are open by Consul without doing anything
|
|
requiredFds := uint64(maxConnsPerClient + 20)
|
|
if maxFds < requiredFds {
|
|
return fmt.Errorf("system allows a max of %d file descriptors, but limits.http_max_conns_per_client: %d needs at least %d", maxFds, maxConnsPerClient, requiredFds)
|
|
}
|
|
}
|
|
return err
|
|
}
|