open-consul/internal/go-sso/oidcauth
Daniel Nephin 4f0d092c95 testing: remove unnecessary calls to freeport
Previously we believe it was necessary for all code that required ports
to use freeport to prevent conflicts.

https://github.com/dnephin/freeport-test shows that it is actually save
to use port 0 (`127.0.0.1:0`) as long as it is passed directly to
`net.Listen`, and the listener holds the port for as long as it is
needed.

This works because freeport explicitly avoids the ephemeral port range,
and port 0 always uses that range. As you can see from the test output
of https://github.com/dnephin/freeport-test, the two systems never use
overlapping ports.

This commit converts all uses of freeport that were being passed
directly to a net.Listen to use port 0 instead. This allows us to remove
a bit of wrapping we had around httptest, in a couple places.
2021-11-29 12:19:43 -05:00
..
internal/strutil
oidcauthtest testing: remove unnecessary calls to freeport 2021-11-29 12:19:43 -05:00
auth.go
config.go sso/oidc: add support for acr_values request parameter (#11026) 2021-09-17 09:10:05 -07:00
config_test.go sso/oidc: add support for acr_values request parameter (#11026) 2021-09-17 09:10:05 -07:00
jwt.go ci: enable SA4006 staticcheck check 2020-06-16 13:10:11 -04:00
jwt_test.go testing: skip slow tests with -short 2020-12-07 13:42:55 -05:00
oidc.go sso/oidc: add support for acr_values request parameter (#11026) 2021-09-17 09:10:05 -07:00
oidc_test.go sso/oidc: add support for acr_values request parameter (#11026) 2021-09-17 09:10:05 -07:00
oidcjwt.go Add unconvert linter 2020-05-12 13:47:25 -04:00
oidcjwt_test.go Enable gofmt simplify 2020-06-16 13:21:11 -04:00
util.go
util_test.go