luxolus
/
open-consul
2
0
Fork 0
Code Issues 1 Pull Requests Packages Releases Wiki Activity
open-consul/agent
History
Daniel Nephin 4f0d092c95 testing: remove unnecessary calls to freeport 
Previously we believe it was necessary for all code that required ports
to use freeport to prevent conflicts.

https://github.com/dnephin/freeport-test shows that it is actually save
to use port 0 (`127.0.0.1:0`) as long as it is passed directly to
`net.Listen`, and the listener holds the port for as long as it is
needed.

This works because freeport explicitly avoids the ephemeral port range,
and port 0 always uses that range. As you can see from the test output
of https://github.com/dnephin/freeport-test, the two systems never use
overlapping ports.

This commit converts all uses of freeport that were being passed
directly to a net.Listen to use port 0 instead. This allows us to remove
a bit of wrapping we had around httptest, in a couple places.
 		2021-11-29 12:19:43 -05:00
..
ae
…
auto-config re-run gofmt on 1.17 (#11579) 2021-11-16 12:04:01 -06:00
cache
…
cache-types re-run gofmt on 1.17 (#11579) 2021-11-16 12:04:01 -06:00
checks re-run gofmt on 1.17 (#11579) 2021-11-16 12:04:01 -06:00
config re-run gofmt on 1.17 (#11579) 2021-11-16 12:04:01 -06:00
connect testing: use the new freeport interfaces 2021-11-27 15:39:46 -05:00
consul testing: remove unnecessary calls to freeport 2021-11-29 12:19:43 -05:00
debug
…
dns Add DNS recursor strategy option (#10611) 2021-07-19 15:22:51 -07:00
exec re-run gofmt on 1.17 (#11579) 2021-11-16 12:04:01 -06:00
grpc testing: remove unnecessary calls to freeport 2021-11-29 12:19:43 -05:00
local Update node info sync comment (#11465) 2021-11-16 11:16:11 -08:00
metadata partitions: various refactors to support partitioning the serf LAN pool (#11568) 2021-11-15 09:51:14 -06:00
mock
…
pool grpc: ensure that streaming gRPC requests work over mesh gateway based wan federation (#10838) 2021-08-24 16:28:44 -05:00
proxycfg re-run gofmt on 1.17 (#11579) 2021-11-16 12:04:01 -06:00
router
…
routine-leak-checker acl: call stop for the upgrade goroutine when done 2021-09-29 17:36:43 -04:00
rpc/subscribe acl: remove id and revision from Policy constructors 2021-11-05 15:45:08 -04:00
rpcclient/health agent: ensure that most agent behavior correctly respects partition configuration (#10880) 2021-08-19 15:09:42 -05:00
structs Partition session checks store (#11638) 2021-11-24 09:10:38 -05:00
submatview grpc: strip local ACL tokens from RPCs during forwarding if crossing datacenters (#11099) 2021-09-22 13:14:26 -05:00
systemd
…
token re-run gofmt on 1.17 (#11579) 2021-11-16 12:04:01 -06:00
uiserver ui: Pass primary dc through to uiserver (#11317) 2021-10-26 10:30:17 -04:00
xds re-run gofmt on 1.17 (#11579) 2021-11-16 12:04:01 -06:00
acl.go agent: refactor the agent delegate interface to be partition friendly (#11429) 2021-10-26 15:08:55 -05:00
acl_endpoint.go acl: remove unused translate rules endpoint 2021-10-05 18:26:05 -04:00
acl_endpoint_legacy.go http: update legacy ACL endpoints to return an error 2021-08-17 13:09:29 -04:00
acl_endpoint_legacy_test.go agent: Ensure partition is considered in agent endpoints (#11427) 2021-10-26 15:20:57 -04:00
acl_endpoint_test.go testing: remove unnecessary calls to freeport 2021-11-29 12:19:43 -05:00
acl_oss.go re-run gofmt on 1.17 (#11579) 2021-11-16 12:04:01 -06:00
acl_test.go acl: remove id and revision from Policy constructors 2021-11-05 15:45:08 -04:00
agent.go agent: purge service/check registration files for incorrect partitions on reload (#11607) 2021-11-18 14:44:20 -06:00
agent_endpoint.go Merge from ent (#11506) 2021-11-19 11:50:44 -05:00
agent_endpoint_oss.go re-run gofmt on 1.17 (#11579) 2021-11-16 12:04:01 -06:00
agent_endpoint_test.go Merge from ent (#11506) 2021-11-19 11:50:44 -05:00
agent_oss.go re-run gofmt on 1.17 (#11579) 2021-11-16 12:04:01 -06:00
agent_test.go testing: remove unnecessary calls to freeport 2021-11-29 12:19:43 -05:00
apiserver.go
…
apiserver_test.go
…
catalog_endpoint.go try to infer command partition from node partition (#10981) 2021-09-03 08:37:23 -04:00
catalog_endpoint_oss.go re-run gofmt on 1.17 (#11579) 2021-11-16 12:04:01 -06:00
catalog_endpoint_test.go
…
check.go
…
config_endpoint.go Support Check-And-Set deletion of config entries (#11419) 2021-11-01 16:42:01 +00:00
config_endpoint_test.go Support Check-And-Set deletion of config entries (#11419) 2021-11-01 16:42:01 +00:00
connect_auth.go Account for partitions in ixn match/decision 2021-09-16 14:39:01 -06:00
connect_ca_endpoint.go add root_cert_ttl option for consul connect, vault ca providers (#11428) 2021-11-02 11:02:10 -07:00
connect_ca_endpoint_test.go ca: remove unused RotationPeriod field 2021-07-05 19:15:44 -04:00
coordinate_endpoint.go try to infer command partition from node partition (#10981) 2021-09-03 08:37:23 -04:00
coordinate_endpoint_test.go partitions: various refactors to support partitioning the serf LAN pool (#11568) 2021-11-15 09:51:14 -06:00
delegate_mock_test.go agent: refactor the agent delegate interface to be partition friendly (#11429) 2021-10-26 15:08:55 -05:00
denylist.go
…
denylist_test.go
…
discovery_chain_endpoint.go
…
discovery_chain_endpoint_test.go Remove useInDatacenter from disco chain requests 2021-10-26 23:35:21 -06:00
dns.go Merge pull request #11348 from kbabuadze/fix-answers-alt-domain 2021-10-29 17:09:20 -04:00
dns_oss.go re-run gofmt on 1.17 (#11579) 2021-11-16 12:04:01 -06:00
dns_test.go Merge pull request #11348 from kbabuadze/fix-answers-alt-domain 2021-10-29 17:09:20 -04:00
enterprise_delegate_oss.go re-run gofmt on 1.17 (#11579) 2021-11-16 12:04:01 -06:00
event_endpoint.go acl: Remove the remaining authz == nil checks 2021-07-30 14:55:35 -04:00
event_endpoint_test.go Update 4 non-acl tests that used the legacy ACL.Apply 2021-09-21 17:57:29 -04:00
federation_state_endpoint.go
…
health_endpoint.go
…
health_endpoint_test.go streaming: fix enable of streaming in the client 2021-06-28 17:23:14 -04:00
http.go acl: adding a new mesh resource 2021-09-03 09:12:03 -04:00
http_decode_test.go add test cases for h2ping_use_tls default behavior 2021-10-09 17:12:52 -04:00
http_oss.go re-run gofmt on 1.17 (#11579) 2021-11-16 12:04:01 -06:00
http_oss_test.go
…
http_register.go cleanup: Clarify deprecated legacy intention endpoints (#11635) 2021-11-23 19:32:18 -05:00
http_test.go agent: fix two data race in agent tests 2021-07-14 18:58:16 -04:00
intentions_endpoint.go cleanup: Clarify deprecated legacy intention endpoints (#11635) 2021-11-23 19:32:18 -05:00
intentions_endpoint_oss_test.go re-run gofmt on 1.17 (#11579) 2021-11-16 12:04:01 -06:00
intentions_endpoint_test.go agent: Reject partitions in legacy intention endpoints (#11181) 2021-10-01 13:18:57 -04:00
keyring.go
…
keyring_test.go
…
kvs_endpoint.go
…
kvs_endpoint_test.go
…
metrics.go agent: move agent tls metric monitor to a more appropriate place 2021-10-27 16:26:09 -04:00
metrics_test.go Add tests for cert expiry metrics 2021-10-28 14:38:57 -04:00
nodeid.go
…
nodeid_test.go
…
notify.go
…
notify_test.go
…
operator_endpoint.go partitions: various refactors to support partitioning the serf LAN pool (#11568) 2021-11-15 09:51:14 -06:00
operator_endpoint_oss.go re-run gofmt on 1.17 (#11579) 2021-11-16 12:04:01 -06:00
operator_endpoint_test.go Fix defaults for autopilot config update 2021-07-06 18:39:40 -04:00
prepared_query_endpoint.go fixing various bits of enterprise meta plumbing to be more correct (#10889) 2021-08-20 14:34:23 -05:00
prepared_query_endpoint_test.go
…
reload.go
…
remote_exec.go
…
remote_exec_test.go
…
retry_join.go agent: refactor the agent delegate interface to be partition friendly (#11429) 2021-10-26 15:08:55 -05:00
retry_join_test.go
…
service_checks_test.go
…
service_manager.go oss portion of ent #1069 (#10883) 2021-08-20 12:57:45 -04:00
service_manager_test.go Remove some usage of md5 from the system (#11491) 2021-11-04 13:07:54 -07:00
session_endpoint.go
…
session_endpoint_test.go
…
setup.go agent: move agent tls metric monitor to a more appropriate place 2021-10-27 16:26:09 -04:00
setup_oss.go re-run gofmt on 1.17 (#11579) 2021-11-16 12:04:01 -06:00
sidecar_service.go agent: ensure that most agent behavior correctly respects partition configuration (#10880) 2021-08-19 15:09:42 -05:00
sidecar_service_test.go agent: update proxy upstreams to inherit namespace from service (#10688) 2021-07-26 17:12:29 -04:00
signal_unix.go re-run gofmt on 1.17 (#11579) 2021-11-16 12:04:01 -06:00
signal_windows.go re-run gofmt on 1.17 (#11579) 2021-11-16 12:04:01 -06:00
snapshot_endpoint.go
…
snapshot_endpoint_test.go
…
status_endpoint.go
…
status_endpoint_test.go
…
streaming_test.go regenerate expired certs (#11462) 2021-11-01 11:40:16 -04:00
testagent.go testing: use the new freeport interfaces 2021-11-27 15:39:46 -05:00
testagent_test.go
…
translate_addr.go
…
txn_endpoint.go agent: ensure that most agent behavior correctly respects partition configuration (#10880) 2021-08-19 15:09:42 -05:00
txn_endpoint_test.go refactor session state store tables to use the new index pattern (#11525) 2021-11-08 16:20:50 -05:00
ui_endpoint.go structs: rename the last helper method. 2021-09-29 11:48:38 -04:00
ui_endpoint_oss_test.go re-run gofmt on 1.17 (#11579) 2021-11-16 12:04:01 -06:00
ui_endpoint_test.go ent->oss test fix (#10926) 2021-08-26 14:06:49 -04:00
user_event.go agent: ensure that most agent behavior correctly respects partition configuration (#10880) 2021-08-19 15:09:42 -05:00
user_event_test.go Update 4 non-acl tests that used the legacy ACL.Apply 2021-09-21 17:57:29 -04:00
util.go Remove some usage of md5 from the system (#11491) 2021-11-04 13:07:54 -07:00
util_test.go Remove some usage of md5 from the system (#11491) 2021-11-04 13:07:54 -07:00
watch_handler.go
…
watch_handler_test.go
…