0f29543315
When this test flakes sometimes this happens:
--- FAIL: TestCoordinate_Node (1.69s)
panic: interface conversion: interface {} is nil, not structs.Coordinates [recovered]
FAIL github.com/hashicorp/consul/agent 19.999s
Exit code: 1
panic: interface conversion: interface {} is nil, not structs.Coordinates [recovered]
panic: interface conversion: interface {} is nil, not structs.Coordinates
There is definitely a bug lurking, but the code seems to imply this can
only return nil on 404. The tests previously were not checking the
status code.
The underlying cause of the flake is unknown, but this should turn the
failure into a more normal test failure.
423 lines
11 KiB
Go
423 lines
11 KiB
Go
package agent
|
|
|
|
import (
|
|
"fmt"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/hashicorp/consul/acl"
|
|
"github.com/hashicorp/consul/agent/structs"
|
|
"github.com/hashicorp/consul/sdk/testutil/retry"
|
|
"github.com/hashicorp/consul/testrpc"
|
|
"github.com/hashicorp/serf/coordinate"
|
|
)
|
|
|
|
func TestCoordinate_Disabled_Response(t *testing.T) {
|
|
t.Parallel()
|
|
a := NewTestAgent(t, t.Name(), `
|
|
disable_coordinates = true
|
|
`)
|
|
defer a.Shutdown()
|
|
testrpc.WaitForTestAgent(t, a.RPC, "dc1")
|
|
|
|
tests := []func(resp http.ResponseWriter, req *http.Request) (interface{}, error){
|
|
a.srv.CoordinateDatacenters,
|
|
a.srv.CoordinateNodes,
|
|
a.srv.CoordinateNode,
|
|
a.srv.CoordinateUpdate,
|
|
}
|
|
for i, tt := range tests {
|
|
t.Run(fmt.Sprintf("%d", i), func(t *testing.T) {
|
|
req, _ := http.NewRequest("PUT", "/should/not/care", nil)
|
|
resp := httptest.NewRecorder()
|
|
obj, err := tt(resp, req)
|
|
if err != nil {
|
|
t.Fatalf("err: %v", err)
|
|
}
|
|
if obj != nil {
|
|
t.Fatalf("bad: %#v", obj)
|
|
}
|
|
if got, want := resp.Code, http.StatusUnauthorized; got != want {
|
|
t.Fatalf("got %d want %d", got, want)
|
|
}
|
|
if !strings.Contains(resp.Body.String(), "Coordinate support disabled") {
|
|
t.Fatalf("bad: %#v", resp)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestCoordinate_Datacenters(t *testing.T) {
|
|
t.Parallel()
|
|
a := NewTestAgent(t, t.Name(), "")
|
|
defer a.Shutdown()
|
|
testrpc.WaitForTestAgent(t, a.RPC, "dc1")
|
|
|
|
req, _ := http.NewRequest("GET", "/v1/coordinate/datacenters", nil)
|
|
resp := httptest.NewRecorder()
|
|
obj, err := a.srv.CoordinateDatacenters(resp, req)
|
|
if err != nil {
|
|
t.Fatalf("err: %v", err)
|
|
}
|
|
|
|
if resp.Code != http.StatusOK {
|
|
t.Fatalf("bad: %v", resp.Code)
|
|
}
|
|
|
|
maps := obj.([]structs.DatacenterMap)
|
|
if len(maps) != 1 ||
|
|
maps[0].Datacenter != "dc1" ||
|
|
len(maps[0].Coordinates) != 1 ||
|
|
maps[0].Coordinates[0].Node != a.Config.NodeName {
|
|
t.Fatalf("bad: %v", maps)
|
|
}
|
|
}
|
|
|
|
func TestCoordinate_Nodes(t *testing.T) {
|
|
t.Parallel()
|
|
a := NewTestAgent(t, t.Name(), "")
|
|
defer a.Shutdown()
|
|
testrpc.WaitForTestAgent(t, a.RPC, "dc1")
|
|
|
|
// Make sure an empty list is non-nil.
|
|
req, _ := http.NewRequest("GET", "/v1/coordinate/nodes?dc=dc1", nil)
|
|
resp := httptest.NewRecorder()
|
|
retry.Run(t, func(r *retry.R) {
|
|
obj, err := a.srv.CoordinateNodes(resp, req)
|
|
if err != nil {
|
|
r.Fatalf("err: %v", err)
|
|
}
|
|
|
|
if resp.Code != http.StatusOK {
|
|
r.Fatalf("bad: %v", resp.Code)
|
|
}
|
|
|
|
// Check that coordinates are empty before registering a node
|
|
coordinates, ok := obj.(structs.Coordinates)
|
|
if !ok {
|
|
r.Fatalf("expected: structs.Coordinates, received: %+v", obj)
|
|
}
|
|
|
|
if len(coordinates) != 0 {
|
|
r.Fatalf("coordinates should be empty, received: %v", coordinates)
|
|
}
|
|
})
|
|
|
|
// Register the nodes.
|
|
nodes := []string{"foo", "bar"}
|
|
for _, node := range nodes {
|
|
req := structs.RegisterRequest{
|
|
Datacenter: "dc1",
|
|
Node: node,
|
|
Address: "127.0.0.1",
|
|
}
|
|
var reply struct{}
|
|
if err := a.RPC("Catalog.Register", &req, &reply); err != nil {
|
|
t.Fatalf("err: %s", err)
|
|
}
|
|
}
|
|
|
|
// Send some coordinates for a few nodes, waiting a little while for the
|
|
// batch update to run.
|
|
arg1 := structs.CoordinateUpdateRequest{
|
|
Datacenter: "dc1",
|
|
Node: "foo",
|
|
Segment: "alpha",
|
|
Coord: coordinate.NewCoordinate(coordinate.DefaultConfig()),
|
|
}
|
|
var out struct{}
|
|
if err := a.RPC("Coordinate.Update", &arg1, &out); err != nil {
|
|
t.Fatalf("err: %v", err)
|
|
}
|
|
|
|
arg2 := structs.CoordinateUpdateRequest{
|
|
Datacenter: "dc1",
|
|
Node: "bar",
|
|
Coord: coordinate.NewCoordinate(coordinate.DefaultConfig()),
|
|
}
|
|
if err := a.RPC("Coordinate.Update", &arg2, &out); err != nil {
|
|
t.Fatalf("err: %v", err)
|
|
}
|
|
time.Sleep(300 * time.Millisecond)
|
|
|
|
// Query back and check the nodes are present and sorted correctly.
|
|
req, _ = http.NewRequest("GET", "/v1/coordinate/nodes?dc=dc1", nil)
|
|
resp = httptest.NewRecorder()
|
|
retry.Run(t, func(r *retry.R) {
|
|
obj, err := a.srv.CoordinateNodes(resp, req)
|
|
if err != nil {
|
|
r.Fatalf("err: %v", err)
|
|
}
|
|
|
|
if resp.Code != http.StatusOK {
|
|
r.Fatalf("bad: %v", resp.Code)
|
|
}
|
|
|
|
coordinates, ok := obj.(structs.Coordinates)
|
|
if !ok {
|
|
r.Fatalf("expected: structs.Coordinates, received: %+v", obj)
|
|
}
|
|
if len(coordinates) != 2 ||
|
|
coordinates[0].Node != "bar" ||
|
|
coordinates[1].Node != "foo" {
|
|
r.Fatalf("expected: bar, foo recieved: %v", coordinates)
|
|
}
|
|
})
|
|
// Filter on a nonexistent node segment
|
|
req, _ = http.NewRequest("GET", "/v1/coordinate/nodes?segment=nope", nil)
|
|
resp = httptest.NewRecorder()
|
|
retry.Run(t, func(r *retry.R) {
|
|
obj, err := a.srv.CoordinateNodes(resp, req)
|
|
if err != nil {
|
|
r.Fatalf("err: %v", err)
|
|
}
|
|
|
|
if resp.Code != http.StatusOK {
|
|
r.Fatalf("bad: %v", resp.Code)
|
|
}
|
|
|
|
coordinates, ok := obj.(structs.Coordinates)
|
|
if !ok {
|
|
r.Fatalf("expected: structs.Coordinates, received: %+v", obj)
|
|
}
|
|
if len(coordinates) != 0 {
|
|
r.Fatalf("coordinates should be empty, received: %v", coordinates)
|
|
}
|
|
})
|
|
// Filter on a real node segment
|
|
req, _ = http.NewRequest("GET", "/v1/coordinate/nodes?segment=alpha", nil)
|
|
resp = httptest.NewRecorder()
|
|
retry.Run(t, func(r *retry.R) {
|
|
obj, err := a.srv.CoordinateNodes(resp, req)
|
|
if err != nil {
|
|
r.Fatalf("err: %v", err)
|
|
}
|
|
|
|
if resp.Code != http.StatusOK {
|
|
r.Fatalf("bad: %v", resp.Code)
|
|
}
|
|
|
|
coordinates, ok := obj.(structs.Coordinates)
|
|
if !ok {
|
|
r.Fatalf("expected: structs.Coordinates, received: %+v", obj)
|
|
}
|
|
if len(coordinates) != 1 || coordinates[0].Node != "foo" {
|
|
r.Fatalf("expected: foo received: %v", coordinates)
|
|
}
|
|
})
|
|
// Make sure the empty filter works
|
|
req, _ = http.NewRequest("GET", "/v1/coordinate/nodes?segment=", nil)
|
|
resp = httptest.NewRecorder()
|
|
retry.Run(t, func(r *retry.R) {
|
|
obj, err := a.srv.CoordinateNodes(resp, req)
|
|
if err != nil {
|
|
r.Fatalf("err: %v", err)
|
|
}
|
|
|
|
coordinates, ok := obj.(structs.Coordinates)
|
|
if !ok {
|
|
r.Fatalf("expected: structs.Coordinates, received: %+v", obj)
|
|
}
|
|
if len(coordinates) != 1 || coordinates[0].Node != "bar" {
|
|
r.Fatalf("expected: bar received: %v", coordinates)
|
|
}
|
|
})
|
|
}
|
|
|
|
func TestCoordinate_Node(t *testing.T) {
|
|
t.Parallel()
|
|
a := NewTestAgent(t, t.Name(), "")
|
|
defer a.Shutdown()
|
|
testrpc.WaitForTestAgent(t, a.RPC, "dc1")
|
|
|
|
// Make sure we get a 404 with no coordinates.
|
|
req, _ := http.NewRequest("GET", "/v1/coordinate/node/foo?dc=dc1", nil)
|
|
resp := httptest.NewRecorder()
|
|
obj, err := a.srv.CoordinateNode(resp, req)
|
|
if err != nil {
|
|
t.Fatalf("err: %v", err)
|
|
}
|
|
|
|
if resp.Code != http.StatusNotFound {
|
|
t.Fatalf("bad: %v", resp.Code)
|
|
}
|
|
|
|
// Register the nodes.
|
|
nodes := []string{"foo", "bar"}
|
|
for _, node := range nodes {
|
|
req := structs.RegisterRequest{
|
|
Datacenter: "dc1",
|
|
Node: node,
|
|
Address: "127.0.0.1",
|
|
}
|
|
var reply struct{}
|
|
if err := a.RPC("Catalog.Register", &req, &reply); err != nil {
|
|
t.Fatalf("err: %s", err)
|
|
}
|
|
}
|
|
|
|
// Send some coordinates for a few nodes, waiting a little while for the
|
|
// batch update to run.
|
|
arg1 := structs.CoordinateUpdateRequest{
|
|
Datacenter: "dc1",
|
|
Node: "foo",
|
|
Segment: "alpha",
|
|
Coord: coordinate.NewCoordinate(coordinate.DefaultConfig()),
|
|
}
|
|
var out struct{}
|
|
if err := a.RPC("Coordinate.Update", &arg1, &out); err != nil {
|
|
t.Fatalf("err: %v", err)
|
|
}
|
|
|
|
arg2 := structs.CoordinateUpdateRequest{
|
|
Datacenter: "dc1",
|
|
Node: "bar",
|
|
Coord: coordinate.NewCoordinate(coordinate.DefaultConfig()),
|
|
}
|
|
if err := a.RPC("Coordinate.Update", &arg2, &out); err != nil {
|
|
t.Fatalf("err: %v", err)
|
|
}
|
|
time.Sleep(300 * time.Millisecond)
|
|
|
|
// Query back and check the nodes are present.
|
|
req, _ = http.NewRequest("GET", "/v1/coordinate/node/foo?dc=dc1", nil)
|
|
resp = httptest.NewRecorder()
|
|
obj, err = a.srv.CoordinateNode(resp, req)
|
|
if err != nil {
|
|
t.Fatalf("err: %v", err)
|
|
}
|
|
|
|
if resp.Code != http.StatusOK {
|
|
t.Fatalf("bad: %v", resp.Code)
|
|
}
|
|
|
|
coordinates := obj.(structs.Coordinates)
|
|
if len(coordinates) != 1 ||
|
|
coordinates[0].Node != "foo" {
|
|
t.Fatalf("bad: %v", coordinates)
|
|
}
|
|
|
|
// Filter on a nonexistent node segment
|
|
req, _ = http.NewRequest("GET", "/v1/coordinate/node/foo?segment=nope", nil)
|
|
resp = httptest.NewRecorder()
|
|
obj, err = a.srv.CoordinateNode(resp, req)
|
|
if err != nil {
|
|
t.Fatalf("err: %v", err)
|
|
}
|
|
if resp.Code != http.StatusNotFound {
|
|
t.Fatalf("bad: %v", resp.Code)
|
|
}
|
|
|
|
// Filter on a real node segment
|
|
req, _ = http.NewRequest("GET", "/v1/coordinate/node/foo?segment=alpha", nil)
|
|
resp = httptest.NewRecorder()
|
|
obj, err = a.srv.CoordinateNode(resp, req)
|
|
if err != nil {
|
|
t.Fatalf("err: %v", err)
|
|
}
|
|
|
|
if resp.Code != http.StatusOK {
|
|
t.Fatalf("bad: %v", resp.Code)
|
|
}
|
|
|
|
coordinates = obj.(structs.Coordinates)
|
|
if len(coordinates) != 1 || coordinates[0].Node != "foo" {
|
|
t.Fatalf("bad: %v", coordinates)
|
|
}
|
|
|
|
// Make sure the empty filter works
|
|
req, _ = http.NewRequest("GET", "/v1/coordinate/node/foo?segment=", nil)
|
|
resp = httptest.NewRecorder()
|
|
obj, err = a.srv.CoordinateNode(resp, req)
|
|
if err != nil {
|
|
t.Fatalf("err: %v", err)
|
|
}
|
|
if resp.Code != http.StatusNotFound {
|
|
t.Fatalf("bad: %v", resp.Code)
|
|
}
|
|
}
|
|
|
|
func TestCoordinate_Update(t *testing.T) {
|
|
t.Parallel()
|
|
a := NewTestAgent(t, t.Name(), "")
|
|
defer a.Shutdown()
|
|
testrpc.WaitForTestAgent(t, a.RPC, "dc1")
|
|
|
|
// Register the node.
|
|
reg := structs.RegisterRequest{
|
|
Datacenter: "dc1",
|
|
Node: "foo",
|
|
Address: "127.0.0.1",
|
|
}
|
|
var reply struct{}
|
|
if err := a.RPC("Catalog.Register", ®, &reply); err != nil {
|
|
t.Fatalf("err: %s", err)
|
|
}
|
|
|
|
// Update the coordinates and wait for it to complete.
|
|
coord := coordinate.NewCoordinate(coordinate.DefaultConfig())
|
|
coord.Height = -5.0
|
|
body := structs.CoordinateUpdateRequest{
|
|
Datacenter: "dc1",
|
|
Node: "foo",
|
|
Coord: coord,
|
|
}
|
|
req, _ := http.NewRequest("PUT", "/v1/coordinate/update", jsonReader(body))
|
|
resp := httptest.NewRecorder()
|
|
_, err := a.srv.CoordinateUpdate(resp, req)
|
|
if err != nil {
|
|
t.Fatalf("err: %v", err)
|
|
}
|
|
|
|
if resp.Code != http.StatusOK {
|
|
t.Fatalf("bad: %v", resp.Code)
|
|
}
|
|
|
|
time.Sleep(300 * time.Millisecond)
|
|
|
|
// Query back and check the coordinates are present.
|
|
args := structs.NodeSpecificRequest{Node: "foo", Datacenter: "dc1"}
|
|
var coords structs.IndexedCoordinates
|
|
if err := a.RPC("Coordinate.Node", &args, &coords); err != nil {
|
|
t.Fatalf("err: %s", err)
|
|
}
|
|
|
|
coordinates := coords.Coordinates
|
|
if len(coordinates) != 1 ||
|
|
coordinates[0].Node != "foo" {
|
|
t.Fatalf("bad: %v", coordinates)
|
|
}
|
|
}
|
|
|
|
func TestCoordinate_Update_ACLDeny(t *testing.T) {
|
|
t.Parallel()
|
|
a := NewTestAgent(t, t.Name(), TestACLConfig())
|
|
defer a.Shutdown()
|
|
testrpc.WaitForLeader(t, a.RPC, "dc1")
|
|
|
|
coord := coordinate.NewCoordinate(coordinate.DefaultConfig())
|
|
coord.Height = -5.0
|
|
body := structs.CoordinateUpdateRequest{
|
|
Datacenter: "dc1",
|
|
Node: "foo",
|
|
Coord: coord,
|
|
}
|
|
|
|
t.Run("no token", func(t *testing.T) {
|
|
req, _ := http.NewRequest("PUT", "/v1/coordinate/update", jsonReader(body))
|
|
if _, err := a.srv.CoordinateUpdate(nil, req); !acl.IsErrPermissionDenied(err) {
|
|
t.Fatalf("err: %v", err)
|
|
}
|
|
})
|
|
|
|
t.Run("valid token", func(t *testing.T) {
|
|
req, _ := http.NewRequest("PUT", "/v1/coordinate/update?token=root", jsonReader(body))
|
|
if _, err := a.srv.CoordinateUpdate(nil, req); err != nil {
|
|
t.Fatalf("err: %v", err)
|
|
}
|
|
})
|
|
}
|