Frank Schroeder
dcb70f7def
Revert "config: document http options"
...
This reverts commit 5f598574483e59af377ae447857d40872563ac87.
2017-10-23 10:08:31 +02:00
Frank Schroeder
1ce9c1ba45
Revert "config: document dns options"
...
This reverts commit 5e57e9273ea6e27eb79ed531189fd3c69e19c7b2.
2017-10-23 10:08:31 +02:00
Frank Schroeder
3638b2932d
Revert "config: document autopilot options"
...
This reverts commit 7685ef409c9340227e3969a86e0bfa627eafdd0f.
2017-10-23 10:08:31 +02:00
Frank Schroeder
32c8d7e0db
Revert "config: document acl options"
...
This reverts commit 7396bd31fd1c35347d0c88284ea358bfbd9ca948.
2017-10-23 10:08:31 +02:00
Frank Schroeder
83bfe0d223
Revert "config: document config options"
...
This reverts commit a38c69d7844a4e4a9d54051470977c7446fc8e57.
2017-10-23 10:08:31 +02:00
Frank Schroeder
ff42a00ef1
Revert "config: document more acl options"
...
This reverts commit 2682ce0b825528f379487cbd11c2c2a321fd94e8.
2017-10-23 10:08:31 +02:00
Frank Schroeder
6ae5c0594a
Revert "config: document more config options"
...
This reverts commit bf81cdea6eb90ae099201c545910780ccd020540.
2017-10-23 10:08:31 +02:00
Frank Schroeder
2d96f700c0
Revert "config: document more config options"
...
This reverts commit 9864609201f333cd90af9535e2e4d4c7c1e65c4a.
2017-10-23 10:08:31 +02:00
Frank Schroeder
bd72f3676d
Revert "config: document remaining config options"
...
This reverts commit 0ed4561f12cf52a44ab1f1887d4f4bfd27df77f4.
2017-10-23 10:08:31 +02:00
Frank Schroeder
64ac9f4f42
Revert "config: address review comments"
...
This reverts commit f6e9ad99ec6d230c1eb7f655d2a83e5a4e33807d.
2017-10-23 10:08:31 +02:00
Frank Schroeder
c5c586c7f1
Revert "fix go vet issue"
...
This reverts commit 078e50b635846920a17a3b06c678b2b63b40677a.
2017-10-23 10:00:26 +02:00
Frank Schröder
b580f7a533
Revert "config: rename test struct field to args"
...
This reverts commit f2a291a4704c9954c441567860ca740ac0f58308.
2017-10-23 09:58:37 +02:00
Frank Schröder
0f0b510f37
Revert "config: return error on extra command line arguments ( #3397 )"
...
This reverts commit ce935cef55f7298e85843b3ca17ad13415e40e0b.
2017-10-23 09:58:37 +02:00
Frank Schroeder
ef3108abc3
fix go vet issue
2017-10-23 08:13:52 +02:00
Frank Schroeder
24689c4f5e
config: return error on extra command line arguments ( #3397 )
...
The `consul agent` command was ignoring extra command line arguments
which can lead to confusion when the user has for example forgotten to
add a dash in front of an argument or is not using an `=` when setting
boolean flags to `true`. `-bootstrap true` is not the same as
`-bootstrap=true`, for example.
Since all command line flags are known and we don't expect unparsed
arguments we can return an error. However, this may make it slightly
more difficult in the future if we ever wanted to have these kinds of
arguments.
Fixes #3397
2017-10-23 08:08:09 +02:00
Frank Schroeder
c8ed3044de
config: rename test struct field to args
2017-10-23 08:08:09 +02:00
Frank Schroeder
88a1f3aa53
config: address review comments
2017-10-23 08:06:26 +02:00
Frank Schroeder
97277de196
config: document remaining config options
2017-10-23 08:06:26 +02:00
Frank Schroeder
638bc0e0ac
config: document more config options
2017-10-23 08:06:26 +02:00
Frank Schroeder
f326eae23e
config: document more config options
2017-10-23 08:06:26 +02:00
Frank Schroeder
6332f4d6a7
config: document more acl options
2017-10-23 08:06:26 +02:00
Frank Schroeder
61c8ee564a
config: document config options
2017-10-23 08:06:26 +02:00
Frank Schroeder
71112a6510
config: document acl options
2017-10-23 08:06:26 +02:00
Frank Schroeder
e00869647c
config: document autopilot options
2017-10-23 08:06:26 +02:00
Frank Schroeder
05c1038d58
config: document dns options
2017-10-23 08:06:26 +02:00
Frank Schroeder
a17d711b39
config: document http options
2017-10-23 08:06:26 +02:00
Frank Schroeder
f95b8f5060
config: document telemetry options
2017-10-23 08:06:26 +02:00
Frank Schroeder
39dddd433e
local state: remove stale comment
2017-10-23 08:03:18 +02:00
Frank Schroeder
779bf04aa3
local state: make test more robust
2017-10-23 08:03:18 +02:00
Frank Schroeder
e16c8f3982
local state: clone check to avoid side effect
2017-10-23 08:03:18 +02:00
Frank Schroeder
f1028d2486
local state: use synchronized access to internal maps
2017-10-23 08:03:18 +02:00
Frank Schroeder
606e13a569
ae: do not trigger on Resume while holding the lock
2017-10-23 08:03:18 +02:00
Frank Schroeder
82e9494f7f
ae: add remaining test cases
2017-10-23 08:03:18 +02:00
Frank Schroeder
cf6e6c72ac
ae: refactor StateSyncer to state machine for better testing
2017-10-23 08:03:18 +02:00
Frank Schroeder
ba8cb5e3d0
ae: add test that we run a full before a partial sync
2017-10-23 08:03:18 +02:00
Frank Schroeder
0d73333c8e
ae: make control flow more explicit
2017-10-23 08:03:18 +02:00
Frank Schroeder
0cfe0a42f1
ae: fix typo in constructor name
2017-10-23 08:03:18 +02:00
Frank Schroeder
25ee03e165
ae: add test for resume triggering SyncChanges
2017-10-23 08:03:18 +02:00
Frank Schroeder
f61ad4efcd
ae: add test for ifNotPausedRun
2017-10-23 08:03:18 +02:00
Frank Schroeder
c2ab582d47
ae: make stagger function pluggable for testing
2017-10-23 08:03:18 +02:00
Frank Schroeder
f352952fb3
ae: restore previous pause/resume behavior
2017-10-23 08:03:18 +02:00
Frank Schroeder
c1badf1034
ae: ensure that syncs are blocked when paused
2017-10-23 08:03:18 +02:00
Frank Schroeder
a4d03797ae
local state: rename Add{Check,Service}State to Set{Check,Service}State
2017-10-23 08:03:18 +02:00
Frank Schroeder
7414fe0a2a
local state: move Metadata methods together
2017-10-23 08:03:18 +02:00
Frank Schroeder
3e953f67da
local state: update documentation of updateSyncState
2017-10-23 08:03:18 +02:00
Frank Schroeder
ecea35d955
local state: update comments
2017-10-23 08:03:18 +02:00
Frank Schroeder
40e17f9f01
local state: address review comments
...
* move non-blocking notification mechanism into ae.Trigger
* move Pause/Resume into separate type
2017-10-23 08:03:18 +02:00
Frank Schroeder
cfc8bd092f
local state: refactor TestAgentAntiEntropy_EnableTagOverride
...
Make intent clearer by being more explicit and adding some comments.
Use verify.Values to compare service entries.
2017-10-23 08:03:18 +02:00
Frank Schroeder
b288c1eb9b
local state: fix TestAgentAntiEntropy_EnableTagOverride
...
The test had a race condition where it relied on the first service to be
synced to the remote catalog which sometimes failed.
2017-10-23 08:03:18 +02:00
Frank Schroeder
71e4d7cd1c
local state: rename tests
2017-10-23 08:03:18 +02:00