open-consul

Commit Graph

Author	SHA1	Message	Date
R.B. Boyer	83bf7ab3ff	re-run gofmt on 1.17 (#11579 ) This should let freshly recompiled golangci-lint binaries using Go 1.17 pass 'make lint'	2021-11-16 12:04:01 -06:00
Pierre Souchay	3b5e72913e	config: validate system limits against limits.http_max_conns_per_client (#7434 ) I spent some time today on my local Mac to figure out why Consul 1.6.3+ was not accepting limits.http_max_conns_per_client. This adds an explicit check on number of file descriptors to be sure it might work (this is no guarantee as if many clients are reaching the agent, it might consume even more file descriptors) Anyway, many users are fighting with RLIMIT_NOFILE, having a clear message would allow them to figure out what to fix. Example of message (reload or start): ``` 2020-03-11T16:38:37.062+0100 [ERROR] agent: Error starting agent: error="system allows a max of 512 file descriptors, but limits.http_max_conns_per_client: 8192 needs at least 8212" ```	2020-04-02 09:22:17 +02:00

Author

SHA1

Message

Date

R.B. Boyer

83bf7ab3ff

re-run gofmt on 1.17 (#11579 )

This should let freshly recompiled golangci-lint binaries using Go 1.17
pass 'make lint'

2021-11-16 12:04:01 -06:00

Pierre Souchay

3b5e72913e

config: validate system limits against limits.http_max_conns_per_client (#7434 )

I spent some time today on my local Mac to figure out why Consul 1.6.3+
was not accepting limits.http_max_conns_per_client.

This adds an explicit check on number of file descriptors to be sure
it might work (this is no guarantee as if many clients are reaching
the agent, it might consume even more file descriptors)

Anyway, many users are fighting with RLIMIT_NOFILE, having a clear
message would allow them to figure out what to fix.

Example of message (reload or start):

```
2020-03-11T16:38:37.062+0100 [ERROR] agent: Error starting agent: error="system allows a max of 512 file descriptors, but limits.http_max_conns_per_client: 8192 needs at least 8212"
```

2020-04-02 09:22:17 +02:00

2 Commits