Preetha Appan
3c4363389e
Fix KV CLI subcommands to build help string in constructor
2017-10-18 00:08:45 +02:00
Preetha Appan
75ec8a29a3
Fix Keyring and keygen commands to build help string in constructor
2017-10-18 00:08:45 +02:00
Preetha Appan
b8dd539037
Fix join command to build help string in constructor
2017-10-18 00:08:45 +02:00
Preetha Appan
0e1ee70a5e
Fix up info and forceleave to build help string in constructor
2017-10-18 00:08:45 +02:00
Preetha Appan
95053297a9
s/initFlags/init/g
2017-10-18 00:08:45 +02:00
Preetha Appan
0cb1c92977
Fix exec and event commands to build help string in constructor
2017-10-18 00:08:45 +02:00
Preetha Appan
3bd4b738c0
Fix up catalog list services to build help string in constructor
2017-10-18 00:08:45 +02:00
Preetha Appan
8761232b2a
Fix up list datacenters to build help string in constructor
2017-10-18 00:08:45 +02:00
Preetha Appan
5473dbc5a4
Fix tests by calling initFlags for each test case to reset state.
2017-10-18 00:08:45 +02:00
Preetha Appan
75ecc6a86e
Better name for usage string and moving constant definition down
2017-10-18 00:08:45 +02:00
Preetha Appan
7898780106
Construct the help string in constructor using helper function.
2017-10-18 00:08:45 +02:00
Frank Schroeder
9825b6709a
commands: move catalog list services to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
33a4e997b4
commands: move catalog list nodes command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
cfd110395b
commands: move catalog list datacenters command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
bcf53b98d1
commands: move catalog command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
5d75449419
commands: move leave command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
ffb747a744
commands: move force-leave command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
41f13de7f5
commands: move keyring command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
b1dac89b95
commands: move kv put command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
e50c8d8f73
commands: move kv get command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
19f2dab416
commands: move kv import command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
3f0c61666d
commands: move export entry struct to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
215cda4775
commands: move kv export command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
926aa72246
commands: move kv delete command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
50f039191d
commands: move kv command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
bd825687dd
commands: move keygen command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
74cf5c1c2c
commands: move info command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
c1c883957f
commands: move rExec helper to bottom
2017-10-18 00:08:45 +02:00
Frank Schroeder
8c7f013ae1
commands: move exec command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
ad50e2a410
commands: move event command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
dc3c722b2c
commands: move join command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
8880ae714b
commands: move validate command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
e65bd2a268
commands: move flag handling into flags pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
7568a19433
config: refactor commands to print help for flags ( #3536 )
...
This patch refactors the commands that use the mitchellh/cli library to
populate the command line flag set in both the Run() and the Help()
method. Earlier versions of the mitchellh/cli library relied on the
Run() method to populuate the flagset for generating the usage screen.
This has changed in later versions and was previously solved with a
small monkey patch to the library to restore the old behavior.
However, this makes upgrading the library difficult since the patch has
to be restored every time.
This patch addresses this by moving the command line flags into an
initFlags() method where appropriate and also moving all variables for
the flags from the Run() method into the command itself.
Fixes #3536
2017-10-18 00:08:45 +02:00
Ryan Slade
6f05ea91a3
Replace time.Now().Sub(x) with time.Since(x)
2017-10-17 20:38:24 +02:00
James Phillips
e9670761f9
Cleans up some drift between the OSS and Enterprise trees.
2017-10-11 15:53:07 -07:00
Frank Schroeder
db016a0c8d
command: show full help text on usage
2017-10-05 18:17:54 +02:00
Frank Schroeder
2320836d7f
command: do not merge flags in-place
2017-10-05 18:08:35 +02:00
Frank Schroeder
56ebd5b30f
command: simplify duplicate code
2017-10-05 18:08:35 +02:00
Frank Schroeder
3028d52158
command: drop hidden flags from base command
2017-10-05 18:08:35 +02:00
Frank Schroeder
13266a2e65
command: drop unused hidden flags for 'validate'
2017-10-05 18:08:35 +02:00
Frank Schroeder
7182829f15
command: drop legacy 'operator raft' tests
2017-10-05 17:56:16 +02:00
Frank Schroeder
a4be9e2e67
command: simplify 'operator raft'
...
The cli library can handle subcommands. Therefore, most of the code is
no longer necessary.
2017-10-05 17:40:57 +02:00
Frank Schroeder
cac55a1e80
command: don't show confusing error on usage output
2017-10-05 17:29:45 +02:00
Frank Schroeder
7bab8d3eb7
command: drop deprecated 'configtest' command
...
'configtest' has been replaced with 'validate'
2017-10-05 17:22:34 +02:00
Kyle Havlovitz
dde743700f
Merge pull request #3535 from hashicorp/metric-docs
...
Update metric names and add a legacy config flag
2017-10-04 17:39:16 -07:00
Kyle Havlovitz
be04bfed34
Clean up subprocess handling and make shell use optional ( #3509 )
...
* Clean up handling of subprocesses and make using a shell optional
* Update docs for subprocess changes
* Fix tests for new subprocess behavior
* More cleanup of subprocesses
* Minor adjustments and cleanup for subprocess logic
* Makes the watch handler reload test use the new path.
* Adds check tests for new args path, and updates existing tests to use new path.
* Adds support for script args in Docker checks.
* Fixes the sanitize unit test.
* Adds panic for unknown watch type, and reverts back to Run().
* Adds shell option back to consul lock command.
* Adds shell option back to consul exec command.
* Adds shell back into consul watch command.
* Refactors signal forwarding and makes Windows-friendly.
* Adds a clarifying comment.
* Changes error wording to a warning.
* Scopes signals to interrupt and kill.
This avoids us trying to send SIGCHILD to the dead process.
* Adds an error for shell=false for consul exec.
* Adds notes about the deprecated script and handler fields.
* De-nests an if statement.
2017-10-04 16:48:00 -07:00
Kyle Havlovitz
0063516e5e
Update metric names and add a legacy config flag
2017-10-04 16:43:27 -07:00
Kyle Havlovitz
624be65d35
Split BaseCommand http config into a separate function
2017-09-29 12:26:14 -07:00
Kyle Havlovitz
8403a98ea7
Add base command option for hiding generated help for normal args
2017-09-28 18:43:28 -07:00