luxolus
/
open-consul
2
0
Fork 0
Code Issues 1 Pull Requests Packages Releases Wiki Activity
14,119 Commits 1 Branch 1 Tag 358 MiB
Commit Graph

4 Commits

Author SHA1 Message Date
Daniel Nephin 8a68c6d517 lib/retry: allow jitter to exceed max wait. 
I changed this in https://github.com/hashicorp/consul/pull/8802#pullrequestreview-500779357 because
exceeding the MaxWait seemed wrong, but as other have pointed out, that behaviour is probably correct.

When multiple waiters hit the max value, we don't want them to converge, so restore the behaviour of
allowing jitter to exceed max, and document it.
 2021-04-07 18:33:11 -04:00
Daniel Nephin 40aac46cf4 lib/retry: Refactor to reduce the interface surface 
Reduce Jitter to one function

Rename NewRetryWaiter

Fix a bug in calculateWait where maxWait was applied before jitter, which would make it
possible to wait longer than maxWait.
 2020-10-04 18:12:42 -04:00
Daniel Nephin 7d82b21206 lib/retry: export fields 
The fields are only ever read by Waiter, and
setting the fields makes the calling code read much better without
having to create a bunch of constants that only ever get used once.
 2020-10-04 17:43:02 -04:00
Daniel Nephin 0c7f9c72d7 lib/retry: extract a new package from lib 2020-10-04 17:43:01 -04:00
Renamed from lib/retry.go (Browse further)