open-consul

Commit Graph

Author	SHA1	Message	Date
Matt Keeler	c3e7d689b7	Refactor the agentpb package (#8362 ) First move the whole thing to the top-level proto package name. Secondly change some things around internally to have sub-packages.	2020-07-23 11:24:20 -04:00
Matt Keeler	5b83f589da	Expand the QueryOptions and QueryMeta interfaces (#6545 ) In a previous PR I made it so that we had interfaces that would work enough to allow blockingQueries to work. However to complete this we need all fields to be settable and gettable. Notes: • If Go ever gets contracts/generics then we could get rid of all the Getters/Setters • protoc / protoc-gen-gogo are going to generate all the getters for us. • I copied all the getters/setters from the protobuf funcs into agent/structs/protobuf_compat.go • Also added JSON marshaling funcs that use jsonpb for protobuf types.	2019-09-26 09:55:02 -04:00

Author

SHA1

Message

Date

Matt Keeler

c3e7d689b7

Refactor the agentpb package (#8362 )

First move the whole thing to the top-level proto package name.

Secondly change some things around internally to have sub-packages.

2020-07-23 11:24:20 -04:00

Matt Keeler

5b83f589da

Expand the QueryOptions and QueryMeta interfaces (#6545 )

In a previous PR I made it so that we had interfaces that would work enough to allow blockingQueries to work. However to complete this we need all fields to be settable and gettable.

Notes:
   • If Go ever gets contracts/generics then we could get rid of all the Getters/Setters
   • protoc / protoc-gen-gogo are going to generate all the getters for us.
   • I copied all the getters/setters from the protobuf funcs into agent/structs/protobuf_compat.go
   • Also added JSON marshaling funcs that use jsonpb for protobuf types.

2019-09-26 09:55:02 -04:00

2 Commits