Luke Kysow
17594a123e
peering: retry establishing connection more quickly on certain errors ( #13938 )
...
When we receive a FailedPrecondition error, retry that more quickly
because we expect it will resolve shortly. This is particularly
important in the context of Consul servers behind a load balancer
because when establishing a connection we have to retry until we
randomly land on a leader node.
The default retry backoff goes from 2s, 4s, 8s, etc. which can result in
very long delays quite quickly. Instead, this backoff retries in 8ms
five times, then goes exponentially from there: 16ms, 32ms, ... up to a
max of 8152ms.
2022-07-29 13:04:32 -07:00
Chris S. Kim
96c266becf
Ensure connections are closed before WaitGroup marked as done
...
The previous ordering of defers meant the listener's connWG could fire and wake up other goroutines before the connection closed. Unsure if this caused any real bugs but this commit should make the code more correct.
2022-07-29 09:29:13 -04:00
alex
74d79cc7e6
Merge pull request #13952 from hashicorp/sync-more-acl
...
sync more acl enforcement
2022-07-28 12:31:02 -07:00
Dhia Ayachi
09340a846c
inject gateway addons to destination clusters ( #13951 )
2022-07-28 15:17:35 -04:00
acpana
70e052f35f
sync more acl enforcement
...
sync w ent at 32756f7
Signed-off-by: acpana <8968914+acpana@users.noreply.github.com>
2022-07-28 12:01:52 -07:00
alex
08b94640bc
Merge pull request #13929 from hashicorp/fix-validation
...
[sync] fix empty partitions matching
2022-07-28 10:14:49 -07:00
Evan Culver
b60d4bd2d0
ci: Use correct branch name for 1.13 nightly test ( #13945 )
2022-07-28 12:49:15 -04:00
cskh
416a673c6c
fix (cli): import empty directory to kv ( #13939 )
...
* fix (cli): import empty directory to kv
- when import an empty directory like foo/, the import
command will remove the trailing /, making it a
non-directory key.
- This change fixes the bug by adding back the / if
the imported key is an directory
2022-07-28 10:54:25 -04:00
Jared Kirschner
8a7e60b10b
Merge pull request #13917 from hashicorp/docs/show-cli-cmd-options-before-general-options-2
...
docs: show CLI cmd-specific opts before general opts
2022-07-27 18:55:06 -04:00
Jared Kirschner
bb93a43475
docs: show CLI cmd-specific opts before general opts
...
Applied to all remaining CLI commands.
2022-07-27 15:50:51 -07:00
Ashwin Venkatesh
e4aaf467eb
Add peer counts to emitted metrics. ( #13930 )
2022-07-27 18:34:04 -04:00
Luke Kysow
a2290791b2
Merge pull request #13924 from hashicorp/lkysow/util-metric-peering
...
peering: don't track imported services/nodes in usage
2022-07-27 14:49:55 -07:00
acpana
778c796ec9
use EqualPartitions
...
Signed-off-by: acpana <8968914+acpana@users.noreply.github.com>
2022-07-27 14:48:30 -07:00
acpana
8042b3aeed
better fix
...
Signed-off-by: acpana <8968914+acpana@users.noreply.github.com>
2022-07-27 14:28:08 -07:00
Evan Culver
273bcbce5f
ci: Add nightly test workflow for 1.13, remove 1.10 ( #13927 )
...
Signed-off-by: Evan Culver <eculver@hashicorp.com>
2022-07-27 16:59:00 -04:00
acpana
b03467e3bd
sync w ent
...
Signed-off-by: acpana <8968914+acpana@users.noreply.github.com>
2022-07-27 11:41:39 -07:00
Chris S. Kim
213e985d17
Reduce arm64 flakes for TestConnectCA_ConfigurationSet_ChangeKeyConfig_Primary
...
There were 16 combinations of tests but 4 of them were duplicates since the default key type and bits were "ec" and 256. That entry was commented out to reduce the subtest count to 12.
testrpc.WaitForLeader was failing on arm64 environments; the cause is unknown but it might be due to the environment being flooded with parallel tests making RPC calls. The RPC polling+retry was replaced with a simpler check for leadership based on raft.
2022-07-27 13:54:34 -04:00
Chris S. Kim
c80ab10527
Retry checks for virtual IP metadata
2022-07-27 13:54:34 -04:00
Chris S. Kim
146dd93775
Sort slice of ServiceNames deterministically
2022-07-27 13:54:34 -04:00
Chris S. Kim
85dd506ecb
Remove unnecessary goroutine in flaky test
...
The watch is established in a background goroutine and the first assertion proves that the watcher is active so there is no reason for the update to happen in a racy goroutine.
Note that this does not completely remove the race condition as the first call to testGetConfigValTimeout could time out before a config is returned.
2022-07-27 13:54:34 -04:00
Luke Kysow
92c1f30359
peering: don't track imported services/nodes in usage
...
Services/nodes that are imported from other peers are stored in
state. We don't want to count those as part of our own cluster's usage.
2022-07-27 09:08:51 -07:00
cskh
f7858a1bda
chore: clarify the error message: service.service must not be empty ( #13907 )
...
- when register service using catalog endpoint, the key of service
name actually should be "service". Add this information to the
error message will help user to quickly fix in the request.
2022-07-27 10:16:46 -04:00
Jared Kirschner
39480deed0
Merge pull request #13914 from hashicorp/docs/remove-comparisons-from-ref-docs
...
docs: remove comparative info from ref docs site
2022-07-27 02:42:41 -04:00
Jared Kirschner
41f5cd2a37
Merge pull request #12903 from hashicorp/docs/show-cli-cmd-options-before-general-options
...
Docs: Show CLI command-specific options before general options
2022-07-27 02:18:04 -04:00
Jared Kirschner
13b3430a4e
docs: show CLI cmd-specific opts before general opts
...
Applied to a single command (acl auth-method create).
2022-07-26 22:38:44 -07:00
Jared Kirschner
d4a0dde9fd
docs: remove comparative info from ref docs site
2022-07-26 22:27:39 -07:00
Iryna Shustava
9bd8c0cd6d
docs: update helm reference docs ( #13910 )
2022-07-26 17:54:51 -06:00
cskh
ae04e2f048
chore: removed unused method AddService ( #13905 )
...
- This AddService is not used anywhere.
AddServiceWithChecks is place of AddService
- Test code is updated
2022-07-26 16:54:53 -04:00
Luke Kysow
0e10e5b765
Remove duplicate comment
2022-07-26 10:19:49 -07:00
John Cowen
4e5190245e
ui: Make peered intentions read-only ( #13814 )
...
* ui: Make peered intentions read-only
* Replace "" to undefined for SourcePeer so its the same as PeerName
* Fixup copypasta
* Ensure tests run with no peers
2022-07-26 17:29:37 +01:00
John Cowen
f41a754cbe
ui: Add peering establishment to the peer listing page ( #13813 )
...
* ui: Add peering establishment to the peer listing page
* Remove this.form.reset
2022-07-26 15:36:49 +01:00
Michael Klein
bf9045db69
ui: add deprecation worfklow addon ( #13877 )
...
* add ember-cli-deprecation-workflow
* Add deprecation workflow configuration
This will silence all deprecations by default reducing noise in the test
output significantly.
We can tackle deprecations now one by one but won't have to deal with
very verbose console logs anymore.
2022-07-26 15:01:09 +02:00
alex
0a66d0188d
peering: prevent peering in same partition ( #13851 )
...
Co-authored-by: Chris S. Kim <ckim@hashicorp.com>
2022-07-25 18:00:48 -07:00
trujillo-adam
0a4dff1763
Merge pull request #13897 from hashicorp/peering-metrics-docs-typo
...
fixed typo
2022-07-25 16:36:49 -07:00
Nitya Dhanushkodi
03ea6517c9
peering: remove validation that forces peering token server addresses to be an IP, allow hostname based addresses ( #13874 )
2022-07-25 16:33:47 -07:00
Jared Kirschner
5faa515c91
Merge pull request #12045 from hashicorp/partition-cli-acl-info-and-api-crossref
...
Partitions: Include ACL Info and API cross-ref for CLI Commands
2022-07-25 19:10:55 -04:00
Luke Kysow
5d4209eaf8
Rename receive to recv in tracker ( #13896 )
...
Because it's shorter
2022-07-25 16:08:03 -07:00
Iryna Shustava
2a8280a518
build: add a build job to build and push UBI images to DockerHub ( #13808 )
2022-07-25 15:43:24 -07:00
Jared Kirschner
641bf837b5
docs: remove unnecessary partition CLI cmd info
2022-07-25 15:31:39 -07:00
Jared Kirschner
dd81f6a76f
docs: adjust HTTP API/CLI characteristics tables
2022-07-25 15:31:39 -07:00
Jared Kirschner
dd12584981
docs: restructure partition API characteristics
...
The existing characteristics were restructured into a list.
The corresponding CLI command characteristic was added.
2022-07-25 15:31:38 -07:00
Jared Kirschner
44de9aaf4b
docs: remove partition subcommand usage headings
2022-07-25 15:31:38 -07:00
Jared Kirschner
13c91ddbdc
docs: add partition command characteristics
...
Characteristics include:
- Required ACL permissions
- Corresponding HTTP API endpoint
- (Lack of) support for blocking queries and agent caching
2022-07-25 15:31:38 -07:00
Jared Kirschner
d9d29ad0ed
docs: add partial for api/cli characteristics links
2022-07-25 15:31:38 -07:00
trujillo-adam
fb461995c0
fixed typo
2022-07-25 14:32:33 -07:00
Luke Kysow
a8ae88ec59
peering: read endpoints can now return failing status ( #13849 )
...
Track streams that have been disconnected due to an error and
set their statuses to failing.
2022-07-25 14:27:53 -07:00
Kyle Havlovitz
ec70713dd3
Merge pull request #13872 from hashicorp/remove-upstream-log
...
Remove extra logging from ingress upstream watch shutdown
2022-07-25 12:55:30 -07:00
David Yu
56a25ab6cc
docs: followup on grammar and typo for latency requirements ( #13888 )
2022-07-25 12:50:11 -07:00
alex
79bd7d1817
docs: add peering metric doc ( #13862 )
...
Co-authored-by: Freddy <freddygv@users.noreply.github.com>
Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>
Co-authored-by: trujillo-adam <47586768+trujillo-adam@users.noreply.github.com>
2022-07-25 12:43:06 -07:00
Chris S. Kim
1f8ae56951
Preserve PeeringState on upsert ( #13666 )
...
Fixes a bug where if the generate token is called twice, the second call upserts the zero-value (undefined) of PeeringState.
2022-07-25 14:37:56 -04:00