bbe0d6aa30
Fix panic bug in snapshot inspect ( #10091 )
...
* Fix panic bug in snapshot inspect
* Add changelog entry
* Update .changelog/10091.txt
* Undo bad GitHub UI merge
* Undo bad GitHub UI merge
2021-04-23 20:48:10 +01:00
5c409739c7
CLI: Allow snapshot inspect to work on internal raft snapshots directly. ( #10089 )
...
* CLI: Add support for reading internal raft snapshots to snapshot inspect
* Add snapshot inspect test for raw state files
* Add changelog entry
* Update .changelog/10089.txt
2021-04-23 16:17:08 +01:00
ef0999547a
testing: skip slow tests with -short
...
Add a skip condition to all tests slower than 100ms.
This change was made using `gotestsum tool slowest` with data from the
last 3 CI runs of master.
See https://github.com/gotestyourself/gotestsum#finding-and-skipping-slow-tests
With this change:
```
$ time go test -count=1 -short ./agent
ok github.com/hashicorp/consul/agent 0.743s
real 0m4.791s
$ time go test -count=1 -short ./agent/consul
ok github.com/hashicorp/consul/agent/consul 4.229s
real 0m8.769s
```
2020-12-07 13:42:55 -05:00
ff0009bd91
Fix some minor wording issues
2020-11-11 11:33:38 -06:00
31f3742308
Back out implicit -kvdetails functionality
2020-11-11 10:46:51 -06:00
2adbfbe8d4
Length check is required here
...
If one isn't included, then the nil check in the formatter never fails due to an empty slice being passed in, which causes the kv output to always get printed.
2020-11-11 10:44:55 -06:00
f949a3ed58
Remove trailing tabs from output
2020-11-10 16:40:23 -06:00
5f2896d4a7
Add more func comments
2020-11-10 16:40:12 -06:00
8bb2a274ce
Move kvDetails default logic
2020-11-10 16:39:40 -06:00
99698737d9
Check for nil rather than length
2020-11-10 16:39:12 -06:00
0369eb4a13
Update tests for new flag names
2020-11-10 11:18:21 -06:00
f29a28e038
Allow omission of -kvdetails if another -kv* flag is set
2020-11-10 10:55:30 -06:00
aa21a32ca5
Rename params to better reflect their purpose
2020-11-10 10:44:09 -06:00
4298a0f7e1
Make docs for params clearer
2020-11-10 10:35:24 -06:00
0553532e00
Break KV portion of enchance into separate func
2020-11-10 10:29:49 -06:00
354ff0a0d1
Move KV stat gen to separate func
2020-11-10 10:09:03 -06:00
2327149854
Pull sorting into separate function
2020-11-05 16:25:21 -06:00
ce61ef6170
Refactor to reduce how many vars are being passed around
2020-11-05 14:26:47 -06:00
1b2680af04
Fallback to alphabetic sorting if size is equal
2020-11-05 11:02:02 -06:00
4f60020908
Add tests for new snapshot inspect flags
2020-11-05 11:01:44 -06:00
6ed8d03fee
Update snapshot inspect formatter test
2020-11-05 10:40:02 -06:00
f93df8ce35
Make key breakdown total size accurate
2020-11-05 10:32:23 -06:00
dd83f6bc68
Cleanup formatter
2020-11-04 14:36:42 -06:00
0918d8dbc0
Get JSON formatting working
2020-11-04 14:04:17 -06:00
fd5b94443e
This ended up not being used.
2020-11-04 10:30:38 -06:00
ed91bf8a62
Add snapshot inspect filter param
2020-11-04 10:11:20 -06:00
bc1a55cd09
Initial stab at snapshot inspect key breakdown
2020-11-03 18:00:44 -06:00
ee3eb03f50
cli: Add JSON and Pretty Print formatting for `consul snapshot inspect` ( #9006 )
2020-10-29 11:31:14 -05:00
a62705101f
Enhance the output of consul snapshot inspect ( #8787 )
2020-10-09 14:57:29 -05:00
8d35e37b3c
testing: Remove all the defer os.Removeall
...
Now that testutil uses t.Cleanup to remove the directory the caller no longer has to manage
the removal
2020-08-14 19:58:53 -04:00
b68045e594
fix some flaky snapshot tests ( #8015 )
2020-06-03 14:18:52 -05:00
f1d8ea7018
cli: ensure that 'snapshot save' is fsync safe and also only writes to the requested file on success ( #7698 )
2020-04-24 17:34:47 -05:00
032e0ae901
cli: fix usage of gzip.Reader to better detect corrupt snapshots during save/restore ( #7697 )
2020-04-24 17:18:56 -05:00
8b6877febd
Remove name from NewTestAgent
...
Using:
git grep -l 'NewTestAgent(t, t.Name(),' | \
xargs sed -i -e 's/NewTestAgent(t, t.Name(),/NewTestAgent(t,/g'
2020-03-31 16:13:44 -04:00
d3c7d57209
Move internal/ to sdk/ ( #5568 )
...
* Move internal/ to sdk/
* Add a readme to the SDK folder
2019-03-27 08:54:56 -04:00
a41c865059
Convert to Go Modules ( #5517 )
...
* First conversion
* Use serf 0.8.2 tag and associated updated deps
* * Move freeport and testutil into internal/
* Make internal/ its own module
* Update imports
* Add replace statements so API and normal Consul code are
self-referencing for ease of development
* Adapt to newer goe/values
* Bump to new cleanhttp
* Fix ban nonprintable chars test
* Update lock bad args test
The error message when the duration cannot be parsed changed in Go 1.12
(ae0c435877d3aacb9af5e706c40f9dddde5d3e67). This updates that test.
* Update another test as well
* Bump travis
* Bump circleci
* Bump go-discover and godo to get rid of launchpad dep
* Bump dockerfile go version
* fix tar command
* Bump go-cleanhttp
2019-03-26 17:04:58 -04:00
a34f8c751e
Pass a testing.T into NewTestAgent and TestAgent.Start ( #5342 )
...
This way we can avoid unnecessary panics which cause other tests not to run.
This doesn't remove all the possibilities for panics causing other tests not to run, it just fixes the TestAgent
2019-02-14 10:59:14 -05:00
1dd8c378b9
Spelling ( #3958 )
...
* spelling: another
* spelling: autopilot
* spelling: beginning
* spelling: circonus
* spelling: default
* spelling: definition
* spelling: distance
* spelling: encountered
* spelling: enterprise
* spelling: expands
* spelling: exits
* spelling: formatting
* spelling: health
* spelling: hierarchy
* spelling: imposed
* spelling: independence
* spelling: inspect
* spelling: last
* spelling: latest
* spelling: client
* spelling: message
* spelling: minimum
* spelling: notify
* spelling: nonexistent
* spelling: operator
* spelling: payload
* spelling: preceded
* spelling: prepared
* spelling: programmatically
* spelling: required
* spelling: reconcile
* spelling: responses
* spelling: request
* spelling: response
* spelling: results
* spelling: retrieve
* spelling: service
* spelling: significantly
* spelling: specifies
* spelling: supported
* spelling: synchronization
* spelling: synchronous
* spelling: themselves
* spelling: unexpected
* spelling: validations
* spelling: value
2018-03-19 16:56:00 +00:00
fb464a8c0d
Fix a panic in snapshot inspect command
2017-10-30 14:51:08 -07:00
8f58a603ea
commands: get HTTP API flags for usage automatically
2017-10-18 00:08:45 +02:00
c10885f828
commands: run all tests in parallel (again)
2017-10-18 00:08:45 +02:00
efab66e616
commands: cleanup help and synopsis.
...
* move Help and Synopsis to bottom
* make help and synopsis constants
* make sure help output is formatted
2017-10-18 00:08:45 +02:00
a3a805d7b8
commands: do not run cmd tests in parallel
...
Package level parallelization is sufficient.
2017-10-18 00:08:45 +02:00
a6d912adb4
commands: cleanup test names
2017-10-18 00:08:45 +02:00
abd7c73627
commands: move snapshot subcommands to subdirs
2017-10-18 00:08:45 +02:00
8724aece07
commands: move snapshot command to separate pkg
2017-10-18 00:08:45 +02:00
Paul Banks