luxolus
/
open-consul
2
0
Fork 0
Code Issues 1 Pull Requests Packages Releases Wiki Activity

docs: Apply suggestions from code review 

Co-authored-by: Luke Kysow <1034429+lkysow@users.noreply.github.com>
Co-authored-by: trujillo-adam <47586768+trujillo-adam@users.noreply.github.com>
This commit is contained in:
Paul Glass 2021-09-16 10:19:15 -05:00 committed by GitHub
parent 3ca995cf8f
commit fc460c0a8d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
website/content/docs/ecs/get-started/install.mdx
View File

@ -62,7 +62,7 @@ however there are some important inputs worth highlighting:
This is where you include application containers. This is where you include application containers.
- `port` is the port that your application listens on. This should be set to a - `port` is the port that your application listens on. This should be set to a
string, not an integer, i.e. `port = "9090"`, not `port = 9090`. string, not an integer, i.e. `port = "9090"`, not `port = 9090`.
- `retry_join` is passed to the `-retry-join` option for the Consul agent. This tells - `retry_join` is passed to the [`-retry-join`](/docs/agent/options#_retry_join) option for the Consul agent. This tells
the agent the location of your Consul server so that it can join the Consul cluster. the agent the location of your Consul server so that it can join the Consul cluster.
To define an ECS service, reference the mesh-task module's `task_definition_arn` output value To define an ECS service, reference the mesh-task module's `task_definition_arn` output value
@ -91,10 +91,9 @@ proxy to listen on a different port for each upstream service your application
needs to call. You then must modify your application to make requests to the sidecar needs to call. You then must modify your application to make requests to the sidecar
proxy on that port. proxy on that port.
For example, say your application `web` wants to make calls to my other application For example, if your application `web` makes calls to another application called `backend`, then you would first configure the `mesh-task` module's upstream(s):
`backend`. `backend`.
First, you must configure the `mesh-task` module's upstream(s):
```hcl ```hcl
module "web" { module "web" {

2
website/content/docs/ecs/get-started/migrate-existing-tasks.mdx
View File

@ -7,7 +7,7 @@ description: >-
# Migrate Existing Tasks # Migrate Existing Tasks
This guide explains how to migrate your existing ECS Tasks to use our [`mesh-task` Terraform module](https://registry.terraform.io/modules/hashicorp/consul-ecs/aws/latest/submodules/mesh-task). This topic describes how to migrate your existing ECS Tasks to use our [`mesh-task` Terraform module](https://registry.terraform.io/modules/hashicorp/consul-ecs/aws/latest/submodules/mesh-task).
## Define Tasks in Terraform ## Define Tasks in Terraform