Adds check to verify that the API Gateway is being created with at least one listener
This commit is contained in:
parent
578eeeb653
commit
fa1b6e7450
|
@ -0,0 +1,3 @@
|
|||
```release-note:bug
|
||||
gateways: Adds validation to ensure the API Gateway has a listener defined when created
|
||||
```
|
|
@ -411,7 +411,16 @@ func TestConfigEntries_ListRelatedServices_AndACLs(t *testing.T) {
|
|||
},
|
||||
{
|
||||
name: "api-gateway",
|
||||
entry: &APIGatewayConfigEntry{Name: "test"},
|
||||
entry: &APIGatewayConfigEntry{
|
||||
Name: "test",
|
||||
Listeners: []APIGatewayListener{
|
||||
{
|
||||
Name: "test",
|
||||
Port: 100,
|
||||
Protocol: "http",
|
||||
},
|
||||
},
|
||||
},
|
||||
expectACLs: []testACL{
|
||||
{
|
||||
name: "no-authz",
|
||||
|
|
|
@ -769,6 +769,9 @@ func (e *APIGatewayConfigEntry) Validate() error {
|
|||
return err
|
||||
}
|
||||
|
||||
if len(e.Listeners) == 0 {
|
||||
return fmt.Errorf("api gateway must have at least one listener")
|
||||
}
|
||||
if err := e.validateListenerNames(); err != nil {
|
||||
return err
|
||||
}
|
||||
|
|
|
@ -1126,6 +1126,13 @@ func TestGatewayService_Addresses(t *testing.T) {
|
|||
|
||||
func TestAPIGateway_Listeners(t *testing.T) {
|
||||
cases := map[string]configEntryTestcase{
|
||||
"no listeners defined": {
|
||||
entry: &APIGatewayConfigEntry{
|
||||
Kind: "api-gateway",
|
||||
Name: "api-gw-one",
|
||||
},
|
||||
validateErr: "api gateway must have at least one listener",
|
||||
},
|
||||
"listener name conflict": {
|
||||
entry: &APIGatewayConfigEntry{
|
||||
Kind: "api-gateway",
|
||||
|
|
|
@ -27,6 +27,7 @@ are not supported from commands, but may be from the corresponding HTTP endpoint
|
|||
|
||||
| Config Entry Kind | Required ACL |
|
||||
| ------------------- | ------------------ |
|
||||
| api-gateway | `mesh:write` |
|
||||
| ingress-gateway | `operator:write` |
|
||||
| proxy-defaults | `operator:write` |
|
||||
| service-defaults | `service:write` |
|
||||
|
|
|
@ -27,6 +27,7 @@ are not supported from commands, but may be from the corresponding HTTP endpoint
|
|||
|
||||
| Config Entry Kind | Required ACL |
|
||||
| ------------------- | ----------------- |
|
||||
| api-gateway | `mesh:read` |
|
||||
| ingress-gateway | `service:read` |
|
||||
| proxy-defaults | `<none>` |
|
||||
| service-defaults | `service:read` |
|
||||
|
|
|
@ -28,6 +28,7 @@ are not supported from commands, but may be from the corresponding HTTP endpoint
|
|||
|
||||
| Config Entry Kind | Required ACL |
|
||||
| ------------------- | ----------------- |
|
||||
| api-gateway | `mesh:read` |
|
||||
| ingress-gateway | `service:read` |
|
||||
| proxy-defaults | `<none>` |
|
||||
| service-defaults | `service:read` |
|
||||
|
|
|
@ -30,6 +30,7 @@ are not supported from commands, but may be from the corresponding HTTP endpoint
|
|||
|
||||
| Config Entry Kind | Required ACL |
|
||||
| ------------------- | ------------------ |
|
||||
| api-gateway | `mesh:write` |
|
||||
| ingress-gateway | `operator:write` |
|
||||
| proxy-defaults | `operator:write` |
|
||||
| service-defaults | `service:write` |
|
||||
|
|
Loading…
Reference in New Issue