From e46a4b3cc1f321f360979e3fa0c9e70b58b3bd47 Mon Sep 17 00:00:00 2001 From: DanStough Date: Mon, 25 Jul 2022 18:18:00 -0400 Subject: [PATCH] fix: ipv4 destination dns resolution --- agent/xds/clusters.go | 2 +- ...-proxy-terminating-gateway-destinations-only.latest.golden | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/agent/xds/clusters.go b/agent/xds/clusters.go index 9f64c5e34..6f16b9bee 100644 --- a/agent/xds/clusters.go +++ b/agent/xds/clusters.go @@ -1494,7 +1494,7 @@ func (s *ResourceGenerator) makeTerminatingHostnameCluster(snap *proxycfg.Config // Having an empty config enables outlier detection with default config. OutlierDetection: &envoy_cluster_v3.OutlierDetection{}, ClusterDiscoveryType: &envoy_cluster_v3.Cluster_Type{Type: envoy_cluster_v3.Cluster_LOGICAL_DNS}, - DnsLookupFamily: envoy_cluster_v3.Cluster_AUTO, + DnsLookupFamily: envoy_cluster_v3.Cluster_V4_ONLY, } rate := 10 * time.Second diff --git a/agent/xds/testdata/clusters/transparent-proxy-terminating-gateway-destinations-only.latest.golden b/agent/xds/testdata/clusters/transparent-proxy-terminating-gateway-destinations-only.latest.golden index 0b298c990..58fa4e7e8 100644 --- a/agent/xds/testdata/clusters/transparent-proxy-terminating-gateway-destinations-only.latest.golden +++ b/agent/xds/testdata/clusters/transparent-proxy-terminating-gateway-destinations-only.latest.golden @@ -138,6 +138,7 @@ ] }, "dnsRefreshRate": "10s", + "dnsLookupFamily": "V4_ONLY", "outlierDetection": { } @@ -167,6 +168,7 @@ ] }, "dnsRefreshRate": "10s", + "dnsLookupFamily": "V4_ONLY", "outlierDetection": { }, @@ -218,6 +220,7 @@ ] }, "dnsRefreshRate": "10s", + "dnsLookupFamily": "V4_ONLY", "outlierDetection": { } @@ -247,6 +250,7 @@ ] }, "dnsRefreshRate": "10s", + "dnsLookupFamily": "V4_ONLY", "outlierDetection": { }