From db31599ae9d48f04eeede99d6076e0c59775e8f4 Mon Sep 17 00:00:00 2001 From: hc-github-team-consul-core Date: Thu, 21 Sep 2023 17:22:33 -0400 Subject: [PATCH] Backport of Dump response body on fail into release/1.16.x (#18964) backport of commit 5dbfce67aacbd26e74eebe2e275a9e2933f4a73f Co-authored-by: Chris S. Kim --- agent/metrics_test.go | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/agent/metrics_test.go b/agent/metrics_test.go index 76da0e55f..da853c56b 100644 --- a/agent/metrics_test.go +++ b/agent/metrics_test.go @@ -488,6 +488,13 @@ func TestHTTPHandlers_AgentMetrics_WAL_Prometheus(t *testing.T) { recordPromMetrics(t, a, respRec) out := respRec.Body.String() + defer func() { + if t.Failed() { + t.Log("--- Failed output START ---") + t.Log(out) + t.Log("--- Failed output END ---") + } + }() require.Contains(t, out, "agent_5_raft_wal_head_truncations") require.Contains(t, out, "agent_5_raft_wal_last_segment_age_seconds") require.Contains(t, out, "agent_5_raft_wal_log_appends") @@ -588,6 +595,13 @@ func TestHTTPHandlers_AgentMetrics_LogVerifier_Prometheus(t *testing.T) { recordPromMetrics(t, a, respRec) out := respRec.Body.String() + defer func() { + if t.Failed() { + t.Log("--- Failed output START ---") + t.Log(out) + t.Log("--- Failed output END ---") + } + }() require.Contains(t, out, "agent_5_raft_logstore_verifier_checkpoints_written") require.Contains(t, out, "agent_5_raft_logstore_verifier_dropped_reports") require.Contains(t, out, "agent_5_raft_logstore_verifier_ranges_verified")