luxolus
/
open-consul
2
0
Fork 0
Code Issues 1 Pull Requests Packages Releases Wiki Activity

xds: revert setting set_node_on_first_message_only to true when generating envoy bootstrap config (#8440) 

When consul is restarted and an envoy that had already sent
DiscoveryRequests to the previous consul process sends a request to the
new process it doesn't respect the setting and never populates
DiscoveryRequest.Node for the life of the new consul process due to this
bug: https://github.com/envoyproxy/envoy/issues/9682

Fixes #8430
This commit is contained in:
R.B. Boyer 2020-08-05 15:00:24 -05:00 committed by GitHub
parent 62641b820a
commit d57f04fd5b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
22 changed files with 0 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
command/connect/envoy/bootstrap_tpl.go
View File

@ -188,7 +188,6 @@ const bootstrapTemplate = `{
"cds_config": { "ads": {} },
"ads_config": {
"api_type": "GRPC",
"set_node_on_first_message_only": true,
"grpc_services": {
"initial_metadata": [
{

1
command/connect/envoy/testdata/CONSUL_HTTP_ADDR-with-https-scheme-enables-tls.golden vendored
View File

@ -97,7 +97,6 @@
},
"ads_config": {
"api_type": "GRPC",
"set_node_on_first_message_only": true,
"grpc_services": {
"initial_metadata": [
{

1
command/connect/envoy/testdata/access-log-path.golden vendored
View File

@ -88,7 +88,6 @@
},
"ads_config": {
"api_type": "GRPC",
"set_node_on_first_message_only": true,
"grpc_services": {
"initial_metadata": [
{

1
command/connect/envoy/testdata/defaults.golden vendored
View File

@ -88,7 +88,6 @@
},
"ads_config": {
"api_type": "GRPC",
"set_node_on_first_message_only": true,
"grpc_services": {
"initial_metadata": [
{

1
command/connect/envoy/testdata/existing-ca-file.golden vendored
View File

@ -97,7 +97,6 @@
},
"ads_config": {
"api_type": "GRPC",
"set_node_on_first_message_only": true,
"grpc_services": {
"initial_metadata": [
{

1
command/connect/envoy/testdata/extra_-multiple.golden vendored
View File

@ -110,7 +110,6 @@
},
"ads_config": {
"api_type": "GRPC",
"set_node_on_first_message_only": true,
"grpc_services": {
"initial_metadata": [
{

1
command/connect/envoy/testdata/extra_-single.golden vendored
View File

@ -101,7 +101,6 @@
},
"ads_config": {
"api_type": "GRPC",
"set_node_on_first_message_only": true,
"grpc_services": {
"initial_metadata": [
{

1
command/connect/envoy/testdata/grpc-addr-config.golden vendored
View File

@ -88,7 +88,6 @@
},
"ads_config": {
"api_type": "GRPC",
"set_node_on_first_message_only": true,
"grpc_services": {
"initial_metadata": [
{

1
command/connect/envoy/testdata/grpc-addr-env.golden vendored
View File

@ -88,7 +88,6 @@
},
"ads_config": {
"api_type": "GRPC",
"set_node_on_first_message_only": true,
"grpc_services": {
"initial_metadata": [
{

1
command/connect/envoy/testdata/grpc-addr-flag.golden vendored
View File

@ -88,7 +88,6 @@
},
"ads_config": {
"api_type": "GRPC",
"set_node_on_first_message_only": true,
"grpc_services": {
"initial_metadata": [
{

1
command/connect/envoy/testdata/grpc-addr-unix.golden vendored
View File

@ -87,7 +87,6 @@
},
"ads_config": {
"api_type": "GRPC",
"set_node_on_first_message_only": true,
"grpc_services": {
"initial_metadata": [
{

1
command/connect/envoy/testdata/ingress-gateway-address-specified.golden vendored
View File

@ -161,7 +161,6 @@
},
"ads_config": {
"api_type": "GRPC",
"set_node_on_first_message_only": true,
"grpc_services": {
"initial_metadata": [
{

1
command/connect/envoy/testdata/ingress-gateway-no-auto-register.golden vendored
View File

@ -161,7 +161,6 @@
},
"ads_config": {
"api_type": "GRPC",
"set_node_on_first_message_only": true,
"grpc_services": {
"initial_metadata": [
{

1
command/connect/envoy/testdata/ingress-gateway-register-with-service-and-proxy-id.golden vendored
View File

@ -161,7 +161,6 @@
},
"ads_config": {
"api_type": "GRPC",
"set_node_on_first_message_only": true,
"grpc_services": {
"initial_metadata": [
{

1
command/connect/envoy/testdata/ingress-gateway-register-with-service-without-proxy-id.golden vendored
View File

@ -161,7 +161,6 @@
},
"ads_config": {
"api_type": "GRPC",
"set_node_on_first_message_only": true,
"grpc_services": {
"initial_metadata": [
{

1
command/connect/envoy/testdata/ingress-gateway.golden vendored
View File

@ -161,7 +161,6 @@
},
"ads_config": {
"api_type": "GRPC",
"set_node_on_first_message_only": true,
"grpc_services": {
"initial_metadata": [
{

1
command/connect/envoy/testdata/stats-config-override.golden vendored
View File

@ -46,7 +46,6 @@
},
"ads_config": {
"api_type": "GRPC",
"set_node_on_first_message_only": true,
"grpc_services": {
"initial_metadata": [
{

1
command/connect/envoy/testdata/token-arg.golden vendored
View File

@ -88,7 +88,6 @@
},
"ads_config": {
"api_type": "GRPC",
"set_node_on_first_message_only": true,
"grpc_services": {
"initial_metadata": [
{

1
command/connect/envoy/testdata/token-env.golden vendored
View File

@ -88,7 +88,6 @@
},
"ads_config": {
"api_type": "GRPC",
"set_node_on_first_message_only": true,
"grpc_services": {
"initial_metadata": [
{

1
command/connect/envoy/testdata/token-file-arg.golden vendored
View File

@ -88,7 +88,6 @@
},
"ads_config": {
"api_type": "GRPC",
"set_node_on_first_message_only": true,
"grpc_services": {
"initial_metadata": [
{

1
command/connect/envoy/testdata/token-file-env.golden vendored
View File

@ -88,7 +88,6 @@
},
"ads_config": {
"api_type": "GRPC",
"set_node_on_first_message_only": true,
"grpc_services": {
"initial_metadata": [
{

1
command/connect/envoy/testdata/zipkin-tracing-config.golden vendored
View File

@ -121,7 +121,6 @@
},
"ads_config": {
"api_type": "GRPC",
"set_node_on_first_message_only": true,
"grpc_services": {
"initial_metadata": [
{