diff --git a/ui-v2/app/components/healthcheck-list/index.hbs b/ui-v2/app/components/healthcheck-list/index.hbs index fb07ce39e..178581ac1 100644 --- a/ui-v2/app/components/healthcheck-list/index.hbs +++ b/ui-v2/app/components/healthcheck-list/index.hbs @@ -1,47 +1,48 @@ - + diff --git a/ui-v2/app/components/healthcheck-list/index.js b/ui-v2/app/components/healthcheck-list/index.js index 092a1aada..479865264 100644 --- a/ui-v2/app/components/healthcheck-list/index.js +++ b/ui-v2/app/components/healthcheck-list/index.js @@ -1,36 +1,5 @@ import Component from '@ember/component'; -import { get } from '@ember/object'; export default Component.extend({ - // TODO: Could potentially do this on attr change - actions: { - sortChecksByImportance: function(a, b) { - const statusA = get(a, 'Status'); - const statusB = get(b, 'Status'); - switch (statusA) { - case 'passing': - // a = passing - // unless b is also passing then a is less important - return statusB === 'passing' ? 0 : 1; - case 'critical': - // a = critical - // unless b is also critical then a is more important - return statusB === 'critical' ? 0 : -1; - case 'warning': - // a = warning - switch (statusB) { - // b is passing so a is more important - case 'passing': - return -1; - // b is critical so a is less important - case 'critical': - return 1; - // a and b are both warning, therefore equal - default: - return 0; - } - } - return 0; - }, - }, + tagName: '', }); diff --git a/ui-v2/app/components/healthcheck-output/index.hbs b/ui-v2/app/components/healthcheck-output/index.hbs deleted file mode 100644 index 789e14afa..000000000 --- a/ui-v2/app/components/healthcheck-output/index.hbs +++ /dev/null @@ -1,8 +0,0 @@ -{{! TODO: this component and its parent should be moved to a single component }} -{{yield}} -
-
- {{yield}} -
- {{yield}} -
\ No newline at end of file diff --git a/ui-v2/app/components/healthcheck-output/index.js b/ui-v2/app/components/healthcheck-output/index.js deleted file mode 100644 index 35c2e7a28..000000000 --- a/ui-v2/app/components/healthcheck-output/index.js +++ /dev/null @@ -1,6 +0,0 @@ -import Component from '@ember/component'; -import Slotted from 'block-slots'; - -export default Component.extend(Slotted, { - classNames: ['healthcheck-output'], -}); diff --git a/ui-v2/app/controllers/dc/nodes/show.js b/ui-v2/app/controllers/dc/nodes/show.js index 0190caba7..0c23f88a2 100644 --- a/ui-v2/app/controllers/dc/nodes/show.js +++ b/ui-v2/app/controllers/dc/nodes/show.js @@ -23,34 +23,4 @@ export default Controller.extend(WithEventSource, { } } }), - actions: { - sortChecksByImportance: function(a, b) { - const statusA = get(a, 'Status'); - const statusB = get(b, 'Status'); - switch (statusA) { - case 'passing': - // a = passing - // unless b is also passing then a is less important - return statusB === 'passing' ? 0 : 1; - case 'critical': - // a = critical - // unless b is also critical then a is more important - return statusB === 'critical' ? 0 : -1; - case 'warning': - // a = warning - switch (statusB) { - // b is passing so a is more important - case 'passing': - return -1; - // b is critical so a is less important - case 'critical': - return 1; - // a and b are both warning, therefore equal - default: - return 0; - } - } - return 0; - }, - }, }); diff --git a/ui-v2/app/initializers/sort.js b/ui-v2/app/initializers/sort.js index 3065d0fc9..6ddcc3ef8 100644 --- a/ui-v2/app/initializers/sort.js +++ b/ui-v2/app/initializers/sort.js @@ -1,10 +1,12 @@ import service from 'consul-ui/sort/comparators/service'; +import check from 'consul-ui/sort/comparators/check'; export function initialize(container) { // Service-less injection using private properties at a per-project level const Sort = container.resolveRegistration('service:sort'); const comparators = { service: service(), + check: check(), }; Sort.reopen({ comparator: function(type) { diff --git a/ui-v2/app/sort/comparators/check.js b/ui-v2/app/sort/comparators/check.js new file mode 100644 index 000000000..c3993a903 --- /dev/null +++ b/ui-v2/app/sort/comparators/check.js @@ -0,0 +1,42 @@ +export default () => key => { + if (key.startsWith('Status:')) { + return function(itemA, itemB) { + const [, dir] = key.split(':'); + let a, b; + if (dir === 'asc') { + a = itemA; + b = itemB; + } else { + b = itemA; + a = itemB; + } + const statusA = a.Status; + const statusB = b.Status; + switch (statusA) { + case 'passing': + // a = passing + // unless b is also passing then a is less important + return statusB === 'passing' ? 0 : 1; + case 'critical': + // a = critical + // unless b is also critical then a is more important + return statusB === 'critical' ? 0 : -1; + case 'warning': + // a = warning + switch (statusB) { + // b is passing so a is more important + case 'passing': + return -1; + // b is critical so a is less important + case 'critical': + return 1; + // a and b are both warning, therefore equal + default: + return 0; + } + } + return 0; + }; + } + return key; +}; diff --git a/ui-v2/app/templates/dc/nodes/show/healthchecks.hbs b/ui-v2/app/templates/dc/nodes/show/healthchecks.hbs index cf44b208d..06836132e 100644 --- a/ui-v2/app/templates/dc/nodes/show/healthchecks.hbs +++ b/ui-v2/app/templates/dc/nodes/show/healthchecks.hbs @@ -1,7 +1,7 @@
{{#if (gt item.Checks.length 0) }} - + {{else}}

This node has no health checks. diff --git a/ui-v2/app/templates/dc/services/instance/healthchecks.hbs b/ui-v2/app/templates/dc/services/instance/healthchecks.hbs index cb61592e0..eb0d3d50c 100644 --- a/ui-v2/app/templates/dc/services/instance/healthchecks.hbs +++ b/ui-v2/app/templates/dc/services/instance/healthchecks.hbs @@ -2,7 +2,7 @@

{{#if (gt item.ServiceChecks.length 0) }}
- +
{{else}}

@@ -11,7 +11,7 @@ {{/if}} {{#if (gt item.NodeChecks.length 0) }}

- +
{{else}}

diff --git a/ui-v2/app/templates/dc/services/instance/proxy.hbs b/ui-v2/app/templates/dc/services/instance/proxy.hbs index 387b051c0..307963c25 100644 --- a/ui-v2/app/templates/dc/services/instance/proxy.hbs +++ b/ui-v2/app/templates/dc/services/instance/proxy.hbs @@ -140,7 +140,7 @@ {{#if (or (gt proxy.ServiceChecks.length 0) (gt proxy.NodeChecks.length 0))}}

Proxy health

- +
{{/if}}
diff --git a/ui-v2/tests/integration/components/healthcheck-output-test.js b/ui-v2/tests/integration/components/healthcheck-output-test.js deleted file mode 100644 index 8d079a08a..000000000 --- a/ui-v2/tests/integration/components/healthcheck-output-test.js +++ /dev/null @@ -1,23 +0,0 @@ -import { module, test } from 'qunit'; -import { setupRenderingTest } from 'ember-qunit'; -import { render, find } from '@ember/test-helpers'; -import hbs from 'htmlbars-inline-precompile'; - -module('Integration | Component | healthcheck output', function(hooks) { - setupRenderingTest(hooks); - - test('it renders', async function(assert) { - // Set any properties with this.set('myProperty', 'value'); - // Handle any actions with this.on('myAction', function(val) { ... }); - - await render(hbs`{{healthcheck-output}}`); - - assert.equal(find('*').textContent.trim(), ''); - - // Template block usage: - await render(hbs` - {{#healthcheck-output}}{{/healthcheck-output}} - `); - assert.equal(find('*').textContent.trim(), ''); - }); -});