ui: Rename extended Component variables, tweak some comments (#5021)

This commit is contained in:
John Cowen 2018-12-04 17:02:31 +00:00 committed by John Cowen
parent 589396b629
commit d083a13aa3
5 changed files with 8 additions and 8 deletions

View File

@ -1,11 +1,11 @@
import { get, set } from '@ember/object';
import { inject as service } from '@ember/service';
import Component from 'consul-ui/components/dom-buffer';
import DomBufferComponent from 'consul-ui/components/dom-buffer';
import SlotsMixin from 'block-slots';
import WithResizing from 'consul-ui/mixins/with-resizing';
import templatize from 'consul-ui/utils/templatize';
export default Component.extend(SlotsMixin, WithResizing, {
export default DomBufferComponent.extend(SlotsMixin, WithResizing, {
dom: service('dom'),
checked: true,
height: null,

View File

@ -1,8 +1,8 @@
import Component from 'consul-ui/components/dom-buffer-flush';
import DomBufferFlushComponent from 'consul-ui/components/dom-buffer-flush';
import { inject as service } from '@ember/service';
import { get } from '@ember/object';
export default Component.extend({
export default DomBufferFlushComponent.extend({
dom: service('dom'),
actions: {
change: function(e) {

View File

@ -1,4 +1,4 @@
import Component from 'ember-collection/components/ember-collection';
import CollectionComponent from 'ember-collection/components/ember-collection';
import needsRevalidate from 'ember-collection/utils/needs-revalidate';
import identity from 'ember-collection/utils/identity';
import Grid from 'ember-collection/layouts/grid';
@ -108,7 +108,7 @@ const change = function(e) {
}
}
};
export default Component.extend(SlotsMixin, WithResizing, {
export default CollectionComponent.extend(SlotsMixin, WithResizing, {
tagName: 'table',
classNames: ['dom-recycling'],
attributeBindings: ['style'],

View File

@ -14,7 +14,7 @@ const defaultChangeset = function(data, validators) {
return changeset;
};
/**
* Form builder/Form factory (WIP)
* Form builder/Form factory
* Deals with handling (generally change) events and updating data in response to the change
* in a typical data down event up manner
* validations are included currently using ember-changeset-validations

View File

@ -5,7 +5,7 @@ module.exports = function(defaults) {
const env = EmberApp.env();
const prodlike = ['production', 'staging'];
const isProd = env === 'production';
// leave this in for now for when I start a proper staging env
// if we ever need a 'prodlike' staging environment with staging settings
// const isProdLike = prodlike.indexOf(env) > -1;
const sourcemaps = !isProd;
let app = new EmberApp(