diff --git a/agent/connect/ca/provider.go b/agent/connect/ca/provider.go index 614a4456c..439c848eb 100644 --- a/agent/connect/ca/provider.go +++ b/agent/connect/ca/provider.go @@ -135,7 +135,7 @@ type PrimaryProvider interface { // the active intermediate. If multiple intermediates are needed to complete // the chain from the signing certificate back to the active root, they should // all by bundled here. - // TODO: replace with GenerateLeafSigningCert + // TODO: replace with GenerateLeafSigningCert (https://github.com/hashicorp/consul/issues/12386) GenerateIntermediate() (string, error) // SignIntermediate will validate the CSR to ensure the trust domain in the diff --git a/agent/connect/ca/provider_vault.go b/agent/connect/ca/provider_vault.go index 986813dbb..91b92528c 100644 --- a/agent/connect/ca/provider_vault.go +++ b/agent/connect/ca/provider_vault.go @@ -603,7 +603,6 @@ func (v *VaultProvider) SignIntermediate(csr *x509.CertificateRequest) (string, // CrossSignCA takes a CA certificate and cross-signs it to form a trust chain // back to our active root. func (v *VaultProvider) CrossSignCA(cert *x509.Certificate) (string, error) { - // TODO: is this necessary? Doesn't vault check this for us? rootPEM, err := v.getCA(v.config.RootPKIPath) if err != nil { return "", err diff --git a/agent/consul/leader_connect_ca.go b/agent/consul/leader_connect_ca.go index 71b21729f..35b4f343e 100644 --- a/agent/consul/leader_connect_ca.go +++ b/agent/consul/leader_connect_ca.go @@ -488,7 +488,7 @@ func (c *CAManager) primaryInitialize(provider ca.Provider, conf *structs.CAConf return err } - // TODO: delete this + // TODO: https://github.com/hashicorp/consul/issues/12386 interPEM, err := provider.GenerateIntermediate() if err != nil { return fmt.Errorf("error generating intermediate cert: %v", err) @@ -976,7 +976,7 @@ func (c *CAManager) primaryUpdateRootCA(newProvider ca.Provider, args *structs.C } } - // TODO: delete this + // TODO: https://github.com/hashicorp/consul/issues/12386 intermediate, err := newProvider.GenerateIntermediate() if err != nil { return err