luxolus
/
open-consul
2
0
Fork 0
Code Issues 1 Pull Requests Packages Releases Wiki Activity

Disable terminating-gateway for property-override (#17605) 

More validation is needed to ensure this behaves as expected; in the
meantime, align with docs and disable this proxy type.
This commit is contained in:
Michael Zalimeni 2023-06-07 15:39:25 -04:00 committed by GitHub
parent cf31d61b07
commit c9143cff36
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
agent/envoyextensions/builtin/property-override/property_override.go
View File

@ -106,8 +106,8 @@ var Ops = extensioncommon.StringSet{string(OpAdd): {}, string(OpRemove): {}}
// validProxyTypes is the set of supported proxy types for this extension.
var validProxyTypes = extensioncommon.StringSet{
string(api.ServiceKindConnectProxy): struct{}{},
string(api.ServiceKindTerminatingGateway): struct{}{},
// For now, we only support `connect-proxy`.
string(api.ServiceKindConnectProxy): struct{}{},
}
// Patch describes a single patch operation to modify the specific field of matching

2
agent/envoyextensions/builtin/property-override/property_override_test.go
View File

@ -618,7 +618,7 @@ func TestCanApply(t *testing.T) {
},
"invalid proxy type": {
ext: &propertyOverride{
ProxyType: api.ServiceKindTerminatingGateway,
ProxyType: api.ServiceKindConnectProxy,
},
conf: &extensioncommon.RuntimeConfig{
Kind: api.ServiceKindMeshGateway,