luxolus/open-consul
2
0
Fork 0
Code Issues 1 Pull requests Packages Releases Wiki Activity

Adds a paranoia set of the nodes slice to nil.

Browse source
This commit is contained in:
James Phillips 2015-11-14 21:59:08 -08:00
parent a0211db3b9
commit c032dee945
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
consul/prepared_query_endpoint.go
View file

@ -544,6 +544,14 @@ func queryFailover(q queryServer, query *structs.PreparedQuery,
// This keeps track of how many iterations we actually run. // This keeps track of how many iterations we actually run.
failovers++ failovers++
// Be super paranoid and set the nodes slice to nil since it's
// the same slice we used before. We know there's nothing in
// there, but the underlying msgpack library has a policy of
// updating the slice when it's non-nil, and that feels dirty.
// Let's just set it to nil so there's no way to communicate
// through this slice across successive RPC calls.
reply.Nodes = nil
// Note that we pass along the limit since it can be applied // Note that we pass along the limit since it can be applied
// remotely to save bandwidth. We also pass along the consistency // remotely to save bandwidth. We also pass along the consistency
// mode information we were given, so that applies to the remote // mode information we were given, so that applies to the remote