luxolus
/
open-consul
2
0
Fork 0
Code Issues 1 Pull Requests Packages Releases Wiki Activity

Fix a flaky test (#13282) 

At the end of this test we were trying to ensure that updating a service in the local state causes it to re-register the service with the config manager.

The config manager in the same method will also call RegisteredProxies to determine if any need to be removed. This portion of the test is not attempting to verify that behavior.

Because the test is only blocked waiting for the Register event before it can end and assert all the mock expectations were met, we may not see the call to RegisteredProxies. This is especially apparent when tests are run with the race detector.

As we don’t actually care if that method is executed before the end of the test we can simply transition from expecting it to be called exactly once to a 0 or 1 times assertion.
This commit is contained in:
Matt Keeler 2022-05-27 13:25:08 -04:00 committed by GitHub
parent e1b376f377
commit b9e8b5c692
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
agent/proxycfg-sources/local/sync_test.go
View File

@ -94,7 +94,7 @@ func TestSync(t *testing.T) {
// the user token).
cfgMgr.On("RegisteredProxies", source).
Return([]proxycfg.ProxyID{}).
Once()
Maybe()
state.AddService(&structs.NodeService{
ID: serviceID,