luxolus
/
open-consul
2
0
Fork 0
Code Issues 1 Pull Requests Packages Releases Wiki Activity

state: improve comments in catalog_events.go 

Co-authored-by: Paul Banks <banks@banksco.de>
This commit is contained in:
Daniel Nephin 2020-08-07 13:00:39 -04:00
parent 870823e8ed
commit b241debee7
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
agent/consul/state/catalog_events.go
View File

@ -49,7 +49,8 @@ func serviceHealthSnapshot(s *Store, topic topic) stream.SnapshotFunc {
event.Key = n.Service.Service event.Key = n.Service.Service
} }
// TODO: could all the events be appended as a single item? // append each event as a separate item so that they can be serialized
// separately, to prevent the encoding of one massive message.
buf.Append([]stream.Event{event}) buf.Append([]stream.Event{event})
} }
@ -100,7 +101,7 @@ func ServiceHealthEventsFromChanges(tx ReadTxn, changes Changes) ([]stream.Event
} }
// If the caller has an actual node mutation ensure we store it even if the // If the caller has an actual node mutation ensure we store it even if the
// node is already marked. If the caller is just marking the node dirty // node is already marked. If the caller is just marking the node dirty
// without an node change, don't overwrite any existing node change we know // without a node change, don't overwrite any existing node change we know
// about. // about.
if nodeChanges[node] == changeIndirect { if nodeChanges[node] == changeIndirect {
nodeChanges[node] = typ nodeChanges[node] = typ
@ -112,7 +113,7 @@ func ServiceHealthEventsFromChanges(tx ReadTxn, changes Changes) ([]stream.Event
} }
// If the caller has an actual service mutation ensure we store it even if // If the caller has an actual service mutation ensure we store it even if
// the service is already marked. If the caller is just marking the service // the service is already marked. If the caller is just marking the service
// dirty without an node change, don't overwrite any existing node change we // dirty without a service change, don't overwrite any existing service change we
// know about. // know about.
if serviceChanges[key].changeType == changeIndirect { if serviceChanges[key].changeType == changeIndirect {
serviceChanges[key] = svcChange serviceChanges[key] = svcChange
@ -146,7 +147,7 @@ func ServiceHealthEventsFromChanges(tx ReadTxn, changes Changes) ([]stream.Event
before := change.Before.(*structs.HealthCheck) before := change.Before.(*structs.HealthCheck)
after := change.After.(*structs.HealthCheck) after := change.After.(*structs.HealthCheck)
if after.ServiceID == "" || before.ServiceID == "" { if after.ServiceID == "" || before.ServiceID == "" {
// Either changed from or to being node-scoped // check before and/or after is node-scoped
markNode(after.Node, changeIndirect) markNode(after.Node, changeIndirect)
} else { } else {
// Check changed which means we just need to emit for the linked // Check changed which means we just need to emit for the linked